Skip to content
GitLab
  1. 02 Feb, 2022 1 commit
  3. 31 Jan, 2022 3 commits
  5. 29 Jan, 2022 3 commits
  7. 28 Jan, 2022 2 commits
  9. 26 Jan, 2022 3 commits
  11. 25 Jan, 2022 1 commit
  13. 24 Jan, 2022 1 commit
  15. 19 Jan, 2022 2 commits
  17. 18 Jan, 2022 1 commit
  19. 15 Jan, 2022 1 commit
  21. 14 Jan, 2022 2 commits
  23. 11 Jan, 2022 2 commits
  25. 10 Jan, 2022 1 commit
  27. 08 Jan, 2022 1 commit
    • Shahbaz Youssefi's avatar
      Vulkan: Distinguish RP and outside-RP command buffer types · acd8fc76
      Shahbaz Youssefi authored 
      What goes inside and outside a render pass command buffer is largely
mutually exclusive.  Moreover, the size and frequency of allocations is
different between the two.

This change distinguishes the C++ types used for inside and outside
render pass command buffers:

- The type now documents which command buffer a function is able to
  receive.
- `isRenderPass` flag passing, checking and asserting is largely
  removed.
- A follow up change experiments with using different (Vulkan vs ANGLE)
  secondary command buffers for inside and outside RP command buffers.
- A future change could specialize the pool behaviors per command buffer
  type.

Bug: angleproject:6811
Change-Id: Ia4bc669d26ac7e94e8a0dfb9b361666c82f42cc3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3344373


Reviewed-by: default avatarTim Van Patten <timvp@google.com>
Reviewed-by: default avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
      acd8fc76
  29. 06 Jan, 2022 4 commits
  31. 05 Jan, 2022 2 commits
    • Charlie Lao's avatar
      Vulkan: Consolidate mHostVisibleBufferPool and mMapInvalidate · 43b0e92b
      Charlie Lao authored 
      BufferVk::mHostVisibleBufferPool is allocated when BufferVk::mBuffer is
not hostvisible and we need to map it. In that case
mHostVisibleBufferPool is allocated and data copied from mBuffer to it
and the pointer to mHostVisibleBufferPool is returned to user.
BufferVk::mMapInvalidateRangeStagingBuffer is used when map is called on
a small range. In this case we allocate memory for the small range of
buffer and return that intead of waiting for entire buffer for GPU to
finish. Also when BufferSubData is called, we also needs to allocate a
staging buffer and issue a copyBuffer from staging buffer to main
buffer. This CL consolidate all these three usage cases into one
mStagingBuffer. It removes mHostVisibleBufferPool and
mMapInvalidateRangeStagingBuffer from BufferVk class. This makes overall
logic of managing data consistency much simpler as well since we only
have two buffers: The main buffer storage mBuffer or mStagingBuffer. And
mIsStagingBufferMapped tracks if mStagingBuffer is the one actually
mapped to user or not so that at unmap time we know if we should flush
the data to mBuffer or not.

Bug: b/208323792
Change-Id: I4f0c79a2d86da1a43844ed2ba83ddeb7dd4a5c0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3335216


Reviewed-by: default avatarLingfeng Yang <lfy@google.com>
Reviewed-by: default avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>
      43b0e92b
    • Peng Huang's avatar
      Do not pass mInstance to vkGetInstanceProcAddr · e9e9a2c6
      Peng Huang authored 
      for vkEnumerateInstanceVersion

Bug: angleproject:6869
Change-Id: Ifc93a067824c3467003a47bad240b3be10874ab0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3366038


Reviewed-by: default avatarShahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: default avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
      e9e9a2c6
  33. 30 Dec, 2021 1 commit
  35. 22 Dec, 2021 1 commit
  37. 20 Dec, 2021 2 commits
  39. 16 Dec, 2021 2 commits
  41. 15 Dec, 2021 2 commits
  43. 13 Dec, 2021 1 commit
  45. 04 Dec, 2021 1 commit