Skip to content
  • epriestley's avatar
    Respect repository identities when figuring out authors/committers in Herald pre-commit hook rules · 41f143f7
    epriestley authored
    Summary:
    Ref T13480. Currently, Herald commit hook rules use a raw address resolution query to identify the author and committer for a commit. This will get the wrong answer when the raw identity string has been explicitly bound to some non-default user (most often, it will fail to identify an author when one exists).
    
    Instead, use the "IdentityEngine" to properly resolve identities.
    
    Test Plan: Authored a commit as `X <y@example.com>`, a raw identity with no "natural" matches to users (e.g., no user with that email or username). Bound the identity to a particular user in Diffusion. Wrote a Herald pre-commit content rule, pushed the commit. Saw Herald recognize the correct user when evaluating rules.
    
    Maniphest Tasks: T13480
    
    Differential Revision: https://secure.phabricator.com/D20953
    41f143f7