Skip to content
  • epriestley's avatar
    Treat invalid policies as broadly similar to "no one" · 4dfdd0d3
    epriestley authored
    Summary:
    Ref T3903. Ref T603. We currently overreact to invalid policies. Instead:
    
      - For non-omnipotent users, just reject the viewer.
      - For omnipotent users, we already shortcircuit and permit the viewer.
      - Formalize and add test coverage for these behaviors.
    
    Also clean up some strings.
    
    The practical effect of this is that setting an object to an invalid policy (either intentionally or accidentally) doesn't break callers who are querying it.
    
    Test Plan:
      - Created a Legalpad document and set view policy to "asldkfnaslkdfna".
      - Verified this policy behaved as though it were "no one".
      - Added, executed unit tests.
    
    Reviewers: btrahan
    
    Reviewed By: btrahan
    
    CC: aran
    
    Maniphest Tasks: T603, T3903
    
    Differential Revision: https://secure.phabricator.com/D7185
    4dfdd0d3