Skip to content
  • epriestley's avatar
    Distinguish between invalid/broken handles and filtered handles · 95c2b03f
    epriestley authored
    Summary:
    Ref T603. Currently, we render handles the user doesn't have permission to see in a manner identical to handles that don't exist. This is confusing, and not required by policies (which restrict content, but permit knowledge that an object exists).
    
    Instead, render them in different styles. Bad/invalid objects look like:
    
      Unknown Object (Task)
    
    Restricted objects look like:
    
      [o] Restricted Task
    
    ...where `[o]` is the padlock icon.
    
    Test Plan:
    {F71100}
    
    {F71101}
    
    It's possible this renders weird somewhere, but I wasn't immediately able to find any issues. Yell if you see something.
    
    Reviewers: btrahan, chad
    
    Reviewed By: btrahan
    
    CC: chad, aran
    
    Maniphest Tasks: T603
    
    Differential Revision: https://secure.phabricator.com/D7334
    95c2b03f