Skip to content
  • epriestley's avatar
    Fix an issue with selecting the right stemmed ngrams with Ferret engine queries · fdc0d8c2
    epriestley authored
    Summary:
    Ref T12819. In D18581, I corrected one bug (ngram selection for terms) but introduced a minor new bug. We now pass `' query '` (term corpus with boundary spaces) to the stemmer, but it bails out on this since English words don't start with spaces.
    
    Trim these extra boundary spaces off before invoking the stemmer.
    
    The practical effect of this is that searching for non-stem variations of a word ("detection") now finds stemmed variations again ("detect"). Prior to fixing this bug, the stem could find longer variations but not the other way around.
    
    Test Plan: Searched for "detection", found results matching "detect" after patch (and saw same results for "detect" and "detection").
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T12819
    
    Differential Revision: https://secure.phabricator.com/D18593
    fdc0d8c2