Commit 3cf9a582 authored by Joshua Spence's avatar Joshua Spence
Browse files

Minor formatting changes

Summary: Apply some autofix linter rules.

Test Plan: `arc lint` and `arc unit`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D10585
parent fcd2025a
......@@ -98,7 +98,7 @@ foreach (Futures($futures)->limit(8) as $file => $future) {
}
}
function print_symbol($file, $type, $token, $context=null) {
function print_symbol($file, $type, $token, $context = null) {
$parts = array(
$context ? $context->getConcreteString() : '',
// variable tokens are `$name`, not just `name`, so strip the $ off of
......
......@@ -306,7 +306,8 @@ class AphrontDefaultApplicationConfiguration
array(
'uri' => $uri,
'external' => $external,
));
),
);
}
}
......@@ -47,7 +47,8 @@ final class DarkConsoleRequestPlugin extends DarkConsolePlugin {
if (isset($mask[$key])) {
$rows[] = array(
$key,
phutil_tag('em', array(), '(Masked)'));
phutil_tag('em', array(), '(Masked)'),
);
} else {
$rows[] = array(
$key,
......
......@@ -82,7 +82,8 @@ final class AphrontFileResponse extends AphrontResponse {
if ($this->allowOrigins) {
$headers[] = array(
'Access-Control-Allow-Origin',
implode(',', $this->allowOrigins));
implode(',', $this->allowOrigins),
);
}
$headers = array_merge(parent::getHeaders(), $headers);
......
......@@ -109,23 +109,28 @@ abstract class AphrontResponse {
if ($this->cacheable) {
$headers[] = array(
'Expires',
$this->formatEpochTimestampForHTTPHeader(time() + $this->cacheable));
$this->formatEpochTimestampForHTTPHeader(time() + $this->cacheable),
);
} else {
$headers[] = array(
'Cache-Control',
'private, no-cache, no-store, must-revalidate');
'private, no-cache, no-store, must-revalidate',
);
$headers[] = array(
'Pragma',
'no-cache');
'no-cache',
);
$headers[] = array(
'Expires',
'Sat, 01 Jan 2000 00:00:00 GMT');
'Sat, 01 Jan 2000 00:00:00 GMT',
);
}
if ($this->lastModified) {
$headers[] = array(
'Last-Modified',
$this->formatEpochTimestampForHTTPHeader($this->lastModified));
$this->formatEpochTimestampForHTTPHeader($this->lastModified),
);
}
// IE has a feature where it may override an explicit Content-Type
......
......@@ -82,7 +82,8 @@ final class PhabricatorCommitSearchEngine
array(
$auditor_phids,
$commit_author_phids,
$repository_phids));
$repository_phids,
));
$handles = id(new PhabricatorHandleQuery())
->setViewer($this->requireViewer())
......
......@@ -22,7 +22,8 @@ final class PhabricatorAuthValidateController
array(
pht(
'Login validation is missing expected parameter ("%s").',
'phusr')));
'phusr'),
));
}
$expect_phusr = $request->getStr('expect');
......
......@@ -243,7 +243,7 @@ abstract class PhabricatorAuthProvider {
$image_uri,
array(
'name' => $name,
'canCDN' => true
'canCDN' => true,
));
unset($unguarded);
......
......@@ -55,7 +55,8 @@ final class CalendarTimeUtilTestCase extends PhabricatorTestCase {
'Wednesday',
'Thursday',
'Friday',
'Saturday');
'Saturday',
);
}
}
......@@ -103,7 +103,8 @@ final class PhabricatorCalendarViewController
phutil_tag(
'a',
array(
'href' => $login_uri),
'href' => $login_uri,
),
pht('Log in'))));
}
......
......@@ -24,7 +24,8 @@ final class CalendarTimeUtil {
return array(
'start_epoch' => $start_day->format('U'),
'end_epoch' => $end_day->format('U'));
'end_epoch' => $end_day->format('U'),
);
}
public static function getCalendarWeekTimestamps(
......@@ -56,7 +57,8 @@ final class CalendarTimeUtil {
}
return array(
'today' => $objects['today'],
'epoch_stamps' => $timestamps);
'epoch_stamps' => $timestamps,
);
}
private static function getStartDateTimeObjects(
......@@ -80,7 +82,8 @@ final class CalendarTimeUtil {
}
return array(
'today' => $today,
'start_day' => $start_day);
'start_day' => $start_day,
);
}
}
......@@ -120,7 +120,7 @@ final class PhabricatorChatLogChannelLogController
'a',
array(
'href' => $href,
'class' => 'timestamp'
'class' => 'timestamp',
),
$timestamp);
......@@ -129,11 +129,12 @@ final class PhabricatorChatLogChannelLogController
$message = phutil_tag(
'td',
array(
'class' => 'message'
'class' => 'message',
),
array(
$timestamp,
$message));
$message,
));
$out[] = phutil_tag(
'tr',
......@@ -142,7 +143,8 @@ final class PhabricatorChatLogChannelLogController
),
array(
$author,
$message));
$message,
));
}
$links = array();
......@@ -210,41 +212,41 @@ final class PhabricatorChatLogChannelLogController
$table = phutil_tag(
'table',
array(
'class' => 'phabricator-chat-log'
'class' => 'phabricator-chat-log',
),
$out);
$log = phutil_tag(
'div',
array(
'class' => 'phabricator-chat-log-panel'
'class' => 'phabricator-chat-log-panel',
),
$table);
$jump_link = phutil_tag(
'a',
array(
'href' => '#latest'
'href' => '#latest',
),
pht('Jump to Bottom')." \xE2\x96\xBE");
$jump = phutil_tag(
'div',
array(
'class' => 'phabricator-chat-log-jump'
'class' => 'phabricator-chat-log-jump',
),
$jump_link);
$jump_target = phutil_tag(
'div',
array(
'id' => 'latest'
'id' => 'latest',
));
$content = phutil_tag(
'div',
array(
'class' => 'phabricator-chat-log-wrap'
'class' => 'phabricator-chat-log-wrap',
),
array(
$jump,
......
......@@ -279,7 +279,7 @@ final class PhabricatorConduitAPIController
if (!$session_key) {
return array(
'ERR-INVALID-SESSION',
'Session key is not present.'
'Session key is not present.',
);
}
......
......@@ -31,7 +31,7 @@ final class PhabricatorSetupCheckDaemons extends PhabricatorSetupCheck {
'a',
array(
'href' => $doc_href,
'target' => '_blank'
'target' => '_blank',
),
pht('Managing Daemons with phd')));
......@@ -100,14 +100,14 @@ final class PhabricatorSetupCheckDaemons extends PhabricatorSetupCheck {
'a',
array(
'href' => '/daemon/',
'target' => '_blank'
'target' => '_blank',
),
pht('Daemon Console')),
phutil_tag(
'a',
array(
'href' => $doc_href,
'target' => '_blank'
'target' => '_blank',
),
pht('Managing Daemons with phd')),
phutil_tag('tt', array(), 'PHABRICATOR_ENV'),
......
......@@ -25,7 +25,8 @@ final class PhabricatorConfigDatabaseIssueController
null,
null,
null,
$issue);
$issue,
);
}
foreach ($database->getTables() as $table_name => $table) {
foreach ($table->getLocalIssues() as $issue) {
......@@ -34,7 +35,8 @@ final class PhabricatorConfigDatabaseIssueController
$table_name,
null,
null,
$issue);
$issue,
);
}
foreach ($table->getColumns() as $column_name => $column) {
foreach ($column->getLocalIssues() as $issue) {
......@@ -43,7 +45,8 @@ final class PhabricatorConfigDatabaseIssueController
$table_name,
'column',
$column_name,
$issue);
$issue,
);
}
}
foreach ($table->getKeys() as $key_name => $key) {
......@@ -53,7 +56,8 @@ final class PhabricatorConfigDatabaseIssueController
$table_name,
'key',
$key_name,
$issue);
$issue,
);
}
}
}
......
......@@ -372,7 +372,7 @@ final class PhabricatorConfigDatabaseStatusController
null,
null,
null,
null
null,
));
$key_rows = array();
......
......@@ -21,7 +21,7 @@ final class PhabricatorConfigListController
$nav->appendChild(
array(
$box
$box,
));
$crumbs = $this
......
......@@ -122,7 +122,7 @@ final class PhabricatorConfigEditor
->setNewValue(
array(
'deleted' => false,
'value' => $value
'value' => $value,
));
$editor = id(new PhabricatorConfigEditor())
......
......@@ -17,7 +17,7 @@ final class PhabricatorAuthenticationConfigOptions
->setBoolOptions(
array(
pht('Require email verification'),
pht("Don't require email verification")
pht("Don't require email verification"),
))
->setSummary(
pht('Require email verification before a user can log in.'))
......@@ -77,7 +77,7 @@ final class PhabricatorAuthenticationConfigOptions
->setBoolOptions(
array(
pht('Allow editing'),
pht('Prevent editing')
pht('Prevent editing'),
))
->setSummary(
pht(
......
......@@ -94,7 +94,7 @@ final class PhabricatorCoreConfigOptions
->setBoolOptions(
array(
pht('Enable Prototypes'),
pht('Disable Prototypes')
pht('Disable Prototypes'),
))
->setSummary(
pht(
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment