Commit 8756d82c authored by Joshua Spence's avatar Joshua Spence
Browse files

Remove `@group` annotations

Summary: I'm pretty sure that `@group` annotations are useless now... see D9855. Also fixed various other minor issues.

Test Plan: Eye-ball it.

Reviewers: #blessed_reviewers, epriestley, chad

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D9859
parent 1d4b0647
......@@ -798,7 +798,7 @@ return array(
// '#/autobuilt/#',
),
// If you set this to true, users can accept their own revisions. This action
// If you set this to true, users can accept their own revisions. This action
// is disabled by default because it's most likely not a behavior you want,
// but it proves useful if you are working alone on a project and want to make
// use of all of differential's features.
......@@ -817,7 +817,7 @@ return array(
// If you set this to true, any user can reopen a revision so long as it has
// been closed. This can be useful if a revision is accidentally closed or
// if a developer changes his or her mind after closing a revision. If it is
// if a developer changes his or her mind after closing a revision. If it is
// false, reopening is not allowed.
'differential.allow-reopen' => false,
......
......@@ -27,8 +27,6 @@ use Balanced\Card;
* <li>$BALANCED_URL_ROOT If set applies to \Balanced\Settings::$url_root.
* <li>$BALANCED_API_KEY If set applies to \Balanced\Settings::$api_key.
* </ul>
*
* @group suite
*/
class SuiteTest extends \PHPUnit_Framework_TestCase
{
......@@ -784,17 +782,17 @@ class SuiteTest extends \PHPUnit_Framework_TestCase
}
function testEvents() {
$prev_num_events = Marketplace::mine()->events->total();
$account = self::_createBuyer();
$account->debit(123);
$cur_num_events = Marketplace::mine()->events->total();
$count = 0;
$prev_num_events = Marketplace::mine()->events->total();
$account = self::_createBuyer();
$account->debit(123);
$cur_num_events = Marketplace::mine()->events->total();
$count = 0;
while ($cur_num_events == $prev_num_events && $count < 10) {
printf("waiting for events - %d, %d == %d\n", $count + 1, $cur_num_events, $prev_num_events);
sleep(2); // 2 seconds
$cur_num_events = Marketplace::mine()->events->total();
$count += 1;
}
$cur_num_events = Marketplace::mine()->events->total();
$count += 1;
}
$this->assertTrue($cur_num_events > $prev_num_events);
}
}
<?php
/**
* @group aphront
*/
abstract class AphrontController extends Phobject {
private $request;
......
<?php
/**
* @group aphront
*/
final class AphrontURIMapper {
private $map;
......@@ -49,4 +46,5 @@ final class AphrontURIMapper {
return array(null, null);
}
}
......@@ -2,7 +2,6 @@
/**
* @task routing URI Routing
* @group aphront
*/
abstract class AphrontApplicationConfiguration {
......@@ -228,4 +227,5 @@ abstract class AphrontApplicationConfiguration {
return array($controller, $uri_data);
}
}
......@@ -4,7 +4,6 @@
* NOTE: Do not extend this!
*
* @concrete-extensible
* @group aphront
*/
class AphrontDefaultApplicationConfiguration
extends AphrontApplicationConfiguration {
......
<?php
/**
* @group console
*/
final class DarkConsoleController extends PhabricatorController {
protected $op;
......
<?php
/**
* @group console
*/
final class DarkConsoleCore {
private $plugins = array();
......
<?php
/**
* @group console
*/
final class DarkConsoleDataController extends PhabricatorController {
private $key;
......
<?php
/**
* @group console
*/
final class DarkConsoleErrorLogPlugin extends DarkConsolePlugin {
public function getName() {
......@@ -98,4 +95,5 @@ final class DarkConsoleErrorLogPlugin extends DarkConsolePlugin {
phutil_tag('pre', array('class' => 'PhabricatorMonospaced'), $details),
));
}
}
<?php
/**
* @group console
*/
final class DarkConsoleEventPlugin extends DarkConsolePlugin {
public function getName() {
......@@ -14,7 +11,6 @@ final class DarkConsoleEventPlugin extends DarkConsolePlugin {
}
public function generateData() {
$listeners = PhutilEventEngine::getInstance()->getAllListeners();
foreach ($listeners as $key => $listener) {
$listeners[$key] = array(
......@@ -95,4 +91,5 @@ final class DarkConsoleEventPlugin extends DarkConsolePlugin {
return phutil_implode_html("\n", $out);
}
}
<?php
/**
* @group console
*/
abstract class DarkConsolePlugin {
private $data;
......@@ -13,9 +10,7 @@ abstract class DarkConsolePlugin {
abstract public function getDescription();
abstract public function renderPanel();
public function __construct() {
}
public function __construct() {}
public function getColor() {
return null;
......
<?php
/**
* @group console
*/
final class DarkConsoleRequestPlugin extends DarkConsolePlugin {
public function getName() {
......
<?php
/**
* @group console
*/
final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
protected $observations;
......@@ -36,7 +33,6 @@ final class DarkConsoleServicesPlugin extends DarkConsolePlugin {
* @phutil-external-symbol class PhabricatorStartup
*/
public function generateData() {
$should_analyze = self::isQueryAnalyzerRequested();
$log = PhutilServiceProfiler::getInstance()->getServiceCallLog();
......
<?php
/**
* @group console
*/
final class DarkConsoleXHProfPlugin extends DarkConsolePlugin {
protected $profileFilePHID;
......
<?php
/**
* @group console
*/
final class DarkConsoleErrorLogPluginAPI {
private static $errors = array();
......
<?php
/**
* @group console
*/
final class DarkConsoleEventPluginAPI extends PhabricatorEventListener {
private static $events = array();
......
<?php
/**
* @group console
* @phutil-external-symbol function xhprof_enable
* @phutil-external-symbol function xhprof_disable
*/
......
<?php
/**
* @group aphront
*/
final class Aphront304Response extends AphrontResponse {
public function getHTTPResponseCode() {
......
<?php
/**
* @group aphront
*/
final class Aphront400Response extends AphrontResponse {
public function getHTTPResponseCode() {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment