Commit fe2a96e3 authored by Chad Little's avatar Chad Little
Browse files

Update Form Layouts

Summary:
This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere.

TODO: will take another pass as consolidating these colors and new gradients in another diff.

Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D6806
parent 320498d3
......@@ -31,6 +31,11 @@
"rule" : ".gradient-grey-header",
"hash" : "1c8f8d61984e3fc5a7e528b9bd4d484a"
},
"gradient-lightblue-header" : {
"name" : "gradient-lightblue-header",
"rule" : ".gradient-lightblue-header",
"hash" : "b838d2eb15f9b620e82b4da240bf464a"
},
"gradient-menu-label" : {
"name" : "gradient-menu-label",
"rule" : ".gradient-menu-label, .phabricator-side-menu .phui-list-item-type-label",
......
......@@ -70,7 +70,7 @@ $package_spec = array(
'phui-button-css',
'phabricator-standard-page-view',
'aphront-dialog-view-css',
'aphront-form-view-css',
'phui-form-view-css',
'aphront-panel-view-css',
'aphront-table-view-css',
'aphront-tokenizer-control-css',
......@@ -97,7 +97,6 @@ $package_spec = array(
'phabricator-notification-menu-css',
'lightbox-attachment-css',
'phabricator-header-view-css',
'phabricator-form-view-css',
'phabricator-filetree-view-css',
'phabricator-nav-view-css',
'phabricator-side-menu-view-css',
......
......@@ -632,8 +632,8 @@ celerity_register_resource_map(array(
),
'/rsrc/image/sprite-gradient.png' =>
array(
'hash' => 'a49d2e493dba4bea85bb202af528106a',
'uri' => '/res/a49d2e49/rsrc/image/sprite-gradient.png',
'hash' => 'c6c42387e625948e683d9d8c62ea1b7f',
'uri' => '/res/c6c42387/rsrc/image/sprite-gradient.png',
'disk' => '/rsrc/image/sprite-gradient.png',
'type' => 'png',
),
......@@ -836,7 +836,7 @@ celerity_register_resource_map(array(
),
'aphront-dialog-view-css' =>
array(
'uri' => '/res/29a054fd/rsrc/css/aphront/dialog-view.css',
'uri' => '/res/c7a7e179/rsrc/css/aphront/dialog-view.css',
'type' => 'css',
'requires' =>
array(
......@@ -845,25 +845,16 @@ celerity_register_resource_map(array(
),
'aphront-error-view-css' =>
array(
'uri' => '/res/e2bb50c4/rsrc/css/aphront/error-view.css',
'uri' => '/res/4ba306a0/rsrc/css/aphront/error-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/error-view.css',
),
'aphront-form-view-css' =>
array(
'uri' => '/res/1be2545a/rsrc/css/aphront/form-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/form-view.css',
),
'aphront-list-filter-view-css' =>
array(
'uri' => '/res/a90a0c94/rsrc/css/aphront/list-filter-view.css',
'uri' => '/res/9fd0aae6/rsrc/css/aphront/list-filter-view.css',
'type' => 'css',
'requires' =>
array(
......@@ -899,7 +890,7 @@ celerity_register_resource_map(array(
),
'aphront-panel-view-css' =>
array(
'uri' => '/res/f55024c3/rsrc/css/aphront/panel-view.css',
'uri' => '/res/e19deae5/rsrc/css/aphront/panel-view.css',
'type' => 'css',
'requires' =>
array(
......@@ -990,7 +981,7 @@ celerity_register_resource_map(array(
),
'conpherence-message-pane-css' =>
array(
'uri' => '/res/80cde760/rsrc/css/application/conpherence/message-pane.css',
'uri' => '/res/4f3bfae5/rsrc/css/application/conpherence/message-pane.css',
'type' => 'css',
'requires' =>
array(
......@@ -2178,7 +2169,7 @@ celerity_register_resource_map(array(
),
'javelin-behavior-phabricator-transaction-list' =>
array(
'uri' => '/res/db441ac4/rsrc/js/application/transactions/behavior-transaction-list.js',
'uri' => '/res/f05b3c6b/rsrc/js/application/transactions/behavior-transaction-list.js',
'type' => 'js',
'requires' =>
array(
......@@ -3063,7 +3054,7 @@ celerity_register_resource_map(array(
),
'phabricator-core-css' =>
array(
'uri' => '/res/bb4b77f3/rsrc/css/core/core.css',
'uri' => '/res/9e767fb1/rsrc/css/core/core.css',
'type' => 'css',
'requires' =>
array(
......@@ -3181,15 +3172,6 @@ celerity_register_resource_map(array(
),
'disk' => '/rsrc/css/application/flag/flag.css',
),
'phabricator-form-view-css' =>
array(
'uri' => '/res/ba05f8ba/rsrc/css/layout/phabricator-form-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-form-view.css',
),
'phabricator-header-view-css' =>
array(
'uri' => '/res/da35cfa0/rsrc/css/layout/phabricator-header-view.css',
......@@ -3404,7 +3386,7 @@ celerity_register_resource_map(array(
),
'phabricator-remarkup-css' =>
array(
'uri' => '/res/8531b6a1/rsrc/css/core/remarkup.css',
'uri' => '/res/d0af3cab/rsrc/css/core/remarkup.css',
'type' => 'css',
'requires' =>
array(
......@@ -3443,7 +3425,7 @@ celerity_register_resource_map(array(
),
'phabricator-side-menu-view-css' =>
array(
'uri' => '/res/f43a8365/rsrc/css/layout/phabricator-side-menu-view.css',
'uri' => '/res/e83fbe58/rsrc/css/layout/phabricator-side-menu-view.css',
'type' => 'css',
'requires' =>
array(
......@@ -3766,7 +3748,7 @@ celerity_register_resource_map(array(
),
'phui-box-css' =>
array(
'uri' => '/res/1b741073/rsrc/css/phui/phui-box.css',
'uri' => '/res/8244305c/rsrc/css/phui/phui-box.css',
'type' => 'css',
'requires' =>
array(
......@@ -3802,13 +3784,22 @@ celerity_register_resource_map(array(
),
'phui-form-css' =>
array(
'uri' => '/res/c02b6db7/rsrc/css/phui/phui-form.css',
'uri' => '/res/8f33e95f/rsrc/css/phui/phui-form.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-form.css',
),
'phui-form-view-css' =>
array(
'uri' => '/res/52025834/rsrc/css/phui/phui-form-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/phui/phui-form-view.css',
),
'phui-icon-view-css' =>
array(
'uri' => '/res/f78f4c64/rsrc/css/phui/phui-icon.css',
......@@ -3838,7 +3829,7 @@ celerity_register_resource_map(array(
),
'phui-remarkup-preview-css' =>
array(
'uri' => '/res/4535e062/rsrc/css/phui/phui-remarkup-preview.css',
'uri' => '/res/3cba9fbc/rsrc/css/phui/phui-remarkup-preview.css',
'type' => 'css',
'requires' =>
array(
......@@ -4081,7 +4072,7 @@ celerity_register_resource_map(array(
),
'sprite-gradient-css' =>
array(
'uri' => '/res/af8d50a1/rsrc/css/sprite-gradient.css',
'uri' => '/res/08c64fb3/rsrc/css/sprite-gradient.css',
'type' => 'css',
'requires' =>
array(
......@@ -4172,7 +4163,7 @@ celerity_register_resource_map(array(
), array(
'packages' =>
array(
'4a060444' =>
'4c072d06' =>
array(
'name' => 'core.pkg.css',
'symbols' =>
......@@ -4182,7 +4173,7 @@ celerity_register_resource_map(array(
2 => 'phui-button-css',
3 => 'phabricator-standard-page-view',
4 => 'aphront-dialog-view-css',
5 => 'aphront-form-view-css',
5 => 'phui-form-view-css',
6 => 'aphront-panel-view-css',
7 => 'aphront-table-view-css',
8 => 'aphront-tokenizer-control-css',
......@@ -4205,22 +4196,21 @@ celerity_register_resource_map(array(
25 => 'phabricator-notification-menu-css',
26 => 'lightbox-attachment-css',
27 => 'phabricator-header-view-css',
28 => 'phabricator-form-view-css',
29 => 'phabricator-filetree-view-css',
30 => 'phabricator-nav-view-css',
31 => 'phabricator-side-menu-view-css',
32 => 'phabricator-crumbs-view-css',
33 => 'phabricator-object-item-list-view-css',
34 => 'global-drag-and-drop-css',
35 => 'phui-spacing-css',
36 => 'phui-form-css',
37 => 'phui-icon-view-css',
38 => 'phabricator-application-launch-view-css',
39 => 'phabricator-action-list-view-css',
40 => 'phabricator-property-list-view-css',
41 => 'phabricator-tag-view-css',
28 => 'phabricator-filetree-view-css',
29 => 'phabricator-nav-view-css',
30 => 'phabricator-side-menu-view-css',
31 => 'phabricator-crumbs-view-css',
32 => 'phabricator-object-item-list-view-css',
33 => 'global-drag-and-drop-css',
34 => 'phui-spacing-css',
35 => 'phui-form-css',
36 => 'phui-icon-view-css',
37 => 'phabricator-application-launch-view-css',
38 => 'phabricator-action-list-view-css',
39 => 'phabricator-property-list-view-css',
40 => 'phabricator-tag-view-css',
),
'uri' => '/res/pkg/4a060444/core.pkg.css',
'uri' => '/res/pkg/4c072d06/core.pkg.css',
'type' => 'css',
),
'4f81c788' =>
......@@ -4411,16 +4401,15 @@ celerity_register_resource_map(array(
),
'reverse' =>
array(
'aphront-dialog-view-css' => '4a060444',
'aphront-error-view-css' => '4a060444',
'aphront-form-view-css' => '4a060444',
'aphront-list-filter-view-css' => '4a060444',
'aphront-pager-view-css' => '4a060444',
'aphront-panel-view-css' => '4a060444',
'aphront-table-view-css' => '4a060444',
'aphront-tokenizer-control-css' => '4a060444',
'aphront-tooltip-css' => '4a060444',
'aphront-typeahead-control-css' => '4a060444',
'aphront-dialog-view-css' => '4c072d06',
'aphront-error-view-css' => '4c072d06',
'aphront-list-filter-view-css' => '4c072d06',
'aphront-pager-view-css' => '4c072d06',
'aphront-panel-view-css' => '4c072d06',
'aphront-table-view-css' => '4c072d06',
'aphront-tokenizer-control-css' => '4c072d06',
'aphront-tooltip-css' => '4c072d06',
'aphront-typeahead-control-css' => '4c072d06',
'differential-changeset-view-css' => '09216861',
'differential-core-view-css' => '09216861',
'differential-inline-comment-editor' => 'd07a3bc2',
......@@ -4434,7 +4423,7 @@ celerity_register_resource_map(array(
'differential-table-of-contents-css' => '09216861',
'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88',
'global-drag-and-drop-css' => '4a060444',
'global-drag-and-drop-css' => '4c072d06',
'inline-comment-summary-css' => '09216861',
'javelin-aphlict' => '4f81c788',
'javelin-behavior' => '2dbbb7d1',
......@@ -4507,55 +4496,55 @@ celerity_register_resource_map(array(
'javelin-util' => '2dbbb7d1',
'javelin-vector' => '2dbbb7d1',
'javelin-workflow' => '2dbbb7d1',
'lightbox-attachment-css' => '4a060444',
'lightbox-attachment-css' => '4c072d06',
'maniphest-task-summary-css' => '06bacb9a',
'maniphest-transaction-detail-css' => '06bacb9a',
'phabricator-action-list-view-css' => '4a060444',
'phabricator-application-launch-view-css' => '4a060444',
'phabricator-action-list-view-css' => '4c072d06',
'phabricator-application-launch-view-css' => '4c072d06',
'phabricator-busy' => '4f81c788',
'phabricator-content-source-view-css' => '09216861',
'phabricator-core-css' => '4a060444',
'phabricator-crumbs-view-css' => '4a060444',
'phabricator-core-css' => '4c072d06',
'phabricator-crumbs-view-css' => '4c072d06',
'phabricator-drag-and-drop-file-upload' => 'd07a3bc2',
'phabricator-dropdown-menu' => '4f81c788',
'phabricator-file-upload' => '4f81c788',
'phabricator-filetree-view-css' => '4a060444',
'phabricator-flag-css' => '4a060444',
'phabricator-form-view-css' => '4a060444',
'phabricator-header-view-css' => '4a060444',
'phabricator-filetree-view-css' => '4c072d06',
'phabricator-flag-css' => '4c072d06',
'phabricator-header-view-css' => '4c072d06',
'phabricator-hovercard' => '4f81c788',
'phabricator-jump-nav' => '4a060444',
'phabricator-jump-nav' => '4c072d06',
'phabricator-keyboard-shortcut' => '4f81c788',
'phabricator-keyboard-shortcut-manager' => '4f81c788',
'phabricator-main-menu-view' => '4a060444',
'phabricator-main-menu-view' => '4c072d06',
'phabricator-menu-item' => '4f81c788',
'phabricator-nav-view-css' => '4a060444',
'phabricator-nav-view-css' => '4c072d06',
'phabricator-notification' => '4f81c788',
'phabricator-notification-css' => '4a060444',
'phabricator-notification-menu-css' => '4a060444',
'phabricator-object-item-list-view-css' => '4a060444',
'phabricator-notification-css' => '4c072d06',
'phabricator-notification-menu-css' => '4c072d06',
'phabricator-object-item-list-view-css' => '4c072d06',
'phabricator-object-selector-css' => '09216861',
'phabricator-phtize' => '4f81c788',
'phabricator-prefab' => '4f81c788',
'phabricator-project-tag-css' => '06bacb9a',
'phabricator-property-list-view-css' => '4a060444',
'phabricator-remarkup-css' => '4a060444',
'phabricator-property-list-view-css' => '4c072d06',
'phabricator-remarkup-css' => '4c072d06',
'phabricator-shaped-request' => 'd07a3bc2',
'phabricator-side-menu-view-css' => '4a060444',
'phabricator-standard-page-view' => '4a060444',
'phabricator-tag-view-css' => '4a060444',
'phabricator-side-menu-view-css' => '4c072d06',
'phabricator-standard-page-view' => '4c072d06',
'phabricator-tag-view-css' => '4c072d06',
'phabricator-textareautils' => '4f81c788',
'phabricator-tooltip' => '4f81c788',
'phabricator-transaction-view-css' => '4a060444',
'phabricator-zindex-css' => '4a060444',
'phui-button-css' => '4a060444',
'phui-form-css' => '4a060444',
'phui-icon-view-css' => '4a060444',
'phui-spacing-css' => '4a060444',
'sprite-apps-large-css' => '4a060444',
'sprite-gradient-css' => '4a060444',
'sprite-icons-css' => '4a060444',
'sprite-menu-css' => '4a060444',
'syntax-highlighting-css' => '4a060444',
'phabricator-transaction-view-css' => '4c072d06',
'phabricator-zindex-css' => '4c072d06',
'phui-button-css' => '4c072d06',
'phui-form-css' => '4c072d06',
'phui-form-view-css' => '4c072d06',
'phui-icon-view-css' => '4c072d06',
'phui-spacing-css' => '4c072d06',
'sprite-apps-large-css' => '4c072d06',
'sprite-gradient-css' => '4c072d06',
'sprite-icons-css' => '4c072d06',
'sprite-menu-css' => '4c072d06',
'syntax-highlighting-css' => '4c072d06',
),
));
......@@ -38,7 +38,6 @@ phutil_register_library_map(array(
'AphrontFormFileControl' => 'view/form/control/AphrontFormFileControl.php',
'AphrontFormImageControl' => 'view/form/control/AphrontFormImageControl.php',
'AphrontFormInsetView' => 'view/form/AphrontFormInsetView.php',
'AphrontFormLayoutView' => 'view/form/AphrontFormLayoutView.php',
'AphrontFormMarkupControl' => 'view/form/control/AphrontFormMarkupControl.php',
'AphrontFormPasswordControl' => 'view/form/control/AphrontFormPasswordControl.php',
'AphrontFormPolicyControl' => 'view/form/control/AphrontFormPolicyControl.php',
......@@ -737,8 +736,10 @@ phutil_register_library_map(array(
'PHUIDocumentView' => 'view/phui/PHUIDocumentView.php',
'PHUIFeedStoryExample' => 'applications/uiexample/examples/PHUIFeedStoryExample.php',
'PHUIFeedStoryView' => 'view/phui/PHUIFeedStoryView.php',
'PHUIFormBoxView' => 'view/form/PHUIFormBoxView.php',
'PHUIFormDividerControl' => 'view/form/control/PHUIFormDividerControl.php',
'PHUIFormFreeformDateControl' => 'view/form/control/PHUIFormFreeformDateControl.php',
'PHUIFormLayoutView' => 'view/form/PHUIFormLayoutView.php',
'PHUIFormMultiSubmitControl' => 'view/form/control/PHUIFormMultiSubmitControl.php',
'PHUIFormPageView' => 'view/form/PHUIFormPageView.php',
'PHUIIconExample' => 'applications/uiexample/examples/PHUIIconExample.php',
......@@ -2069,7 +2070,6 @@ phutil_register_library_map(array(
'AphrontFormFileControl' => 'AphrontFormControl',
'AphrontFormImageControl' => 'AphrontFormControl',
'AphrontFormInsetView' => 'AphrontView',
'AphrontFormLayoutView' => 'AphrontView',
'AphrontFormMarkupControl' => 'AphrontFormControl',
'AphrontFormPasswordControl' => 'AphrontFormControl',
'AphrontFormPolicyControl' => 'AphrontFormControl',
......@@ -2774,8 +2774,10 @@ phutil_register_library_map(array(
'PHUIDocumentView' => 'AphrontTagView',
'PHUIFeedStoryExample' => 'PhabricatorUIExample',
'PHUIFeedStoryView' => 'AphrontView',
'PHUIFormBoxView' => 'AphrontView',
'PHUIFormDividerControl' => 'AphrontFormControl',
'PHUIFormFreeformDateControl' => 'AphrontFormControl',
'PHUIFormLayoutView' => 'AphrontView',
'PHUIFormMultiSubmitControl' => 'AphrontFormControl',
'PHUIFormPageView' => 'AphrontView',
'PHUIIconExample' => 'PhabricatorUIExample',
......
......@@ -87,7 +87,6 @@ final class PhabricatorAuditListController extends PhabricatorAuditController {
$form = new AphrontFormView();
$form->setUser($user);
$form->setNoShading(true);
$show_status = false;
$show_user = false;
......
......@@ -49,7 +49,7 @@ final class PhabricatorAuthConfirmLinkController
->addCancelButton($panel_uri)
->addSubmitButton(pht('Confirm Account Link'));
$form = id(new AphrontFormLayoutView())
$form = id(new PHUIFormLayoutView())
->setFullWidth(true)
->appendChild(
phutil_tag(
......
......@@ -116,7 +116,7 @@ EOBODY;
$error_view->setErrors($errors);
}
$email_auth = new AphrontFormLayoutView();
$email_auth = new PHUIFormLayoutView();
$email_auth->appendChild($error_view);
$email_auth
->setUser($request->getUser())
......
......@@ -24,8 +24,6 @@ final class PhabricatorEmailVerificationController
$user->getPHID(),
$this->code);
$color = PhabricatorActionHeaderView::HEADER_DARK_GREY;
if (!$email) {
$title = pht('Unable to Verify Email');
$content = pht(
......@@ -33,7 +31,6 @@ final class PhabricatorEmailVerificationController
'address has been removed, or the email address is owned by another '.
'user. Make sure you followed the link in the email correctly and are '.
'logged in with the user account associated with the email address.');
$color = PhabricatorActionHeaderView::HEADER_RED;
$continue = pht('Rats!');
} else if ($email->getIsVerified()) {
$title = pht('Address Already Verified');
......@@ -56,7 +53,6 @@ final class PhabricatorEmailVerificationController
$dialog = id(new AphrontDialogView())
->setUser($user)
->setTitle($title)
->setHeaderColor($color)
->setMethod('GET')
->addCancelButton('/', $continue)
->appendChild($content);
......
......@@ -202,7 +202,6 @@ final class PhabricatorAuthEditController
$form = id(new AphrontFormView())
->setUser($viewer)
->setFlexible(true)
->appendChild(
id(new AphrontFormStaticControl())
->setLabel(pht('Provider'))
......@@ -270,11 +269,15 @@ final class PhabricatorAuthEditController
->setTransactions($xactions);
}
$form_box = id(new PHUIFormBoxView())
->setHeaderText($title)
->setFormError($errors)
->setForm($form);
return $this->buildApplicationPage(
array(
$crumbs,
$errors,
$form,
$form_box,
$xaction_view,
),
array(
......
......@@ -81,6 +81,10 @@ final class PhabricatorAuthNewController
->addCancelButton($this->getApplicationURI())
->setValue(pht('Continue')));
$form_box = id(new PHUIFormBoxView())
->setHeaderText(pht('Add Authentication Provider'))
->setFormError($errors)
->setForm($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
......@@ -90,8 +94,7 @@ final class PhabricatorAuthNewController
return $this->buildApplicationPage(
array(
$crumbs,
$errors,
$form,
$form_box,
),
array(
'title' => pht('Add Authentication Provider'),
......
......@@ -104,7 +104,7 @@ final class PhabricatorAuthProviderLDAP
$errors[] = pht('Username or password are incorrect.');
}
$form = id(new AphrontFormLayoutView())
$form = id(new PHUIFormLayoutView())
->setUser($viewer)
->setFullWidth(true)
->appendChild(
......
......@@ -115,7 +115,7 @@ final class PhabricatorAuthProviderPassword
$errors = id(new AphrontErrorView())->setErrors($errors);
}
$form = id(new AphrontFormLayoutView())
$form = id(new PHUIFormLayoutView())
->setFullWidth(true)
->appendChild($errors)
->appendChild(
......
......@@ -126,14 +126,13 @@ final class PhabricatorCalendarEditStatusController
$dialog->setSubmitURI(
$this->getApplicationURI('status/edit/'.$status->getID().'/'));
}
$form = new AphrontFormLayoutView();
$form = new PHUIFormLayoutView();
if ($error_view) {
$form->appendChild($error_view);
}
} else {
$form = id(new AphrontFormView())
->setUser($user)
->setFlexible(true);
->setUser($user);
}
$form
......@@ -164,14 +163,17 @@ final class PhabricatorCalendarEditStatusController
}
$form->appendChild($submit);
$form_box = id(new PHUIFormBoxView())
->setHeaderText($page_title)
->setFormError($error_view)
->setForm($form);
$nav = $this->buildSideNavView($status);
$nav->selectFilter($filter);
$nav->appendChild(
array(
id(new PhabricatorHeaderView())->setHeader($page_title),
$error_view,
$form,
$form_box,
));
return $this->buildApplicationPage(
......
......@@ -150,7 +150,6 @@ final class PhabricatorChatLogChannelLogController
->setUser($user)
->setMethod('GET')
->setAction($uri)
->setNoShading(true)
->appendChild(
id(new AphrontFormTextControl())
->setLabel(pht('Date'))
......
......@@ -69,7 +69,6 @@ final class PhabricatorConduitConsoleController
->setUser($request->getUser())
->setAction('/api/'.$this->method)
->addHiddenInput('allowEmptyParams', 1)
->setFlexible(true)
->appendChild(
id(new AphrontFormStaticControl())
->setLabel('Description')
......
......@@ -98,7 +98,6 @@ final class PhabricatorConfigEditController
}
$form = new AphrontFormView();
$form->setFlexible(true);
$error_view = null;
if ($errors) {
......@@ -194,6 +193,11 @@ final class PhabricatorConfigEditController
$title = pht('Edit %s', $this->key);
$short = pht('Edit');
$form_box = id(new PHUIFormBoxView())
->setHeaderText($title)
->setFormError($error_view)
->setForm($form);
$crumbs = $this->buildApplicationCrumbs();
$crumbs->addCrumb(
id(new PhabricatorCrumbView())
......@@ -212,7 +216,6 @@ final class PhabricatorConfigEditController