1. 29 Mar, 2020 1 commit
  2. 22 May, 2019 1 commit
    • epriestley's avatar
      Add a "Reports" menu item to Projects · 0aee3da1
      epriestley authored
      Summary:
      Ref T13279. Since the use cases that have made it upstream are all for relatively complex charts (e.g., requiring aggregation and composition of multiple data series in nontrivial ways) I'm currently looking at an overall approach like this:
      
        - At least for now, Charts provides a low-level internal-only API for composing charts from raw datasets.
        - This is exposed to users through pre-built `SearchEngine`-like interfaces that provide a small number of more manageable controls (show chart from date X to date Y, show projects A, B, C), but not the full set of composition features (`compose(scale(2), cos())` and such).
        - Eventually, we may put more UI on the raw chart composition stuff and let you build your own fully custom charts by gluing together datasets and functions.
        - Or we may add this stuff in piecemeal to the higher-level UI as tools like "add goal line" or "add trend line" or whatever.
      
      This will let the low-level API mature/evolve a bit before users get hold of it directly, if they ever do. Most requests today are likely satisfiable with a small number of chart engines plus raw API data access, so maybe UI access to flexible charting is far away.
      
      Step toward this by adding a "Reports" section to projects. For now, this just renders a basic burnup for the current project. Followups will add an "Engine" layer above this and make the chart it produces more useful.
      
      Test Plan: {F6426984}
      
      Reviewers: amckinley
      
      Reviewed By: amckinley
      
      Maniphest Tasks: T13279
      
      Differential Revision: https://secure.phabricator.com/D20495
      0aee3da1
  3. 02 Apr, 2019 1 commit
    • epriestley's avatar
      Allow profile menu items to be locked to the top or bottom of the menu · 47bf3824
      epriestley authored
      Summary:
      Depends on D20353. Ref T13275. This is just some small quality-of-life fixes:
      
        - When you add items to menus, they currently go below the "Edit Menu/Manage Menu" links by default. This isn't a very good place for them. Instead, lock "edit" items to the bottom of the menu.
        - Lock profile pictures to the top of the menu. This just simplifies things a little.
        - Show more iconography hints on the "edit menu items" UI.
        - Add a "drag stuff to do things" hint if some stuff can be dragged.
      
      Test Plan:
        - Added new items to a Portal, they didn't go to the very bottom. Instead, they went above the "Edit/Manage" links; a sensible place for them.
        - Viewed the "edit menu items" screen, saw more hints and visual richness.
        - Viewed/edited Home, Projects, Portals, Favorites
      
      Reviewers: amckinley
      
      Reviewed By: amckinley
      
      Maniphest Tasks: T13275
      
      Differential Revision: https://secure.phabricator.com/D20355
      47bf3824
  4. 11 May, 2017 1 commit
    • Chad Little's avatar
      Add a large profile picture to Projects · e1a97616
      Chad Little authored
      Summary: The ports over a similar "profile image" menu item to Projects. It gives us some room to use the project icon in the sidenav along with a larger photo. It also will open up some room in the sub-page headers for us to focus on that page, and not the identity of the project at hand. Expect a few more project related touch up diffs.
      
      Test Plan:
      Review new projects menu on a few projects, update the image, see new image. Great for team photos.
      
      {F4951264}
      
      Reviewers: epriestley, amckinley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin
      
      Differential Revision: https://secure.phabricator.com/D17869
      e1a97616
  5. 27 Jan, 2017 1 commit
    • epriestley's avatar
      (stable) Allow menu items to render their own content; make Dashboard items render on-page · 2dc46920
      epriestley authored
      Summary:
      Ref T11957. When you click a dashboard item, it now sends you to `/<app>/item/view/123/`, which renders the proper crumbs, navigation, etc., with the dashboard as page content.
      
      This works as you'd expect in Projects:
      
      {F2508568}
      
      It's sliiiightly odd in Favorites since we nuke the nav menu, but seems basically fine?
      
      {F2508571}
      
      Test Plan:
        - Created a dashboard panel on a project.
        - Clicked it, saw it render.
        - Made it the default panel, viewed project default screen, saw dashboard.
        - Disabled every panel I could, still saw reasonable behavior (this is silly anyway).
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T11957
      
      Differential Revision: https://secure.phabricator.com/D17255
      2dc46920
  6. 26 Jan, 2017 1 commit
    • epriestley's avatar
      Allow menu items to render their own content; make Dashboard items render on-page · 5960b1c8
      epriestley authored
      Summary:
      Ref T11957. When you click a dashboard item, it now sends you to `/<app>/item/view/123/`, which renders the proper crumbs, navigation, etc., with the dashboard as page content.
      
      This works as you'd expect in Projects:
      
      {F2508568}
      
      It's sliiiightly odd in Favorites since we nuke the nav menu, but seems basically fine?
      
      {F2508571}
      
      Test Plan:
        - Created a dashboard panel on a project.
        - Clicked it, saw it render.
        - Made it the default panel, viewed project default screen, saw dashboard.
        - Disabled every panel I could, still saw reasonable behavior (this is silly anyway).
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T11957
      
      Differential Revision: https://secure.phabricator.com/D17255
      5960b1c8
  7. 31 Jan, 2017 2 commits
    • epriestley's avatar
      Put Project "Manage" item back · 2a527a51
      epriestley authored
      Summary:
      Ref T12174. This isn't really a "newManageItem()" since Projects have a separate manage screen.
      
      That is, I incorrectly changed the "Manage [This Project]" item into a "Edit Menu" item, so some options (like "Archive Project") incorrectly became inaccessible.
      
      Test Plan: Viewed a project, saw the right menu item, clicked it, could archive/etc project. Also edited the menu.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T12174
      
      Differential Revision: https://secure.phabricator.com/D17275
      2a527a51
    • epriestley's avatar
      Replace ProfileMenu bugs with different bugs · f23bfccc
      epriestley authored
      Summary:
      Ref T12174. This fixes more bugs than it creates, I think:
      
        - Dashboards now show the whole menu.
        - Project and home items now show selected state correctly.
        - The "choose global vs personal" thing is now part of MenuEngine, and the same code builds it for Home and Favorites.
        - Home now handles defaults correctly, I think.
      
      Maybe regression/bad/still buggy?:
      
        - Mobile home is now whatever the default thing was, not the menu?
        - Title for dashboard content or other items that render their own content is incorrectly always "Configure Menu" (this was preexisting).
      
      Test Plan:
        - Created, edited, reordered, disabled, deleted and pinned personal and global items on home, favorites, and projects.
        - Also checked User profiles.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T12174
      
      Differential Revision: https://secure.phabricator.com/D17273
      f23bfccc
  8. 11 Dec, 2016 3 commits
    • epriestley's avatar
      Rename all ProfilePanels into ProfileMenuItems · 42896f9f
      epriestley authored
      Summary: Ref T11957.
      
      Test Plan:
        - Viewed an existing project profile.
        - Viewed a user profile.
        - Created a new project.
        - Edited a profile menu.
        - Added new profile items.
        - Grepped for renamed symbols.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T11957
      
      Differential Revision: https://secure.phabricator.com/D17028
      42896f9f
    • epriestley's avatar
      Rename "ProfilePanelConfiguration" to "ProfileMenuItemConfiguration" · 8480776c
      epriestley authored
      Summary:
      Ref T11957. This renames the Configuration storage, transaction, query, and PHID type.
      
      No rename on the actual menu item types yet, that's next (and should be the end of this, I think).
      
      Test Plan:
        - Viewed projects.
        - Viewed profiles.
        - Edited a project menu.
        - Grepped for all renamed symbols, I think?
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T11957
      
      Differential Revision: https://secure.phabricator.com/D17027
      8480776c
    • epriestley's avatar
      Rename "PanelEngine" to "MenuEngine" · 923d3d30
      epriestley authored
      Summary: Ref T11957.
      
      Test Plan:
      Grepped for "PanelEngine", renamed everything except "PanelEditEngine".
      
      Grepped for these changed symbols:
      
      ```
      ispanelengineconfigurable
      getprofilepanelengine
      setprofilepanelengine
      setpanelengine
      getpanelengine
      PhabricatorProfilePanelEditEngine
      ```
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T11957
      
      Differential Revision: https://secure.phabricator.com/D17025
      923d3d30
  9. 09 Feb, 2016 1 commit
  10. 01 Feb, 2016 1 commit
  11. 26 Jan, 2016 1 commit
    • epriestley's avatar
      Make project menus unconditionally configurable · 49a44a0b
      epriestley authored
      Summary: Fixes T10213. I think the "Edit" item was originally conditional (or maybe I just forgot to add that part), but that got dropped when we swapped how it worked. This is all stable now anyway and can be available without needing prototypes enabled.
      
      Test Plan: Edited a project menu.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T10213
      
      Differential Revision: https://secure.phabricator.com/D15117
      49a44a0b
  12. 24 Jan, 2016 1 commit
    • Chad Little's avatar
      First cut of new Project Home · b381265d
      Chad Little authored
      Summary:
      First pass at a new Project Home page. This is starting to sprawl, so punting this up now before it gets too large.
      
       - Project homes now have "large header"
       - Custom Fields / Descriptions are in the main column
       - Feed is simpler visually
       - new "Background" option for PHUIObjectBoxView
       - move header buttons globally to "Grey" instead of "Simple"
       - New color and hover states for "Grey"
       - Transitions on Buttons haha
       - Edit Icon on Nav is now under "Manage" panel
       - New "Manage" Panel
      
      TODO:
       - More testing of bad cases of Custom Fields
       - Members Page in flux, needs design
       - Um still not sure how to make Custom Field not show UI
      
      Test Plan:
      Lots of random Project page visits. Save project, watch project, edit project, etc.
      
      {F1068191}
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin
      
      Differential Revision: https://secure.phabricator.com/D15097
      b381265d
  13. 22 Jan, 2016 1 commit
  14. 20 Jan, 2016 1 commit
    • epriestley's avatar
      Put feed on project home, move history to a separate page · 9f365941
      epriestley authored
      Summary:
      Ref T10054. This shuffles some stuff around to move us closer to mocks in M1450 in terms of what information is on which pages.
      
      Home now has feed, members, watchers, link to "edit project / project edit history".
      
      History now has edit history, edit details, edit picture, archive/unarchive.
      
      Test Plan:
      New home page:
      
      {F1064889}
      
      New edit/history page:
      
      {F1064890}
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T10054
      
      Differential Revision: https://secure.phabricator.com/D15060
      9f365941
  15. 15 Jan, 2016 1 commit
    • epriestley's avatar
      Prepare Profile Panels for adoption in other applications · 2a6b2dbb
      epriestley authored
      Summary: Ref T10054. Take specialization off the objects and put it on Engine subclasses instead. One reason for this is that certain objects (like users) might have multiple different sets of panels in the future (e.g., their user profile and their home page).
      
      Test Plan:
        - No user-visible changes.
        - PanelEngine no longer has any hardcoded "project" stuff.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T10054
      
      Differential Revision: https://secure.phabricator.com/D15018
      2a6b2dbb