1. 03 Sep, 2015 1 commit
  2. 22 Jul, 2015 1 commit
  3. 25 Jun, 2015 1 commit
  4. 13 Jun, 2015 1 commit
    • Chad Little's avatar
      [Redesign] Move basefont to Lato, remove Source Sans Pro · 9170e901
      Chad Little authored
      Summary: Working towards a more unified look and feel. This brings in Lato as a complete base font over Helvetica Neue, as well as removing Source Sans Pro from DocumentView and Conpherence. Design-wise Lato provides the nice readability at larger font sizes that Source Sans Pro did, with the ability to scale down to tables and UI widgets with ease. This gives us one font instead of two, and now Object descriptions and Timeline posts all can benefit from a consistent, readable font.
      
      Test Plan:
      Test main UI, smaller elements like tables, menus, DocumentViews, Previews, Conpherence.
      
      {F498135}
      
      {F498136}
      
      Reviewers: btrahan, epriestley
      
      Reviewed By: epriestley
      
      Subscribers: epriestley, Korvin
      
      Differential Revision: https://secure.phabricator.com/D13276
      9170e901
  5. 22 May, 2015 1 commit
  6. 01 Mar, 2015 1 commit
    • Chad Little's avatar
      Move PHUIErrorView to PHUIInfoView · c038c643
      Chad Little authored
      Summary: Since this element isn't strictly about errors, re-label as info view instead.
      
      Test Plan: Grepped for all callsites, tested UIExamples and a few other random pages.
      
      Reviewers: btrahan, epriestley
      
      Reviewed By: epriestley
      
      Subscribers: hach-que, Korvin, epriestley
      
      Differential Revision: https://secure.phabricator.com/D11867
      c038c643
  7. 20 Feb, 2015 1 commit
    • Bob Trahan's avatar
      Phriction - clarify error message when trying to delete already deleted content · 0a0ac114
      Bob Trahan authored
      Summary: Fixes T7325, T7326, T7328. When you have deleted a document already you have to specify content; this makes this more clear to the user in this specific delete pathway. Also, includes bonus bug fix for T7326 where we weren't moving the title of the wiki page with the rest of the page.
      
      Test Plan: moved a wiki doc and verified it had the title I had specified. tried to delete an already deleted doc via setting the content to blank (i.e. hitting save after making some other edits) and got more clear error UI state
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T7328, T7325, T7326
      
      Differential Revision: https://secure.phabricator.com/D11829
      0a0ac114
  8. 02 Feb, 2015 1 commit
    • Chad Little's avatar
      PHUIErrorView · 3da38c74
      Chad Little authored
      Summary: Clean up the error view styling.
      
      Test Plan:
      Tested as many as I could find, built additional tests in UIExamples
      
      {F280452}
      
      {F280453}
      
      Reviewers: btrahan, epriestley
      
      Reviewed By: epriestley
      
      Subscribers: hach-que, Korvin, epriestley
      
      Differential Revision: https://secure.phabricator.com/D11605
      3da38c74
  9. 11 Nov, 2014 1 commit
  10. 07 Nov, 2014 1 commit
    • Bob Trahan's avatar
      Phriction - policy front end changes · c8d20d3c
      Bob Trahan authored
      Summary:
      Ref T4029. Fixes T6034.
      
      Various front-end miscellania here. See D10814#96251. This more or less makes policy work but I am not going to call it "fixed" here since we need D10814 to be deployed too and will do that manually.
      
      Test Plan:
      - changed document policy from web ui and changes persisted
      - changed document policy from web and had form error and changes persisted
      - created a structure like users/users/justmyuserpolicy and made sure another user could delete the users/users/ doc
      - moved a doc from a to b and verified policy persisted
      - verified stub documents inherited policy of the document that stub them...!
      - uploaded a file and verified that it 1) had the permissions of the page it was added to and 2) had an "attached" tab linking back to the page on the file page (this means T6034 is fixed with this)
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T6034, T4029
      
      Differential Revision: https://secure.phabricator.com/D10816
      c8d20d3c
  11. 06 Nov, 2014 1 commit
    • Bob Trahan's avatar
      Phriction - consolidate edit business logic into Editor · 37bc0474
      Bob Trahan authored
      Summary:
      Ref T4029. Some business logic lives outside the editor. This revision moves that logic from the edit controller into the editor proper. This makes re-using that business logic across other endpoints - say like a conduit end point - possible. This is also part of the general modernization quest for phriction I am on.
      
      This diff also restores the functionality where you can delete a document by wiping out the content and saving.
      
      Test Plan: tried to make a document with no title or content and saw errors. opened a document for edit with user 1, then made edits with user 2, then saw an error when i made the edit with user 1. clicking "overwrite changes" then worked.  deleted a document by wiping out the body and clicking save.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T4029
      
      Differential Revision: https://secure.phabricator.com/D10795
      37bc0474
  12. 30 Oct, 2014 1 commit
    • Bob Trahan's avatar
      Phriction - start the move towards transactions and an editor · a9fc343d
      Bob Trahan authored
      Summary:
      This implements as little as possible to stick a working transactions + editor codepath in the basic create / edit flow. Aside from the transaction tables, this also required adding a mailKey to a phrictionDocument.
      
      Future work would include adding more transactions types for things like "move" and all the pertinent support. Even future work is to add things like policies which will work easily in the transaction framework. Ref T4029.
      
      Test Plan:
       - made a wiki doc
       - edit a wiki doc
       - had someone subscribe to a wiki doc and edited it
      
      For all three, the edits worked, a reasonable email was sent out, and feed stories were generated.
      
       - made a wiki doc at a /location/like/this
      
      document "stubs" were made as expected in /location and /location/like
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: chad, Korvin, epriestley
      
      Maniphest Tasks: T4029
      
      Differential Revision: https://secure.phabricator.com/D10756
      a9fc343d
  13. 07 Oct, 2014 1 commit
  14. 23 Jun, 2014 1 commit
  15. 21 May, 2014 1 commit
    • epriestley's avatar
      Don't warn about conflicts when reverting Phriction documents · 3c8d88de
      epriestley authored
      Summary:
      Fixes T5144. This was incorrectly checking the //content// version, not the //head// version, so reverts would raise the "conflict" warning.
      
      Also fix a couple of FontAwesome icons.
      
      Test Plan:
        - Edited a document.
        - Reverted a document.
        - Opened two edit tabs. Edited one, tried to edit #2, got a warning.
        - Opened two revert tabs. Reverted in one, tried to revert in #2, got a warning.
      
      Reviewers: btrahan, chad
      
      Reviewed By: chad
      
      Subscribers: epriestley
      
      Maniphest Tasks: T5144
      
      Differential Revision: https://secure.phabricator.com/D9249
      3c8d88de
  16. 19 May, 2014 2 commits
    • epriestley's avatar
      Use PhrictionDocumentQuery to load documents · 4d7c1026
      epriestley authored
      Summary: Ref T4029. We use a lot of very outdated content loading in Phriction, which blocks T4029.
      
      Test Plan:
      - Called phriction.info
      - Called phriction.history
      - Called phriction.edit
      - Viewed document list.
      - Deleted a document.
      - Viewed history.
      - Viewed a diff.
      - Created a document.
      - Edited a document.
      - Moved a document.
      - Tried to overwrite a document with "new".
      - Tried to overwrite a document with "move".
      - Viewed a moved document note.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: shadowhand, epriestley
      
      Maniphest Tasks: T4029
      
      Differential Revision: https://secure.phabricator.com/D9194
      4d7c1026
    • epriestley's avatar
      Add very basic conflict detection to Phriction · b1ec4a9a
      epriestley authored
      Summary: Ref T4768. This is extremely basic, but will stop conflicts from going silently unnoticed.
      
      Test Plan: {F156219}
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T4768
      
      Differential Revision: https://secure.phabricator.com/D9167
      b1ec4a9a
  17. 10 Jan, 2014 1 commit
  18. 19 Dec, 2013 1 commit
    • epriestley's avatar
      Provide convenience method addTextCrumb() to PhabricatorCrumbsView · a5dc9067
      epriestley authored
      Summary: We currently have a lot of calls to `addCrumb(id(new PhabricatorCrumbView())->...)` which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.
      
      Test Plan:
        - This was mostly automated, then I cleaned up a few unusual sites manually.
        - Bunch of grep / randomly clicking around.
      
      Reviewers: btrahan, chad
      
      Reviewed By: btrahan
      
      CC: hach-que, aran
      
      Differential Revision: https://secure.phabricator.com/D7787
      a5dc9067
  19. 07 Nov, 2013 1 commit
    • Bob Trahan's avatar
      Phriction - make the check for project sub pages more fine-grained · 9084f1fe
      Bob Trahan authored
      Summary:
      we were just checking if projects/ was in the URI before barfing. Use some more fun utility functions such that we only complain if there is no project.
      
      Fixes T4071.
      
      Test Plan: made a subpage under a project - success! tried to make a project wiki page where there was no project - successful failure! tried to make a project wiki sub page where there was no project - successful failure!
      
      Reviewers: epriestley, chad
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Maniphest Tasks: T4071
      
      Differential Revision: https://secure.phabricator.com/D7527
      9084f1fe
  20. 25 Sep, 2013 1 commit
    • Chad Little's avatar
      Move PHUIFormBoxView to PHUIObjectBoxView · 9be7a948
      Chad Little authored
      Summary: I'd like to reuse this for other content areas, renaming for now. This might be weird to keep setForm, but I can fix that later if we need.
      
      Test Plan: reload a few forms in maniphest, projects, differential
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: Korvin, aran
      
      Differential Revision: https://secure.phabricator.com/D7120
      9be7a948
  21. 26 Aug, 2013 1 commit
    • Chad Little's avatar
      Update Form Layouts · fe2a96e3
      Chad Little authored
      Summary:
      This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere.
      
      TODO: will take another pass as consolidating these colors and new gradients in another diff.
      
      Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: Korvin, aran
      
      Differential Revision: https://secure.phabricator.com/D6806
      fe2a96e3
  22. 20 Aug, 2013 1 commit
  23. 05 Aug, 2013 1 commit
  24. 28 Jul, 2013 1 commit
  25. 02 Jun, 2013 1 commit
  26. 07 May, 2013 1 commit
    • Chad Little's avatar
      Update form styles, implement in many places · 43ff24b0
      Chad Little authored
      Summary:
      This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things:
      
      - Font Styles are correctly applied for form elements now.
      - Everything lines up!
      - Selects are larger, easier to read, interact.
      - Inputs have been squared.
      - Consistant CSS applied glow (try it!)
      - Improved Mobile Responsiveness
      - CSS applied to all form elements, not just Aphront
      - Many other minor tweaks.
      
      I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try.
      
      Test Plan: Tested many applications, forms, mobile and tablet.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D5860
      43ff24b0
  27. 11 Apr, 2013 1 commit
    • Chad Little's avatar
      Phriction Redesign · 7b9b872b
      Chad Little authored
      Summary: This is mostly minor, but visually it makes the wiki feel more 'page like' and better separates the actual content from other data displayed.
      
      Test Plan: Tested Chrome, iPhone, and iPad.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin, AnhNhan
      
      Maniphest Tasks: T2686
      
      Differential Revision: https://secure.phabricator.com/D5366
      7b9b872b
  28. 13 Feb, 2013 2 commits
  29. 12 Feb, 2013 1 commit
    • vrana's avatar
      Fix some HTML problems · 868ca714
      vrana authored
      Summary: I'm too lazy to attaching them for diffs where they were introduced.
      
      Test Plan:
      /
      /D1, wrote comment with code snippet
      DarkConsole
      commit detail, wrote comment
      task detail, wrote comment
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T2432
      
      Differential Revision: https://secure.phabricator.com/D4911
      868ca714
  30. 09 Feb, 2013 2 commits
  31. 08 Feb, 2013 3 commits
  32. 25 Jan, 2013 2 commits
    • Vedha Sayyaparaju's avatar
      T2385: Add "Delete Document" action to Phriction pages · cf346d3c
      Vedha Sayyaparaju authored
      Summary: If a page has not been deleted, this adds an action button to delete the document in the menu on the Phriction Page.
      
      Test Plan:
      1. Created a document, checked whether "Delete Document" button was visible.
      2. Clicked on "Delete Document" button, checked that the document had been deleted.
      3. Went back to document page, checked that the "Delete Document" button no longer existed.
      
      Reviewers: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T2385
      
      Differential Revision: https://secure.phabricator.com/D4636
      cf346d3c
    • vrana's avatar
      Convert phutil_render_tag(X, Y, '...') to phutil_tag · 20768d65
      vrana authored
      Summary:
      Created with spatch:
      
        lang=diff
        - phutil_render_tag
        + phutil_tag
          (X, Y, '...')
      
      Then searched for `&` and `<` in the output and replaced them.
      
      Test Plan: Loaded homepage.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D4503
      20768d65
  33. 27 Nov, 2012 1 commit
  34. 15 Nov, 2012 1 commit
    • Ricky Elrod's avatar
      Don't show the delete button on a deleted document · 7fac80cb
      Ricky Elrod authored
      Summary:
      This doesn't actually contain any logic to prevent a user from deleting a
      document twice, but it makes it significantly harder to do so.
      
      Test Plan:
      Went to edit a document, saw the delete button. Clicked it, then went back to
      the edit view, and no longer saw the delete button.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D3952
      7fac80cb