1. 29 Mar, 2020 1 commit
    • Daniel Stone's avatar
      WIP: Maniphest: Hide hidden project tags for tasks · 287324d0
      Daniel Stone authored
      If the viewer doesn't have permission to see something a task has been
      tagged with, then don't show it to them in the Maniphest task list view,
      the task detail view, or the workboard view.
      This should be extended further to also eliminate it from the
      transaction history (in the task detail view) and also from
      notifications, but it's a start.
      This would need quite a bit more work to go upstream.
  2. 12 Mar, 2019 1 commit
    • epriestley's avatar
      Remove the ability to drag tasks up and down on (non-Workboard) priority list views · 00543f06
      epriestley authored
      Ref T13074. Today, in normal task list views in Maniphest (not workboards), you can (sometimes) reorder tasks if the view is priority-sorted.
      I suspect no one ever does this, few users know it's supported, and that it was basically rendered obsolete the day we shipped workboards.
      This also means that we need to maintain a global "subpriority" for tasks, which distinguishes between different tasks at the same priority level (e.g., "High") and maintains a consistent ordering on workboards.
      As we move toward making workboards more flexible (e.g., group by author / owner / custom fields), I'd like to try moving away from "subpriority" and possibly removing it entirely, in favor of "natural order", which basically means "we kind of remember where you put the card and it works a bit like a sticky note".
      Currently, the "natural order" and "subpriority" systems are sort of similar but also sort of in conflict, and the "subpriority" system can't really be extended while the "natural order / column position" system can.
      The only real reason to have a global "subpriority" is to support the list-view drag-and-drop.
      It's possible I'm wrong about this and a bunch of users love this feature, but we can re-evaluate if we get feedback in this vein.
      (This just removes UI, the actual subpriority system is still intact and still used on workboards.)
      Test Plan: Viewed task lists, was no longer able to drag stuff. Grepped for affected symbols. Dragged stuff in remaining grippable lists, like "Edit Forms" in EditEngine config.
      Reviewers: amckinley
      Reviewed By: amckinley
      Maniphest Tasks: T13074
      Differential Revision: https://secure.phabricator.com/D20263
  3. 14 Feb, 2019 1 commit
  4. 10 Dec, 2018 1 commit
    • epriestley's avatar
      Replace the informal "array" subtype map with a more formal "SubtypeMap" object · f0eefdd0
      epriestley authored
      Summary: Ref T13222. Ref T12588. See PHI683. To make "Create Subtask..." fancier, we need slightly more logic around subtype maps. Upgrade the plain old array into a proper object so it can have relevant methods, notably "get a list of valid child subtypes for some parent subtype".
      Test Plan: Created and edited tasks, changed task subtypes. Grepped for affected symbols (`newEditEngineSubtypeMap`, `newSubtypeMap`).
      Reviewers: amckinley
      Reviewed By: amckinley
      Maniphest Tasks: T13222, T12588
      Differential Revision: https://secure.phabricator.com/D19852
  5. 08 Feb, 2018 1 commit
  6. 26 May, 2017 1 commit
    • epriestley's avatar
      Provide UI hints about task subtypes · 742c3a83
      epriestley authored
      Ref T12314. Open to counterdiffs / iterating / suggestions / skipping most or all of this, mostly just throwing this out there as a maybe-reasonable first pass.
      When a task has a subtype (like "Plant" or "Animal"), provide some hints on the task list, workboards, and task detail.
      To make these hints more useful, allow subtypes to have icons and colors.
      Also use these icons and colors in the typeahead tokens.
      The current rule is that we show the subtype if it's not the default subtype. Another rule we could use is "show the subtype if there's more than one subtype defined", but my guess is that most installs will mostly have something like "normal task" as the default subtype.
      Test Plan:
      The interfaces this affects are: task detail view, task list view, workboard cards, subtype typeahead.
      Reviewers: chad
      Reviewed By: chad
      Subscribers: johnny-bit, bbrdaric, benwick, fooishbar
      Maniphest Tasks: T12314
      Differential Revision: https://secure.phabricator.com/D17451
  7. 03 Aug, 2016 1 commit
  8. 09 Dec, 2015 1 commit
  9. 08 Dec, 2015 1 commit
    • epriestley's avatar
      Move inline edit from task lists to EditEngine · 21be67e8
      epriestley authored
      Summary: Ref T9908. Fixes T8903. This moves the inline edit from task lists (but not from workboards) over to editengine.
      Test Plan:
        - Edited a task from a draggable list.
        - Edited a task from an undraggable list.
        - Edited a task, changed projects, saw refresh show correct projects.
      Reviewers: chad
      Reviewed By: chad
      Maniphest Tasks: T8903, T9908
      Differential Revision: https://secure.phabricator.com/D14711
  10. 30 Jun, 2015 1 commit
    • Chad Little's avatar
      [Redesign] Use status icons in Maniphest task list · f2f168cc
      Chad Little authored
      Summary: Ref T8099, Fixes T8339. This lets us pull in the status icon and display in lists and object headers.
      Test Plan: Look at a list of open and closed tasks, see icons match state (duplicate, spite, defaults).
      Reviewers: epriestley, btrahan
      Reviewed By: btrahan
      Subscribers: epriestley, Korvin
      Maniphest Tasks: T8099, T8339
      Differential Revision: https://secure.phabricator.com/D13490
  11. 21 Jun, 2015 1 commit
  12. 10 Jun, 2015 1 commit
    • epriestley's avatar
      Support Spaces in Maniphest · d118800d
      epriestley authored
      Ref T8493. Tricks:
        - "Create Similar Task" and "Create Subtask" should copy the parent's Space.
        - Normal list view + workboard card view.
      Test Plan:
        - Created a task, edited space, etc.
        - Viewed tasks with different users.
        - Created a "Similar Task" (saw proper Space).
        - Created a subtask (saw proper Space).
        - Viewed workboard.
      Reviewers: btrahan
      Reviewed By: btrahan
      Subscribers: epriestley
      Maniphest Tasks: T8493
      Differential Revision: https://secure.phabricator.com/D13232
  13. 15 May, 2015 1 commit
    • Chad Little's avatar
      [Redesign] New PHUIObjectItemListView · 46f6c268
      Chad Little authored
      New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:
       - Remove FootIcons
       - Remove Stackable
       - Remove Plain List
       - Add StatusIcon
       - Add setting ObjectList to an ObjectBox
       - Minor retouches to Headers
      Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.
      Test Plan: Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.
      Reviewers: btrahan, epriestley
      Reviewed By: epriestley
      Subscribers: Korvin, epriestley
      Differential Revision: https://secure.phabricator.com/D12865
  14. 12 Jan, 2015 1 commit
  15. 16 Aug, 2014 1 commit
    • epriestley's avatar
      Don't render a grip on tasks returned over AJAX to non-draggable UIs · 98a847a3
      epriestley authored
      Fixes T5140. When you ajax-edit a task and we send back a full-size card, we currently always put a drag grip on it.
      If you clicked the "edit" thing from a priority-ordered list, this is appropriate. However, if you clicked it from some other type of list, it is not.
      Pass the expected grippableness through the call.
      Test Plan:
        - Edited a task from a reorderable (priority-ordered) view, got grip.
        - Edited a task from a nonreorderable (author-ordered) view, got no grip.
      Reviewers: btrahan, chad
      Reviewed By: chad
      Subscribers: epriestley
      Maniphest Tasks: T5140
      Differential Revision: https://secure.phabricator.com/D10282
  16. 09 Jul, 2014 1 commit
    • Joshua Spence's avatar
      Remove `@group` annotations · 8756d82c
      Joshua Spence authored
      Summary: I'm pretty sure that `@group` annotations are useless now... see D9855. Also fixed various other minor issues.
      Test Plan: Eye-ball it.
      Reviewers: #blessed_reviewers, epriestley, chad
      Reviewed By: #blessed_reviewers, epriestley
      Subscribers: epriestley, Korvin, hach-que
      Differential Revision: https://secure.phabricator.com/D9859
  17. 26 Jun, 2014 2 commits
  18. 07 Jun, 2014 1 commit
    • Chad Little's avatar
      Make ObjectItem default as "Card" · 41ef6824
      Chad Little authored
      Summary: This went smoother than expeced. Makes the rounded Card the default, also tweaked selected state a little.
      Test Plan:
      Test UIExamples, Maniphest, Home, Differential, Harbormaster, Audit. Everything seems normal
      Reviewers: epriestley
      Reviewed By: epriestley
      Subscribers: epriestley, Korvin
      Differential Revision: https://secure.phabricator.com/D9408
  19. 12 May, 2014 1 commit
    • Chad Little's avatar
      Replace Sprite-Icons with FontAwesome · b2f3001e
      Chad Little authored
      Summary: The removes the sprite sheet 'icons' and replaces it with FontAwesome fonts.
      Test Plan:
      - Grep for SPRITE_ICONS and replace
      - Grep for sprite-icons and replace
      - Grep for PhabricatorActionList and choose all new icons
      - Grep for Crumbs and fix icons
      - Test/Replace PHUIList Icon support
      - Test/Replace ObjectList Icon support (foot, epoch, etc)
      - Browse as many pages as I could get to
      - Remove sprite-icons and move remarkup to own sheet
      - Review this diff in Differential
      Reviewers: btrahan, epriestley
      Reviewed By: epriestley
      Subscribers: epriestley, Korvin, hach-que
      Differential Revision: https://secure.phabricator.com/D9052
  20. 25 Mar, 2014 1 commit
    • epriestley's avatar
      Despecialize most task status handling · 33bda2d5
      epriestley authored
      Summary: Ref T1812. Moves most specialized status handling into `ManiphestTaskStatus`. The only real missing case is reports.
      Test Plan:
      Browsed most of the affected interfaces. Changed task status:
      Reviewers: btrahan
      Reviewed By: btrahan
      Subscribers: epriestley
      Maniphest Tasks: T1812
      Differential Revision: https://secure.phabricator.com/D8579
  21. 05 Dec, 2013 1 commit
  22. 13 Nov, 2013 1 commit
    • epriestley's avatar
      Fix handle loads in ManiphestTaskListView · 626b3dab
      epriestley authored
      Fixes T4095. Fixes T3817.
        - The batch editor has some funky handle code which misses projects, share that.
        - Remove some hacks for T3817 that should be good now.
      Test Plan: Looked at batch editor, saw projects. Looked at task list.
      Reviewers: btrahan
      Reviewed By: btrahan
      CC: aran, martin.schulz
      Maniphest Tasks: T3817, T4095
      Differential Revision: https://secure.phabricator.com/D7578
  23. 13 Sep, 2013 1 commit
  24. 11 Sep, 2013 1 commit
  25. 09 Sep, 2013 1 commit
  26. 20 Jun, 2013 1 commit
  27. 05 Jun, 2013 1 commit
    • Chad Little's avatar
      PHUIList, PHUIDocument updates · f1bf2795
      Chad Little authored
      This diff covers a bit of ground.
      - PHUIDocumentExample has been added
      - PHUIDocument has been extended with new features
      - PhabricatorMenuView is now PHUIListView
      - PhabricatorMenuItemView is now PHUIItemListView
      Overall - I think I've gotten all the edges covered here. There is some derpi-ness that we can talk about, comments in the code. Responsive design is missing from the new features on PHUIDocument, will follow up later.
      Test Plan: Tested mobile and desktop menus, old phriction layout, new document views, new lists, and object lists.
      Reviewers: epriestley, btrahan
      Reviewed By: epriestley
      CC: aran, Korvin
      Differential Revision: https://secure.phabricator.com/D6130
  28. 04 Jun, 2013 1 commit
  29. 31 May, 2013 1 commit
    • epriestley's avatar
      Allow Maniphest tasks to be edited from the list view · 282b3f79
      epriestley authored
      Fixes T1945. Ref T2947. At various times, installs (Disqus, Dropbox, etc.) have asked for a way to edit tasks more quickly. Provide edit-from-lists.
      The one rough edge on this is that if you change the task priority we update it inline but don't move it. It's probably infeasible to actually move it, but maybe we could give it some sort of visual style to indicate that it's dirty.
      Test Plan: Edited tasks normally and via this action thing.
      Reviewers: chad, btrahan
      Reviewed By: chad
      CC: tido, deuresti, ahoffer, aran
      Maniphest Tasks: T1945, T2947
      Differential Revision: https://secure.phabricator.com/D6086
  30. 06 Apr, 2013 1 commit
  31. 24 Mar, 2013 1 commit
    • epriestley's avatar
      Clean up some card issues · 58a15ad2
      epriestley authored
      Ref T2826.
        - Adds a min height (arbitrarily, height of the gradient; other choices are 60px [title + avatar], or 70px [title + projects + closed + avatar]).
        - Color bars 4px -> 6px.
        - Fixes profile image clipping in Firefox, etc.
        - Removes background color from avatars, for transparent GIFs and such.
        - Fixes shift-click to select tasks in views that can't be grabbed.
      Test Plan: {F37535}
      Reviewers: chad
      Reviewed By: chad
      CC: aran
      Maniphest Tasks: T2826
      Differential Revision: https://secure.phabricator.com/D5436
  32. 23 Mar, 2013 1 commit
    • epriestley's avatar
      Use ObjectItemListView for Maniphest · 018de5de
      epriestley authored
      This isn't quite complete, but everything else is technical cleanup. Broadly:
        - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature.
        - Updated drag-to-reorder code to work with ObjectItemListView.
        - Closed/resolved is now shown with a grey footer icon.
        - Assigned is now shown with a user profile image handle icon, with a hover state.
      This could probably use some more tweaks, but overall I think it looks pretty reasonable?
      Test Plan: {F35897}
      Reviewers: chad
      Reviewed By: chad
      CC: aran
      Differential Revision: https://secure.phabricator.com/D5340
  33. 09 Mar, 2013 1 commit
    • epriestley's avatar
      Remove all calls to renderSingleView() and deprecate it · 4c914a5c
      epriestley authored
      Summary: After D5305, this method does nothing since we automatically figure out what we need to do.
      Test Plan:
      - Viewed a page with the main menu on it (MainMenuView).
      - Viewed a revision with transactions on it (TransactionView).
      - Viewed timeline UIExample (TimelineView, TimelineEventView).
      - Viewed a revision (PropertyListView).
      - Viewed a profile (ProfileHeaderView).
      - Viewed Pholio list (PinboardView, PinboardItemView).
      - Viewed Config (ObjectItemView, ObjectItemListView).
      - Viewed Home (MenuView).
      - Viewed a revision (HeaderView, CrumbsView, ActionListView).
      - Viewed a revision with an inline comment (anchorview).
      - Viewed a Phriction diff page (AphrontCrumbsView).
        - Filed T2721 to get rid of this.
      - Looked at Pholio and made inlines and comments (mockimages, pholioinlinecomment/save/edit).
      - Looked at conpherences.
      - Browsed around.
      Reviewers: chad, vrana
      Reviewed By: chad
      CC: edward, aran
      Differential Revision: https://secure.phabricator.com/D5307
  34. 13 Feb, 2013 2 commits
  35. 12 Feb, 2013 1 commit
  36. 08 Feb, 2013 1 commit
  37. 20 Dec, 2012 1 commit
  38. 05 Nov, 2012 1 commit
    • vrana's avatar
      Delete license headers from files · ef85f49a
      vrana authored
      This commit doesn't change license of any file. It just makes the license implicit (inherited from LICENSE file in the root directory).
      We are removing the headers for these reasons:
      - It wastes space in editors, less code is visible in editor upon opening a file.
      - It brings noise to diff of the first change of any file every year.
      - It confuses Git file copy detection when creating small files.
      - We don't have an explicit license header in other files (JS, CSS, images, documentation).
      - Using license header in every file is not obligatory: http://www.apache.org/dev/apply-license.html#new.
      This change is approved by Alma Chao (Lead Open Source and IP Counsel at Facebook).
      Test Plan: Verified that the license survived only in LICENSE file and that it didn't modify externals.
      Reviewers: epriestley, davidrecordon
      Reviewed By: epriestley
      CC: aran, Korvin
      Maniphest Tasks: T2035
      Differential Revision: https://secure.phabricator.com/D3886