1. 29 Mar, 2020 1 commit
    • Daniel Stone's avatar
      WIP: Maniphest: Hide hidden project tags for tasks · 287324d0
      Daniel Stone authored
      If the viewer doesn't have permission to see something a task has been
      tagged with, then don't show it to them in the Maniphest task list view,
      the task detail view, or the workboard view.
      
      This should be extended further to also eliminate it from the
      transaction history (in the task detail view) and also from
      notifications, but it's a start.
      
      This would need quite a bit more work to go upstream.
      287324d0
  2. 27 Mar, 2019 1 commit
    • epriestley's avatar
      On workboards, link ancestor project breadcrumbs to their workboards · ee54e71b
      epriestley authored
      Summary:
      Ref T13269. Currently, if you're on a milestone workboard like this:
      
      > Projects > Parent > Milestone > Workboard
      
      The "Parent" link goes to the parent profile. More often, I want it to go to the parent workboard. Try doing that? This is kind of one-off but I suspect it's a better rule.
      
      Also, consolidate one billion manual constructions of "/board/" URIs.
      
      Test Plan: Viewed a milestone workboard, clicked the parent link, ended up on the parent workboard.
      
      Reviewers: amckinley
      
      Reviewed By: amckinley
      
      Maniphest Tasks: T13269
      
      Differential Revision: https://secure.phabricator.com/D20331
      ee54e71b
  3. 01 Apr, 2016 1 commit
  4. 06 Mar, 2016 1 commit
    • epriestley's avatar
      Introduce "Curtain" views, panels, and extensions · 61f82bb9
      epriestley authored
      Summary:
      This opens up the new action column to have specialized rendering and behavior. Briefly:
      
        - Converted applications (right now, only Paste) render a `CurtainView` to build the column content.
        - This view uses new extensions to build panels (projects, subscribers, tokens).
        - The panel extension code and rendering can be changed without breaking old stuff.
      
      Minor changes:
      
        - Token awards now load their tokens, for consistency/simplicity.
        - Removed the rest of the "fork of" / "forked from" UI in Paste -- I essentially removed these features a while ago, and no one has complained.
      
      Test Plan:
      UI is a bit rough, but works, and it's going to get changed now anyway:
      
      {F1160550}
      
      {F1160551}
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Differential Revision: https://secure.phabricator.com/D15414
      61f82bb9
  5. 05 Feb, 2016 1 commit
  6. 03 Feb, 2016 1 commit
    • epriestley's avatar
      Begin lifting column layout logic out of ColumnPositionQuery · 23b835b6
      epriestley authored
      Summary:
      Ref T10010. This is a precursor to D15171, which I'll eventually rebuild on top of these changes.
      
      Currently, ColumnPositionQuery does a lot of "column layout" stuff that's very similar to the Milestone/Subproject stuff that needs to happen in D15171. The current approach there ended up splitting this layout stuff across two unrelated classes (ColumnPositionQuery + BoardViewController), neither of which is a particularly great place to do it -- the Query is too low-level, and the Controller is too high-level.
      
      Instead, introduce a new "LayoutEngine" which does all this layout stuff. Swap two of the four places that we query this stuff over to the new engine:
      
        - "Project (Column)" on tasks.
        - Transaction generation when moving cards.
      
      These sites aren't swapped by this diff, but will be by the next one:
      
        - Actually applying transactions.
        - Main layout for boards (this could swap easily now, but applying transactions currently relies on position writes having taken place, so it can't swap until the other one swaps).
      
      Once everything is swapped over, I should be able to add the D15171 logic to LayoutEngine instead of BoardViewController and end up with a cleaner approach overall.
      
      One particularly benefit is that //looking// at a board won't do a bunch of position writes anymore, which wasn't a big deal, but which I was a bit uneasy with.
      
      Test Plan:
        - Viewed tasks that are on boards, saw column annotations in project list.
        - Moved cards between columns on a board.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T10010
      
      Differential Revision: https://secure.phabricator.com/D15174
      23b835b6
  7. 24 Dec, 2015 1 commit
    • epriestley's avatar
      Show hovercards for most links in object property views · 3ec07c49
      epriestley authored
      Summary:
      Ref T8980. This isn't 100% coverage but should be pretty much all of the common ones.
      
      These feel a touch iffy to me at first glance so I didn't go crazy trying to hunt all of them down. I have some other plans for them so maybe they'll feel better by the end of it.
      
      Test Plan: Hovered over author, reviewers, blocked tasks, projects, etc.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T8980
      
      Differential Revision: https://secure.phabricator.com/D14877
      3ec07c49
  8. 09 Jan, 2015 1 commit
  9. 07 Oct, 2014 1 commit
  10. 07 Aug, 2014 1 commit
    • epriestley's avatar
      Implement PhabricatorProjectInterface on ManiphestTask · 20d8b1bd
      epriestley authored
      Summary:
      Ref T5245. This removes some hacks and activates two meaningful interactions:
      
        - The "projects" field goes through shared code now.
        - Mentioning projects in tasks using hashtags now tags them.
      
      Test Plan:
        - Viewed a task with projects.
        - Viewed a task with no projects.
        - Viewed a task with projects and board positions.
        - Viewed a revision with projects.
        - Made a `#hashtag` comment in Maniphest and got a project association.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T5245
      
      Differential Revision: https://secure.phabricator.com/D10177
      20d8b1bd
  11. 17 Jul, 2014 1 commit
    • epriestley's avatar
      Modernize Project/Object edges · 33120e37
      epriestley authored
      Summary: Ref T5245. Updates the project/object edge to use a modern class definition. Moves further toward real edges.
      
      Test Plan: Added projects to some objects, viewed transactions in transaction record.
      
      Reviewers: chad, btrahan, joshuaspence
      
      Reviewed By: joshuaspence
      
      Subscribers: epriestley
      
      Maniphest Tasks: T5245
      
      Differential Revision: https://secure.phabricator.com/D9849
      33120e37
  12. 26 Jun, 2014 2 commits
  13. 04 Jun, 2014 1 commit