1. 21 May, 2014 1 commit
    • epriestley's avatar
      Don't warn about conflicts when reverting Phriction documents · 3c8d88de
      epriestley authored
      Summary:
      Fixes T5144. This was incorrectly checking the //content// version, not the //head// version, so reverts would raise the "conflict" warning.
      
      Also fix a couple of FontAwesome icons.
      
      Test Plan:
        - Edited a document.
        - Reverted a document.
        - Opened two edit tabs. Edited one, tried to edit #2, got a warning.
        - Opened two revert tabs. Reverted in one, tried to revert in #2, got a warning.
      
      Reviewers: btrahan, chad
      
      Reviewed By: chad
      
      Subscribers: epriestley
      
      Maniphest Tasks: T5144
      
      Differential Revision: https://secure.phabricator.com/D9249
      3c8d88de
  2. 19 May, 2014 2 commits
    • epriestley's avatar
      Use PhrictionDocumentQuery to load documents · 4d7c1026
      epriestley authored
      Summary: Ref T4029. We use a lot of very outdated content loading in Phriction, which blocks T4029.
      
      Test Plan:
      - Called phriction.info
      - Called phriction.history
      - Called phriction.edit
      - Viewed document list.
      - Deleted a document.
      - Viewed history.
      - Viewed a diff.
      - Created a document.
      - Edited a document.
      - Moved a document.
      - Tried to overwrite a document with "new".
      - Tried to overwrite a document with "move".
      - Viewed a moved document note.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: shadowhand, epriestley
      
      Maniphest Tasks: T4029
      
      Differential Revision: https://secure.phabricator.com/D9194
      4d7c1026
    • epriestley's avatar
      Add very basic conflict detection to Phriction · b1ec4a9a
      epriestley authored
      Summary: Ref T4768. This is extremely basic, but will stop conflicts from going silently unnoticed.
      
      Test Plan: {F156219}
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T4768
      
      Differential Revision: https://secure.phabricator.com/D9167
      b1ec4a9a
  3. 10 Jan, 2014 1 commit
  4. 19 Dec, 2013 1 commit
    • epriestley's avatar
      Provide convenience method addTextCrumb() to PhabricatorCrumbsView · a5dc9067
      epriestley authored
      Summary: We currently have a lot of calls to `addCrumb(id(new PhabricatorCrumbView())->...)` which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.
      
      Test Plan:
        - This was mostly automated, then I cleaned up a few unusual sites manually.
        - Bunch of grep / randomly clicking around.
      
      Reviewers: btrahan, chad
      
      Reviewed By: btrahan
      
      CC: hach-que, aran
      
      Differential Revision: https://secure.phabricator.com/D7787
      a5dc9067
  5. 07 Nov, 2013 1 commit
    • Bob Trahan's avatar
      Phriction - make the check for project sub pages more fine-grained · 9084f1fe
      Bob Trahan authored
      Summary:
      we were just checking if projects/ was in the URI before barfing. Use some more fun utility functions such that we only complain if there is no project.
      
      Fixes T4071.
      
      Test Plan: made a subpage under a project - success! tried to make a project wiki page where there was no project - successful failure! tried to make a project wiki sub page where there was no project - successful failure!
      
      Reviewers: epriestley, chad
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Maniphest Tasks: T4071
      
      Differential Revision: https://secure.phabricator.com/D7527
      9084f1fe
  6. 25 Sep, 2013 1 commit
    • Chad Little's avatar
      Move PHUIFormBoxView to PHUIObjectBoxView · 9be7a948
      Chad Little authored
      Summary: I'd like to reuse this for other content areas, renaming for now. This might be weird to keep setForm, but I can fix that later if we need.
      
      Test Plan: reload a few forms in maniphest, projects, differential
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: Korvin, aran
      
      Differential Revision: https://secure.phabricator.com/D7120
      9be7a948
  7. 26 Aug, 2013 1 commit
    • Chad Little's avatar
      Update Form Layouts · fe2a96e3
      Chad Little authored
      Summary:
      This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere.
      
      TODO: will take another pass as consolidating these colors and new gradients in another diff.
      
      Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: Korvin, aran
      
      Differential Revision: https://secure.phabricator.com/D6806
      fe2a96e3
  8. 20 Aug, 2013 1 commit
  9. 05 Aug, 2013 1 commit
  10. 28 Jul, 2013 1 commit
  11. 02 Jun, 2013 1 commit
  12. 07 May, 2013 1 commit
    • Chad Little's avatar
      Update form styles, implement in many places · 43ff24b0
      Chad Little authored
      Summary:
      This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things:
      
      - Font Styles are correctly applied for form elements now.
      - Everything lines up!
      - Selects are larger, easier to read, interact.
      - Inputs have been squared.
      - Consistant CSS applied glow (try it!)
      - Improved Mobile Responsiveness
      - CSS applied to all form elements, not just Aphront
      - Many other minor tweaks.
      
      I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try.
      
      Test Plan: Tested many applications, forms, mobile and tablet.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D5860
      43ff24b0
  13. 11 Apr, 2013 1 commit
    • Chad Little's avatar
      Phriction Redesign · 7b9b872b
      Chad Little authored
      Summary: This is mostly minor, but visually it makes the wiki feel more 'page like' and better separates the actual content from other data displayed.
      
      Test Plan: Tested Chrome, iPhone, and iPad.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin, AnhNhan
      
      Maniphest Tasks: T2686
      
      Differential Revision: https://secure.phabricator.com/D5366
      7b9b872b
  14. 13 Feb, 2013 2 commits
  15. 12 Feb, 2013 1 commit
    • vrana's avatar
      Fix some HTML problems · 868ca714
      vrana authored
      Summary: I'm too lazy to attaching them for diffs where they were introduced.
      
      Test Plan:
      /
      /D1, wrote comment with code snippet
      DarkConsole
      commit detail, wrote comment
      task detail, wrote comment
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T2432
      
      Differential Revision: https://secure.phabricator.com/D4911
      868ca714
  16. 09 Feb, 2013 2 commits
  17. 08 Feb, 2013 3 commits
  18. 25 Jan, 2013 2 commits
    • Vedha Sayyaparaju's avatar
      T2385: Add "Delete Document" action to Phriction pages · cf346d3c
      Vedha Sayyaparaju authored
      Summary: If a page has not been deleted, this adds an action button to delete the document in the menu on the Phriction Page.
      
      Test Plan:
      1. Created a document, checked whether "Delete Document" button was visible.
      2. Clicked on "Delete Document" button, checked that the document had been deleted.
      3. Went back to document page, checked that the "Delete Document" button no longer existed.
      
      Reviewers: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T2385
      
      Differential Revision: https://secure.phabricator.com/D4636
      cf346d3c
    • vrana's avatar
      Convert phutil_render_tag(X, Y, '...') to phutil_tag · 20768d65
      vrana authored
      Summary:
      Created with spatch:
      
        lang=diff
        - phutil_render_tag
        + phutil_tag
          (X, Y, '...')
      
      Then searched for `&` and `<` in the output and replaced them.
      
      Test Plan: Loaded homepage.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D4503
      20768d65
  19. 27 Nov, 2012 1 commit
  20. 15 Nov, 2012 1 commit
    • Ricky Elrod's avatar
      Don't show the delete button on a deleted document · 7fac80cb
      Ricky Elrod authored
      Summary:
      This doesn't actually contain any logic to prevent a user from deleting a
      document twice, but it makes it significantly harder to do so.
      
      Test Plan:
      Went to edit a document, saw the delete button. Clicked it, then went back to
      the edit view, and no longer saw the delete button.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D3952
      7fac80cb
  21. 05 Nov, 2012 1 commit
    • vrana's avatar
      Delete license headers from files · ef85f49a
      vrana authored
      Summary:
      This commit doesn't change license of any file. It just makes the license implicit (inherited from LICENSE file in the root directory).
      
      We are removing the headers for these reasons:
      
      - It wastes space in editors, less code is visible in editor upon opening a file.
      - It brings noise to diff of the first change of any file every year.
      - It confuses Git file copy detection when creating small files.
      - We don't have an explicit license header in other files (JS, CSS, images, documentation).
      - Using license header in every file is not obligatory: http://www.apache.org/dev/apply-license.html#new.
      
      This change is approved by Alma Chao (Lead Open Source and IP Counsel at Facebook).
      
      Test Plan: Verified that the license survived only in LICENSE file and that it didn't modify externals.
      
      Reviewers: epriestley, davidrecordon
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T2035
      
      Differential Revision: https://secure.phabricator.com/D3886
      ef85f49a
  22. 17 Oct, 2012 1 commit
    • epriestley's avatar
      Raise a better error for trying to create an empty document in Phriction · 09151b50
      epriestley authored
      Summary:
      When you delete the content of a document in Phriction, we treat it as an attempt to delete the document.
      
      In the case you're creating the document, we hit an exception trying to delete a document which doesn't exist yet.
      
      Detect this case and raise a better error.
      
      Test Plan: Tried to create an empty document, got a good error. Created a nonempty document. Edited a document to empty to delete it.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T1920
      
      Differential Revision: https://secure.phabricator.com/D3728
      09151b50
  23. 10 Oct, 2012 1 commit
  24. 08 Oct, 2012 1 commit
  25. 19 Sep, 2012 1 commit
  26. 16 Jul, 2012 1 commit
    • epriestley's avatar
      When users submit a no-op edit in Phriction, don't update the document · 8fd97f43
      epriestley authored
      Summary:
      See T1501. When users mash "save", stop them if they didn't change anything.
      
      Also, don't default-fill the "edit notes" field with the previous notes. This is meant to be more like a commit message for your changes.
      
      Test Plan: Edited a document with no changes, got a dialog. Edited a document with a title change only and a description change only, things worked. Edited a document with a previous "Edit notes", got a blank default fill.
      
      Reviewers: alanh, btrahan, vrana
      
      Reviewed By: vrana
      
      CC: aran
      
      Maniphest Tasks: T1501
      
      Differential Revision: https://secure.phabricator.com/D2978
      8fd97f43
  27. 01 Jun, 2012 1 commit
    • vrana's avatar
      Move files in Phabricator one level up · 6cc196a2
      vrana authored
      Summary:
      - `kill_init.php` said "Moving 1000 files" - I hope that this is not some limit in `FileFinder`.
      - [src/infrastructure/celerity] `git mv utils.php map.php; git mv api/utils.php api.php`
      - Comment `phutil_libraries` in `.arcconfig` and run `arc liberate`.
      
      NOTE: `arc diff` timed out so I'm pushing it without review.
      
      Test Plan:
      /D1234
      Browsed around, especially in `applications/repository/worker/commitchangeparser` and `applications/` in general.
      
      Auditors: epriestley
      
      Maniphest Tasks: T1103
      6cc196a2
  28. 20 May, 2012 1 commit
    • Bob Trahan's avatar
      Phriction - lock down /project/ wiki docs · a9000ea2
      Bob Trahan authored
      Summary:
      only show the blank, "create new" wiki page for the project if the project actually exists; only allow edit if the project actually exists.
      Small wrinkle here is not checking if the project actually exists if the page already exists.
      
      Test Plan:
      - viewed a project wiki page
      - viewed a prokect wiki page for a fake project and got a 404
      - edited a project wiki page
      - edited a project wiki page for a fake project and got a 404
      
      Reviewers: epriestley, jacktrades
      
      Reviewed By: epriestley
      
      CC: aran, Koolvin
      
      Maniphest Tasks: T1248
      
      Differential Revision: https://secure.phabricator.com/D2506
      a9000ea2
  29. 10 Apr, 2012 1 commit
  30. 09 Mar, 2012 1 commit
    • epriestley's avatar
      Add "final" to all Phabricator "Controller" classes · b2890eeb
      epriestley authored
      Summary:
      These are all unambiguously unextensible. Issues I hit:
      
        - Maniphest Change/Diff controllers, just consolidated them.
        - Some search controllers incorrectly extend from "Search" but should extend from "SearchBase". This has no runtime effects.
        - D1836 introduced a closure, which we don't handle correctly (somewhat on purpose; we target PHP 5.2). See T962.
      
      Test Plan: Ran "testEverythingImplemented" unit test to identify classes extending from `final` classes. Resolved issues.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran, epriestley
      
      Maniphest Tasks: T795
      
      Differential Revision: https://secure.phabricator.com/D1843
      b2890eeb
  31. 13 Jan, 2012 1 commit
    • epriestley's avatar
      Add basic draft support to Phriction · f5e1e337
      epriestley authored
      Summary:
        - When a user is creating a Phriction document, save a draft as
      "phriction:<slug>".
        - When a user is editing a Phriction document, save a draft as "<document
      phid>:<document version>".
        - If a user has an available draft, use that instead of the native content.
        - If using a draft, tell the user and give them an option to discard it.
        - If a page is updated, your draft is lost (we show new page content
      unconditionally) but this should be rare and is the simplest way to resolve this
      issue in a realtively consistent way.
      
      Test Plan:
        - Recovered drafts for new and edited pages.
        - Used "nodraft" to discard drafts.
      
      Reviewers: davidreuss, btrahan, jungejason
      
      Reviewed By: davidreuss
      
      CC: aran, davidreuss
      
      Maniphest Tasks: T769
      
      Differential Revision: https://secure.phabricator.com/D1378
      f5e1e337
  32. 17 Dec, 2011 1 commit
    • epriestley's avatar
      Allow Phriction documents to be deleted · afc2f852
      epriestley authored
      Summary:
        - Add a "delete" operation. Delete is just a special edit which removes the
      page from indexes and shows a notice that the document has been deleted.
        - When a user deletes all the content on a page, treat it as a delete.
        - When a conduit call deletes all the content on a page, treat it as a delete.
        - Add page status to Conduit.
        - Add change type field to history.
        - Added a couple of constants to support a future 'move' change, which would
      move content from one document to another.
      
      Test Plan:
        - Verified deleted pages vanish from the document index (and restoring them
      puts them back).
        - Verified deleted pages show "This page has been deleted...".
        - Created, edited and deleted a document via Conduit.
        - Deleted pages via "delete" button.
        - Deleted pages via editing content to nothing.
      
      Reviewers: btrahan, jungejason
      
      Reviewed By: btrahan
      
      CC: skrul, aran, btrahan, epriestley
      
      Maniphest Tasks: T680
      
      Differential Revision: 1230
      afc2f852
  33. 07 Dec, 2011 1 commit
    • epriestley's avatar
      Add "tabindex" to Remarkup reference lists · d13906ff
      epriestley authored
      Summary:
      Prevent keyboard focus of these links so we don't disrupt tab order from
      comments to "Submit".
      
      Arguably I should make a "function" for this or something but there's nowhere to
      really put it that makes any sense right now.
      
      Test Plan: Verified Firefox skips these links in tab order.
      
      Reviewers: fratrik, btrahan, jungejason
      
      Reviewed By: fratrik
      
      CC: aran, fratrik
      
      Maniphest Tasks: T661
      
      Differential Revision: 1180
      d13906ff
  34. 14 Sep, 2011 1 commit