1. 12 Jan, 2017 1 commit
    • epriestley's avatar
      Render revision and audit state icons in Maniphest · 45c740ac
      epriestley authored
      Summary:
      Fixes T7076. This could probably use some tweaking but should get the basics in place.
      
      This shows overall object state (e.g., "Needs Review"), not individual viewer state (e.g., "you need to review this"). After the bucketing changes it seems like we're mostly in a reasonable place on showing global state instead of viewer state. This makes the overall change much easier than it might otherwise have been.
      
      Test Plan: {F2351867}
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T7076
      
      Differential Revision: https://secure.phabricator.com/D17193
      45c740ac
  2. 10 Nov, 2016 1 commit
  3. 14 May, 2016 1 commit
    • epriestley's avatar
      Allow monogrammed objects to be parsed from the `arc` command line in... · 3ea47d96
      epriestley authored
      Allow monogrammed objects to be parsed from the `arc` command line in "Reviewers" and similar fields
      
      Summary:
      Ref T10939. This allows the CLI to parse reviewers and subscribers like this:
      
      ```Reviewers: epriestley, O123 Some Package Name```
      
      The rule goes:
      
        - If a reviewer or subscriber starts with a monogram (like `X111`), just look that up and ignore everything until the next comma.
        - Otherwise, split it on spaces and look up each part.
      
      This means that these are valid:
      
      ```
      alincoln htaft
      alincoln, htaft
      #a #b epriestley
      O123 Some Package, epriestley, #b
      ```
      
      I think the only real downside is that this:
      
      ```
      O123 Some Package epriestley
      ```
      
      ...ignores the "epriestley" part. However, I don't expect users to be typing package monograms manually -- they just need to be representable by `arc land` and `arc diff --edit` and such. Those flows will always add commas and make the parse unambiguous.
      
      Test Plan:
        - Added test coverage.
        - `amend --show`'d a revision with a package subscriber (this isn't currently possible to produce using the web UI, it came from a future change) and saw `Subscribers: O123 package name, usera, userb`.
        - Updated a revision with a package subscriber.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T10939
      
      Differential Revision: https://secure.phabricator.com/D15911
      3ea47d96
  4. 03 Feb, 2016 1 commit
  5. 01 Feb, 2016 1 commit
  6. 28 Jan, 2016 1 commit
  7. 24 Jan, 2016 1 commit
  8. 24 Dec, 2015 1 commit
    • epriestley's avatar
      Show hovercards for most links in object property views · 3ec07c49
      epriestley authored
      Summary:
      Ref T8980. This isn't 100% coverage but should be pretty much all of the common ones.
      
      These feel a touch iffy to me at first glance so I didn't go crazy trying to hunt all of them down. I have some other plans for them so maybe they'll feel better by the end of it.
      
      Test Plan: Hovered over author, reviewers, blocked tasks, projects, etc.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T8980
      
      Differential Revision: https://secure.phabricator.com/D14877
      3ec07c49
  9. 15 Jun, 2015 1 commit
    • Joshua Spence's avatar
      Extend from Phobject · b6d745b6
      Joshua Spence authored
      Summary: All classes should extend from some other class. See D13275 for some explanation.
      
      Test Plan: `arc unit`
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: epriestley, Korvin
      
      Differential Revision: https://secure.phabricator.com/D13283
      b6d745b6
  10. 14 May, 2015 1 commit
    • epriestley's avatar
      Separate handle "status" and "availability" · 04186e02
      epriestley authored
      Summary:
      Ref T7707. Handles currently have a "status" field and a "disabled" field.
      
      The "status" field has these possible values: "open", "closed", "1", "2". durp durp durp
      
      Instead, do:
      
        - status = <open, closed>
        - availability = <full, partial, none, disabled>
      
      I think these make more sense? And are a bit more general? And use the same kind of constants for all values!
      
      Test Plan: Looked at all affected handles in all states (probably).
      
      Reviewers: chad, btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T7707
      
      Differential Revision: https://secure.phabricator.com/D12832
      04186e02
  11. 17 Apr, 2015 1 commit
    • epriestley's avatar
      Make token UI stronger and more consistent · 76448a75
      epriestley authored
      Summary:
      Ref T4100. Overall:
      
        - Use token background color to communicate token type (blue = object, yellow = function, grey = disabled/closed, red = invalid).
        - Use token icon color to make color choices consistent (specifically, use project icon colors in project tokens).
        - For functions, use token icon to communicate function result type (e.g., viewer() has a user icon; members(...) has a group icon), since we don't need the icon to indicate "this is a function" anymore.
      
      Test Plan:
      {F374615}
      {F374616}
      {F374617}
      
      Reviewers: chad, btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T4100
      
      Differential Revision: https://secure.phabricator.com/D12446
      76448a75
  12. 23 Jul, 2014 1 commit
    • Joshua Spence's avatar
      Rename `PHIDType` classes · 97a8700e
      Joshua Spence authored
      Summary: Ref T5655. Rename `PhabricatorPHIDType` subclasses for clarity (see discussion in D9839). I'm not too keen on some of the resulting class names, so feel free to suggest alternatives.
      
      Test Plan: Ran unit tests.
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: epriestley, Korvin, hach-que
      
      Maniphest Tasks: T5655
      
      Differential Revision: https://secure.phabricator.com/D9986
      97a8700e
  13. 26 Jun, 2014 3 commits
  14. 23 May, 2014 1 commit
    • Bob Trahan's avatar
      Project - add ability to select an icon for typeaheads and such · 102befde
      Bob Trahan authored
      Summary: Fixes T5090. Introduced getIcon into Handle stack which allows you to specify a per handle icon. getIcon falls back ot getTypeIcon.
      
      Test Plan: changed the icon on a project a bunch. verified transactions showed up. verified icon showed up in typeahead. verified icon showed up in tokens that were pre-generated (not typed in). units test passed.
      
      Reviewers: chad, epriestley
      
      Reviewed By: epriestley
      
      Subscribers: epriestley, Korvin
      
      Maniphest Tasks: T5090
      
      Differential Revision: https://secure.phabricator.com/D9264
      102befde
  15. 12 May, 2014 1 commit
    • Chad Little's avatar
      Replace Sprite-Icons with FontAwesome · b2f3001e
      Chad Little authored
      Summary: The removes the sprite sheet 'icons' and replaces it with FontAwesome fonts.
      
      Test Plan:
      - Grep for SPRITE_ICONS and replace
      - Grep for sprite-icons and replace
      - Grep for PhabricatorActionList and choose all new icons
      - Grep for Crumbs and fix icons
      - Test/Replace PHUIList Icon support
      - Test/Replace ObjectList Icon support (foot, epoch, etc)
      - Browse as many pages as I could get to
      - Remove sprite-icons and move remarkup to own sheet
      - Review this diff in Differential
      
      Reviewers: btrahan, epriestley
      
      Reviewed By: epriestley
      
      Subscribers: epriestley, Korvin, hach-que
      
      Differential Revision: https://secure.phabricator.com/D9052
      b2f3001e
  16. 14 Feb, 2014 1 commit
    • epriestley's avatar
      Provide result type information in tokenizers · 3c19f363
      epriestley authored
      Summary:
      Ref T1279. The new dual-mode user/project tokenizers are a bit disorienting. Provide content type hints.
      
      Very open to any suggestions here, most of this patch is just getting the right data in the right places. We can change things up pretty easily.
      
        - I like the little icons in the tokens themselves, I think they look good and are useful.
        - I'm less sold on the '(Project)' thing I did in the dropdown. We can easily make this richer if you have thoughts on it -- we could put icons in the left column maybe? Or right-justify the types?
        - I made it always sort users above projects.
      
      Test Plan: See screenshot.
      
      Reviewers: chad, btrahan
      
      Reviewed By: btrahan
      
      CC: chad, aran, carl
      
      Maniphest Tasks: T4420, T1279
      
      Differential Revision: https://secure.phabricator.com/D7250
      3c19f363
  17. 17 Oct, 2013 1 commit
    • epriestley's avatar
      Distinguish between invalid/broken handles and filtered handles · 95c2b03f
      epriestley authored
      Summary:
      Ref T603. Currently, we render handles the user doesn't have permission to see in a manner identical to handles that don't exist. This is confusing, and not required by policies (which restrict content, but permit knowledge that an object exists).
      
      Instead, render them in different styles. Bad/invalid objects look like:
      
        Unknown Object (Task)
      
      Restricted objects look like:
      
        [o] Restricted Task
      
      ...where `[o]` is the padlock icon.
      
      Test Plan:
      {F71100}
      
      {F71101}
      
      It's possible this renders weird somewhere, but I wasn't immediately able to find any issues. Yell if you see something.
      
      Reviewers: btrahan, chad
      
      Reviewed By: btrahan
      
      CC: chad, aran
      
      Maniphest Tasks: T603
      
      Differential Revision: https://secure.phabricator.com/D7334
      95c2b03f
  18. 05 Oct, 2013 1 commit
    • epriestley's avatar
      Allow projects to review revisions · cf4eb310
      epriestley authored
      Summary:
      Ref T1279. No actual logical changes, but:
      
        - You can now add projects as reviewers from the revision view typeahead ("Add Reviewers" action).
        - You can now add projects as reviewers from the revision detail typeahead.
        - You can now add projects as reviewers from the CLI (`#yoloswag`).
        - Generated commit messages now list project reviewers (`Reviewers: #yoloswag`).
      
      I'll separate projects from users in the "Reviewers" tables in the next revision.
      
      Test Plan:
        - Added projects as reviewers using the web UI and CLI.
        - Used `arc amend --show --revision Dnnn` to generate commit messages.
        - Viewed revision with project reviewers in web UI.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T1279
      
      Differential Revision: https://secure.phabricator.com/D7230
      cf4eb310
  19. 27 Sep, 2013 1 commit
    • epriestley's avatar
      Explain policy exception rules to users · 2e5ac128
      epriestley authored
      Summary:
      Ref T603. Adds clarifying text which expands on policies and explains exceptions and rules. The goal is to provide an easy way for users to learn about special policy rules, like "task owners can always see a task".
      
      This presentation might be a little aggressive. That's probably OK as we introduce policies, but something a little more tempered might be better down the road.
      
      Test Plan: See screenshot.
      
      Reviewers: btrahan, chad
      
      Reviewed By: chad
      
      CC: aran
      
      Maniphest Tasks: T603
      
      Differential Revision: https://secure.phabricator.com/D7150
      2e5ac128
  20. 11 Sep, 2013 1 commit
    • Bob Trahan's avatar
      Kill PhabricatorObjectDataHandle · b902005b
      Bob Trahan authored
      Summary: Ref T603. Killing this class is cool because the classes that replace it are policy-aware. Tried to keep my wits about me as I did this and fixed a few random things along the way. (Ones I remember right now are pulling a query outside of a foreach loop in Releeph and fixing the text in UIExample to note that the ace of hearts if "a powerful" card and not the "most powerful" card (Q of spades gets that honor IMO))
      
      Test Plan: tested the first few changes (execute, executeOne X handle, object) then got real mechanical / careful with the other changes.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: Korvin, aran, FacebookPOC
      
      Maniphest Tasks: T603
      
      Differential Revision: https://secure.phabricator.com/D6941
      b902005b
  21. 07 Aug, 2013 1 commit
    • epriestley's avatar
      Fix text-mode rendering of object and Asana link views · ab7a0912
      epriestley authored
      Summary:
      Ref T2852. Two issues:
      
        - Embeds (`T12`, `{T12}`) have some handle issues because handles run afoul of visibility checks under some configs. Make handles unconditionally visible.
        - Asana links don't render correctly into text mode. Give them a valid text mode rendering so they don't flip out.
      
      Test Plan: Made comments with `T12` and `http://app.asana.com/...` and published them to Asana.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T2852
      
      Differential Revision: https://secure.phabricator.com/D6696
      ab7a0912
  22. 06 Aug, 2013 1 commit
    • Chad Little's avatar
      Add Hovercards / restyle feed one line stories. · b348aaef
      Chad Little authored
      Summary: This adds hovercards to most stories and removes the profile photo from one line stories. I don't know about my implementation, which has difficulties with application transactions (because it shows status). Which leads me to a bigger question, which is can we render all people through a common function like AphrontTagView so we can easily class and/or hovercard it anywhere.
      
      Test Plan: Reviewed my feed, various stories.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D6684
      b348aaef
  23. 26 Jul, 2013 4 commits
  24. 25 Jul, 2013 1 commit
    • Bob Trahan's avatar
      Pholio - add concept of replacing images and primitive history view · f75f3a0c
      Bob Trahan authored
      Summary:
      Now you can actually replace an image! Ref T3572. This ended up needing a wee bit of infrastructure to work...
      
       - add replace image transaction to pholio
       - add replacesImagePHID to PholioImage
       - tweaks to editor to properly update images with respect to replacement
         - add edges to track replacement
       - expose getNodes on graph query infrastructure to query the entire graph of who replaced who
       - move pholio image to new phid infrastructure
      
      Still TODO - the history view should get chopped out a bit from the current view - no more inline comments / generally less functionality plus maybe a tweak or two to make this more sensical.
      
      Test Plan: replaced images and played with history controller a little. works okay.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T3572
      
      Differential Revision: https://secure.phabricator.com/D6560
      f75f3a0c
  25. 24 Jul, 2013 5 commits
  26. 22 Jul, 2013 6 commits