1. 12 Jan, 2017 1 commit
    • epriestley's avatar
      Render revision and audit state icons in Maniphest · 45c740ac
      epriestley authored
      Summary:
      Fixes T7076. This could probably use some tweaking but should get the basics in place.
      
      This shows overall object state (e.g., "Needs Review"), not individual viewer state (e.g., "you need to review this"). After the bucketing changes it seems like we're mostly in a reasonable place on showing global state instead of viewer state. This makes the overall change much easier than it might otherwise have been.
      
      Test Plan: {F2351867}
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T7076
      
      Differential Revision: https://secure.phabricator.com/D17193
      45c740ac
  2. 09 Jan, 2017 1 commit
    • epriestley's avatar
      Remove extra container tag on HandleListViews rendering from ModularTransactions in text mode · b08c9b3f
      epriestley authored
      Summary:
      Fixes T12082. Ref T11114. When modular transaction render a handle list, they use HandleListView, which has a text mode.
      
      However, the HandleListView is a TagView, and currently TagViews always render a tag of some kind. Allow them to return `null` to decline to render any tag.
      
      Test Plan:
        - Added a pile of debugging stuff to `ApplicationTransactionEditor` to throw during mail generation.
        - Added a reviewer to a revision.
        - Used `bin/worker execute --id ...` to hit the mail generation repeatedly.
        - Before patch: mail generated with a <span>, even in text mode.
        - After patch: clean mail generation.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T12082, T11114
      
      Differential Revision: https://secure.phabricator.com/D17162
      b08c9b3f
  3. 13 Jul, 2016 1 commit
    • epriestley's avatar
      Convert Calendar to Modular Transactions · 7b09f569
      epriestley authored
      Summary:
      Ref T9275. Swaps Calendar over to modular transactions. Theoretically, this has almost no effect on anything.
      
      Ref T10633. I didn't actually do anything here yet, but this gets us ready to put timestamps in email.
      
      Test Plan: Created and edited a bunch of events, nothing seemed catastrophically broken.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T9275, T10633
      
      Differential Revision: https://secure.phabricator.com/D16286
      7b09f569
  4. 24 Dec, 2015 1 commit
    • epriestley's avatar
      Show hovercards for most links in object property views · 3ec07c49
      epriestley authored
      Summary:
      Ref T8980. This isn't 100% coverage but should be pretty much all of the common ones.
      
      These feel a touch iffy to me at first glance so I didn't go crazy trying to hunt all of them down. I have some other plans for them so maybe they'll feel better by the end of it.
      
      Test Plan: Hovered over author, reviewers, blocked tasks, projects, etc.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T8980
      
      Differential Revision: https://secure.phabricator.com/D14877
      3ec07c49
  5. 31 Mar, 2015 2 commits
    • epriestley's avatar
      Remove Controller->renderHandlesForPHIDs() · e1eafd78
      epriestley authored
      Summary: Ref T7689. Remove all remaining callsites for this method.
      
      Test Plan:
      - Viewed a custom policy; viewed handles in the policy rules.
      - Viewed a Releeph product; viewed "Pushers".
      - Viewed a project; viewed "Watchers"; viewed "Members"; viewed "Looks Like".
      - Viewed repository edit; viewed "Credential"; viewed "Storage Service"; viewed "Projects".
      - Viewed repository detail; viewed "Projects".
      - Viewed commit; viewed (faked) "Reverts"; viewed (faked) "Reverted By".
        - These are kind of a pain to generate so I faked 'em.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T7689
      
      Differential Revision: https://secure.phabricator.com/D12208
      e1eafd78
    • epriestley's avatar
      Prepare a replacement for Controller->renderHandlesForPHIDs() · dec03cf0
      epriestley authored
      Summary:
      Ref T7689. This gives HandleLists `renderList()` and `renderHandle()` methods, which return views that can perform just-in-time data fetching and generally look and feel like other rendering code, instead of being odd pseudo-functional methods on `Controller`.
      
      Also converts callsites on the Maniphest detail page to use these methods.
      
      Next changes will wipe out more of the callsites.
      
      Test Plan:
        - Viewed Maniphest detail page with many relevant handles.
        - Created a new subtask.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T7689
      
      Differential Revision: https://secure.phabricator.com/D12205
      dec03cf0