1. 18 Jul, 2017 5 commits
  2. 13 Jul, 2017 1 commit
    • Chad Little's avatar
      Update Support diviner document · bddd1da0
      Chad Little authored
      Summary: This updates the support document, specifically, scopes down feature requests, updates community links, and other wordsmithing. Unsure where to direct bug reports right now, but we'll have something soon?
      
      Test Plan: Read carefully
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Luke081515.2, Korvin
      
      Differential Revision: https://secure.phabricator.com/D18218
      bddd1da0
  3. 12 Jul, 2017 4 commits
  4. 11 Jul, 2017 3 commits
    • Chad Little's avatar
      Hide Pager border if no pager exists · 7408483c
      Chad Little authored
      Summary: I guess we have this magical method that tells me if a pager is coming down the render pipe. Huzzah.
      
      Test Plan: Test Branches page in Diffusion, see no pager border.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin
      
      Differential Revision: https://secure.phabricator.com/D18202
      7408483c
    • Chad Little's avatar
      Move Clone Repository to Dialog · a6b550ba
      Chad Little authored
      Summary: This moves the clone details on the Repository Home to a button / dialog. Functionally this is to pull content on the page way up, while giving full space to all the clone options. I think we can build this into some FancyJS if needed, but this seems to clean ui the UI dramatically with little overhead. I don't want to attempt the JS dropdown unless we're sure that's the best path (it exposes the most common URI by default, saving a click).
      
      Test Plan: Tested hg, svn, git repositories and the raw URL page. Test close button.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin
      
      Differential Revision: https://secure.phabricator.com/D18203
      a6b550ba
    • Chad Little's avatar
      Rudamentary PHUILeftRightView · b987b4dd
      Chad Little authored
      Summary: First pass at providing a skeleton framework for laying out basic items in a left/right view. Will likely add some mobile-responsive options.
      
      Test Plan: UIExamples
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin
      
      Differential Revision: https://secure.phabricator.com/D18200
      b987b4dd
  5. 10 Jul, 2017 3 commits
  6. 09 Jul, 2017 5 commits
  7. 07 Jul, 2017 1 commit
  8. 06 Jul, 2017 1 commit
    • epriestley's avatar
      Fix several pieces of UI language describing "draft/archive" rules in Phame · 8d11e127
      epriestley authored
      Summary: Ref T12900. We implement one rule, but tell users a different (older) rule. See T12900 for discussion and history.
      
      Test Plan:
        - Verified draft/archived posts can't be seen by users who don't have permission to edit the blog.
        - Drafted, archived, and published posts and read the related text.
        - Looked through the changes I dug up in T12900#228748 for other strings I might have missed.
      
      {F5033860}
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T12900
      
      Differential Revision: https://secure.phabricator.com/D18182
      8d11e127
  9. 05 Jul, 2017 2 commits
    • Chad Little's avatar
      Add tabs to Diffusion for consistent navigation · e516358d
      Chad Little authored
      Summary:
      Adds a responsive tab bar navigation to Diffusion. Working through the new design here in pieces, so keep in mind M1477 is the target. Notably:
      
      - Removes "branches" and "tags" from RevisionView, now on tabs
      - Keeps "browse", "history", "readme" on RevisionView
      - Adds tabs for all main views, including Graph... unless how that feels, so let me know.
      
      Test Plan: Browse all pages, desktop and mobile. Test hg, svn, git repositories.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin
      
      Differential Revision: https://secure.phabricator.com/D18161
      e516358d
    • epriestley's avatar
      Document the need to restart Phabricator after performing a restore · 7b6b3d72
      epriestley authored
      Summary:
      Depending on how you perform a restore, APC (or, e.g., running daemon processes) might be poisoned with out-of-date caches.
      
      Add a note to advise installs to restart after restoring data.
      
      See also lengthy fishing expedition support thread.
      
      Test Plan: Read the text.
      
      Reviewers: chad, amckinley
      
      Reviewed By: amckinley
      
      Differential Revision: https://secure.phabricator.com/D18180
      7b6b3d72
  10. 03 Jul, 2017 1 commit
  11. 02 Jul, 2017 1 commit
  12. 01 Jul, 2017 1 commit
    • Chad Little's avatar
      Move Diffusion Browse to a single column layout · b25b379c
      Chad Little authored
      Summary: The main change here is moving (compare, search, history) into buttons in the header bar on all browse views. This allows Directory Browsing to be full width, since there is no other curtain information. File, Image, LFS, Binary all stay in TwoColumn layouts with the same buttons in the header.
      
      Test Plan: Test viewing a directory, file, image, binary file, readme, and fake a gitlfs.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin
      
      Differential Revision: https://secure.phabricator.com/D17766
      b25b379c
  13. 30 Jun, 2017 3 commits
    • epriestley's avatar
      Use the correct "completed" time in Harbormaster display UI · eab8d8a2
      epriestley authored
      Summary: Fixes T12883. The task seems correct to me and I think this is a copy/paste mistake that probably blames to me.
      
      Test Plan: Fiddled these numbers, viewed a build in Harbormaster, saw the adjusted time.
      
      Reviewers: chad, amckinley
      
      Reviewed By: chad
      
      Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
      
      Maniphest Tasks: T12883
      
      Differential Revision: https://secure.phabricator.com/D18177
      eab8d8a2
    • epriestley's avatar
      Correct a datasource issue when viewing repository URIs in "Manage Repository" · 4e047f7b
      epriestley authored
      Summary:
      Fixes T12884. In cases other than this UI, applications access URIs through the Repository they're part of. This means that applications interact with URIs which have gone through the correction/adjustment logic in `PhabricatorRepository->attachURIs()`, which fixes up "builtin" URIs to have the right values based on configuration.
      
      In this case (and, as far as I can tell, only this case) we load the URI directly //and// act on its properties which depend on configuration and repository state.
      
      This can mean we're using a different view of the URI than we should be.
      
      To fix this: after loading the URI, reload it through the repository so the relevant adjustments are applied.
      
      I think this is the most reasonable fix. We could try to make `RepositoryURIQuery` somehow enforce this, but the cost of this error is small (mild confusion about display state), the other things which do direct loads don't depend on this state (editing), and everything else loads via a repository and is likely to continue doing that forever.
      
      Test Plan: {F5026633}
      
      Reviewers: chad, amckinley
      
      Reviewed By: chad
      
      Maniphest Tasks: T12884
      
      Differential Revision: https://secure.phabricator.com/D18176
      4e047f7b
    • epriestley's avatar
      Move misplaced validation for ambiguous fields in "Test Plan" to the right place · 596b83a7
      epriestley authored
      Summary:
      When users use the web UI to enter text like "Reviewers: x" into the "Summary" or "Test Plan", we can end up with an ambiguous commit message.
      
      Some time ago we added a warning about this to the "Summary" field, and //attempted// to add it to the "Test Plan" field, but it actually gets called from the wrong place.
      
      Remove the code from the wrong place (no callers, not reachable) and put it in the right place.
      
      This fixes an issue where users could edit a test plan from the web UI to add the text "Tests: ..." and cause ambiguities on a later "arc diff --edit".
      
      Test Plan: {F5026603}
      
      Reviewers: chad, amckinley
      
      Reviewed By: chad
      
      Differential Revision: https://secure.phabricator.com/D18175
      596b83a7
  14. 28 Jun, 2017 1 commit
  15. 27 Jun, 2017 8 commits