1. 05 May, 2015 4 commits
  2. 04 May, 2015 25 commits
    • epriestley's avatar
      Fix a handle-related fatal in Conpherence · f311f3f9
      epriestley authored
      I'll file an issue for this, but it locked up my UI since I've got a mention in a recent thread.
      
      Auditors: btrahan
      f311f3f9
    • Joshua Spence's avatar
      Add repository parameter to `diffusion.findsymbols` method · 2cc898a6
      Joshua Spence authored
      Summary: Ref T7977. Add a repository parameter to the `diffusion.findsymbols` Conduit method to allow restricting search results to the specified repository.
      
      Test Plan: Queried the Conduit endpoint.
      
      Reviewers: avivey, epriestley, #blessed_reviewers
      
      Reviewed By: avivey, epriestley, #blessed_reviewers
      
      Subscribers: eadler, avivey, Korvin, epriestley
      
      Maniphest Tasks: T7977
      
      Differential Revision: https://secure.phabricator.com/D12663
      2cc898a6
    • Bob Trahan's avatar
      Add missing typehint · f83e12c9
      Bob Trahan authored
      Summary: Ref D12694.
      
      Test Plan: no more error in the logs
      
      Reviewers: epriestley, joshuaspence
      
      Reviewed By: joshuaspence
      
      Subscribers: Korvin, epriestley
      
      Differential Revision: https://secure.phabricator.com/D12709
      f83e12c9
    • Bob Trahan's avatar
      Quicksand - fix toggle behavior to work with quicksand · 1db79044
      Bob Trahan authored
      Summary:
      Fixes T7919. This is a pretty generic toggle behavior. Make it quicksand ready by making it install only once and swallow the regular "click" event so the quicksand "click" event doesn't get funky with it.
      
      Also fixes a bug in Quicksand that I discovered developing / testing this feature. We have to update the internal member variable to be better than 0 similarly to how id works. So do that.
      
      Test Plan: went to phriction, toggled menu open, clicked home, clicked phriction and toggled menu again. Went back in history and noted menu was left to toggle state I previously had it. (currently a feature, not a bug)
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T7919
      
      Differential Revision: https://secure.phabricator.com/D12708
      1db79044
    • Joshua Spence's avatar
      Add some missing type hints · 4ea9d76f
      Joshua Spence authored
      Summary: Add some typehints for Remarkup rules.
      
      Test Plan: Browsed around some Remarkup text.
      
      Reviewers: #blessed_reviewers, epriestley
      
      Reviewed By: #blessed_reviewers, epriestley
      
      Subscribers: Korvin, epriestley
      
      Differential Revision: https://secure.phabricator.com/D12694
      4ea9d76f
    • Joshua Spence's avatar
      Add "and" support to "ref" · 6bebb3c6
      Joshua Spence authored
      Summary: Fixes T8038. Allow `PhabricatorCustomFieldMonogramParser` to handle "and". This means that `Ref Tx, Ty and Tz` will correctly return `array('monograms' => array('Tx', 'Ty', 'Tz')`.
      
      Test Plan: Added unit tests.
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: epriestley
      
      Maniphest Tasks: T2, T3, T1, T8038
      
      Differential Revision: https://secure.phabricator.com/D12682
      6bebb3c6
    • Bob Trahan's avatar
      Conpherence - add back in custom images · 16ce63ec
      Bob Trahan authored
      Summary: Fixes T7254. This reverts the previous functionality, but makes pertinent updates like scaling the images to 35 x 35. Codebase had moved on quite a bit so far from a straight revert but nothing too tricky relative to the code that was here before. This does not allow for changing the images from the conpherence durable column view -- that would require some JS trickery, but also doesn't fit into the current notion of the column being "light". Can always modify this later.
      
      Test Plan:
       - from full conpherence, uploaded a square pic and things looked nice
       - from full conpherence, uploaded a rectangular pic and wasnt happy, so reinvoked edit dialog and used crop control to make it better
       - noted could not update picture from conpherence durable column
       - used different user and noted could see custom picture
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      Subscribers: CodeMouse92, Korvin, epriestley
      
      Maniphest Tasks: T7254
      
      Differential Revision: https://secure.phabricator.com/D12648
      16ce63ec
    • epriestley's avatar
      Highlight cell when jumping to an inline comment · 9c7d1b0b
      epriestley authored
      Summary: Fixes T8061.
      
      Test Plan: {F392321}
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Subscribers: epriestley
      
      Maniphest Tasks: T8061
      
      Differential Revision: https://secure.phabricator.com/D12705
      9c7d1b0b
    • epriestley's avatar
      Add a preference to disable ghost comments · 29feca3c
      epriestley authored
      Summary: Ref T7447. At least some users dislike this feature so strongly that they'd prefer not to have it at all.
      
      Test Plan: Viewed ghosts; toggled preference, no more ghosts.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Subscribers: yelirekim, epriestley
      
      Maniphest Tasks: T7447
      
      Differential Revision: https://secure.phabricator.com/D12704
      29feca3c
    • Chad Little's avatar
      Remove click to view on ghosties · 861155ea
      Chad Little authored
      Summary: Ref T7447, these are more work than needed at least on an indivdual basis. JS openning all feels poor as well.
      
      Test Plan: Review comments, past present and future.
      
      Reviewers: btrahan, epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T7447
      
      Differential Revision: https://secure.phabricator.com/D12702
      861155ea
    • epriestley's avatar
      Provide link to inlines in-context in $ghost['href'] · 460d68ba
      epriestley authored
      Summary: See D12702.
      
      Test Plan: Made something a link and clicked it, seemed to work OK.
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Subscribers: yelirekim, epriestley
      
      Differential Revision: https://secure.phabricator.com/D12703
      460d68ba
    • lkassianik's avatar
      Refactoring CalendarEventSearchEngine to fit new null handling of AphrontFormDateControlValue · c02db2d1
      lkassianik authored
      Summary: Ref T4393, Refactoring CalendarEventSearchEngine to fit new null handling of AphrontFormDateControlValue
      
      Test Plan: Use calendar query for day view, expect no php errors
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T4393
      
      Differential Revision: https://secure.phabricator.com/D12701
      c02db2d1
    • epriestley's avatar
      Allow accounts and merchants to review unpaid invoices in Phortune · 2c5760d0
      epriestley authored
      Summary:
      Ref T6881. Allows accounts to browse all unpaid invoices (although we currently show all of them on the account screen anyway).
      
      Also allows merchants to browse unpaid invoices, which they could not do before. This will let us start suspending instances for nonpayment eventually.
      
      Test Plan:
        - Browsed unpaid invoices as various users.
        - Browsed merchant unpaid invoices.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T6881
      
      Differential Revision: https://secure.phabricator.com/D12681
      2c5760d0
    • lkassianik's avatar
      Make calendar day view events fill up the correctly sized slots · 853f42e9
      lkassianik authored
      Summary: Ref T4393, Make calendar day view events fill up the correctly sized slots. (not handling overlapping slots)
      
      Test Plan: Create an event 4:30-5:30am. Day view should correctly reflect when event happens.
      
      Reviewers: epriestley, #blessed_reviewers, chad
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T4393
      
      Differential Revision: https://secure.phabricator.com/D12700
      853f42e9
    • epriestley's avatar
      Support colloquial time names to dramatically improve usability of time control · 3ea7359e
      epriestley authored
      Summary: Ref T8024. The time control currently does not support colloquial time names frequently used in common parlance. Support these times.
      
      Test Plan: Easily specified many of the most important times in a convenient way.
      
      Reviewers: btrahan, chad, lpriestley
      
      Reviewed By: lpriestley
      
      Subscribers: johnny-bit, eadler, epriestley
      
      Maniphest Tasks: T8024
      
      Differential Revision: https://secure.phabricator.com/D12674
      3ea7359e
    • epriestley's avatar
      Manage date control enabled state as part of DateControlValue · 948d6936
      epriestley authored
      Summary: Ref T8024. Allow `DateControlValue` to manage enabled/disabled state, so we can eventually delete the copy of this logic in `DateControl`.
      
      Test Plan:
        - Used Calendar ApplicationSearch queries to observe improved behaviors:
          - Error for invalid start date, if enabled.
          - Error for invalid end date, if enabled.
          - Error for invalid date range, if both enabled.
          - When submitting an invalid date (for example, with the time "Tea Time"), form retains invalid date verbatim instead of discarding information.
        - Created an event, using existing date controls to check that I didn't break anything.
      
      Reviewers: chad, lpriestley, btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T8024
      
      Differential Revision: https://secure.phabricator.com/D12673
      948d6936
    • epriestley's avatar
      Provide an "api" context to Multimeter for API events · ba6b1376
      epriestley authored
      Summary: Ref T6930. This gives us a better context for API calls -- "api.call.name" instead of always "web.ConduitAPIController".
      
      Test Plan: {F391658}
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T6930
      
      Differential Revision: https://secure.phabricator.com/D12677
      ba6b1376
    • epriestley's avatar
      Allow Multimeter samples to be grouped by ID · 77250cd5
      epriestley authored
      Summary: Ref T6930. This allows samples to be split apart even if they occurred in the same request.
      
      Test Plan: {F391657}
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T6930
      
      Differential Revision: https://secure.phabricator.com/D12676
      77250cd5
    • epriestley's avatar
      Support sampling subprocess execution in Multimeter · bee4dc7d
      epriestley authored
      Summary: Ref T6930. Add subprocess sampling/labeling.
      
      Test Plan:
      (This table includes some buggy test labels.)
      
      {F391655}
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T6930
      
      Differential Revision: https://secure.phabricator.com/D12675
      bee4dc7d
    • epriestley's avatar
      Compute average costs more correctly in Multimeter · e6e0df6a
      epriestley authored
      Summary: Ref T6930. We were dividing total cost by number of samples, but should more accurately divide it by the sum of the sample rates. This produces a more meaningful number.
      
      Test Plan: Saw a more meaningful number in the UI.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      Subscribers: epriestley
      
      Maniphest Tasks: T6930
      
      Differential Revision: https://secure.phabricator.com/D12655
      e6e0df6a
    • epriestley's avatar
      Don't add resources to Multimeter when there's no multimeter running · 1168a8c0
      epriestley authored
      Summary: Fixes T8058. Don't add a Multimeter event if we aren't running multimeter (e.g., in unit tests).
      
      Test Plan: Will `arc unit --everything`.
      
      Reviewers: joshuaspence, btrahan, chad
      
      Reviewed By: chad
      
      Subscribers: epriestley
      
      Maniphest Tasks: T8058
      
      Differential Revision: https://secure.phabricator.com/D12699
      1168a8c0
    • Joshua Spence's avatar
      Fix a few issues with the "import symbols" script · 1dfe1f49
      Joshua Spence authored
      Summary: Ref T7977. Fix a few issues that I forgot to fix up.
      
      Test Plan: Run the script.
      
      Reviewers: #blessed_reviewers, epriestley
      
      Reviewed By: #blessed_reviewers, epriestley
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T7977
      
      Differential Revision: https://secure.phabricator.com/D12668
      1dfe1f49
    • Joshua Spence's avatar
      Rename PhabricatorSearchEngine subclasses · 81d051db
      Joshua Spence authored
      Summary: Ref T5655. Rename `PhabricatorSearchEngine` subclasses for consistency.
      
      Test Plan: `arc unit`
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T5655
      
      Differential Revision: https://secure.phabricator.com/D12669
      81d051db
    • Joshua Spence's avatar
      Change default value for `bugtraq.url` · 791de088
      Joshua Spence authored
      Summary: `null` is a more-intuitive default value than `''`, methinks.
      
      Test Plan: Eyeball it.
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: Korvin, epriestley
      
      Differential Revision: https://secure.phabricator.com/D12671
      791de088
    • lkassianik's avatar
      Making the day view slightly less bad. · 6817e55e
      lkassianik authored
      Summary: Ref T4393, Making the day view slightly less bad.
      
      Test Plan: Open Calendar Advanced Search, search for day with multiple events starting at the same time, events should show up side by side, and should link to actual events.
      
      Reviewers: chad, #blessed_reviewers, epriestley
      
      Reviewed By: #blessed_reviewers, epriestley
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T4393
      
      Differential Revision: https://secure.phabricator.com/D12686
      6817e55e
  3. 03 May, 2015 7 commits
    • lkassianik's avatar
      First stab at day view · ee2af904
      lkassianik authored
      Summary: Ref T4393, First stab at day view.
      
      Test Plan: Open Calendar Advanced Search, select "Day View (beta)", see rough day view of selected day.
      
      Reviewers: chad, epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T4393
      
      Differential Revision: https://secure.phabricator.com/D12685
      ee2af904
    • epriestley's avatar
      Probably fix cross-origin font requests in IE · 1ab91954
      epriestley authored
      Summary: Ref T8013.
      
      Test Plan: no u
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Subscribers: epriestley
      
      Maniphest Tasks: T8013
      
      Differential Revision: https://secure.phabricator.com/D12684
      1ab91954
    • lkassianik's avatar
      Calendar event detail page should show host. · 15ebb814
      lkassianik authored
      Summary: Ref T8027, Calendar event deatil page should show host.
      
      Test Plan: Open calendar event, property list should include the host.
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T8027
      
      Differential Revision: https://secure.phabricator.com/D12683
      15ebb814
    • epriestley's avatar
      Update Celerity Packages · 4f5a0f23
      epriestley authored
      Summary: Ref T6930. Looked at Multimeter data and used it to adjust package definitions.
      
      Test Plan: Browsed around.
      
      Reviewers: btrahan, chad
      
      Reviewed By: chad
      
      Subscribers: epriestley
      
      Maniphest Tasks: T6930
      
      Differential Revision: https://secure.phabricator.com/D12672
      4f5a0f23
    • Joshua Spence's avatar
      Move symbols to be repository-based · 2483f6f1
      Joshua Spence authored
      Summary: Fixes T7220. Ref T7977. Changes symbols from being bound to an Arcanist project to being bound to a repository.
      
      Test Plan:
      - Added symbols and then applied migrations, symbols seemed to be migrated successfully.
      - Tested the `/diffusion/symbol/$SYMBOL_NAME` endpoint.
      - Tested the `/diffusion/symbol/$SYMBOL_NAME` endpoint with the `?repositories=$REPOSITORY_PHID` parameter.
      
      Reviewers: #blessed_reviewers, epriestley
      
      Reviewed By: #blessed_reviewers, epriestley
      
      Subscribers: avivey, Korvin, epriestley
      
      Maniphest Tasks: T7977, T7220
      
      Differential Revision: https://secure.phabricator.com/D12608
      2483f6f1
    • Joshua Spence's avatar
      Add "reopens" prefix · 38e89fbb
      Joshua Spence authored
      Summary: Ref T1751. Add a "reopens" prefix for the "open" status. This allows commits to reopen tasks.
      
      Test Plan: Pushed a commit containing `Reopens Tx` and saw `Tx` reopened.
      
      Reviewers: #blessed_reviewers, epriestley
      
      Reviewed By: #blessed_reviewers, epriestley
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T1751
      
      Differential Revision: https://secure.phabricator.com/D12652
      38e89fbb
    • Joshua Spence's avatar
      Remove unused ManiphestTaskOwner class · 44b17d0a
      Joshua Spence authored
      Summary: This class is unused after D12526.
      
      Test Plan: `grep`
      
      Reviewers: #blessed_reviewers, epriestley
      
      Reviewed By: #blessed_reviewers, epriestley
      
      Subscribers: Korvin, epriestley
      
      Differential Revision: https://secure.phabricator.com/D12562
      44b17d0a
  4. 02 May, 2015 4 commits
    • lkassianik's avatar
      Fix event pagination in month views · 0c1f367c
      lkassianik authored
      Summary: Closes T7927, Fix event pagination in month views.
      
      Test Plan: Querying for events in month view should display max that month's events and min the subset of days selected.
      
      Reviewers: #blessed_reviewers, epriestley
      
      Reviewed By: #blessed_reviewers, epriestley
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T7927
      
      Differential Revision: https://secure.phabricator.com/D12661
      0c1f367c
    • lkassianik's avatar
      Calendar event edit view should validate that start time preceeds end time · 25b1fb1d
      lkassianik authored
      Summary: Closes T8023, Calendar event edit view should validate that start time preceeds end time .
      
      Test Plan: Create Calendar event, add details, make end time be earlier than start time, try to save, get error, make sure all previously entered details are populated correctly.
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T8023
      
      Differential Revision: https://secure.phabricator.com/D12656
      25b1fb1d
    • lkassianik's avatar
      Expand ApplicationSearch on Calendar · 52a461a7
      lkassianik authored
      Summary: Ref T7927, Expand ApplicationSearch on Calendar
      
      Test Plan: Open Calendar application, month view should be a saved query.
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T7927
      
      Differential Revision: https://secure.phabricator.com/D12659
      52a461a7
    • Chad Little's avatar
      Tweak dialog header, mask color · 5b0aa498
      Chad Little authored
      Summary: A little more pop in the mask color (light to dark) and some more space in the dialog header.
      
      Test Plan: Visit dialogs on page and in actual dialogs.
      
      Reviewers: btrahan, epriestley
      
      Reviewed By: epriestley
      
      Subscribers: Korvin, epriestley
      
      Differential Revision: https://secure.phabricator.com/D12660
      5b0aa498