1. 12 Jan, 2017 1 commit
    • epriestley's avatar
      Provide bucketing for commits in Audit · a635da68
      epriestley authored
      Summary:
      Fixes T9430. Fixes T9362. Fixes T9544. This changes the default view of Audit to work like Differential, where commits you need to audit or respond to are shown in buckets.
      
      This is a bit messy and probably needs some followups. This stuff has changed from a compatibility viewpoint:
      
        - The query works differently now (but in a better, modern way), so existing saved queries will need to be updated.
        - I've removed the counters from the home page instead of updating them, since they're going to get wiped out by ProfileMenu soon anyway.
        - When bucketed queries return too many results (more than 1,000) we now show a warning about it. This isn't greaaaat but it seems good enough for now.
      
      Test Plan: {F2351123}
      
      Reviewers: chad
      
      Reviewed By: chad
      
      Maniphest Tasks: T9430, T9362, T9544
      
      Differential Revision: https://secure.phabricator.com/D17192
      a635da68
  2. 15 Jun, 2015 1 commit
    • Joshua Spence's avatar
      Extend from Phobject · b6d745b6
      Joshua Spence authored
      Summary: All classes should extend from some other class. See D13275 for some explanation.
      
      Test Plan: `arc unit`
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley, #blessed_reviewers
      
      Subscribers: epriestley, Korvin
      
      Differential Revision: https://secure.phabricator.com/D13283
      b6d745b6
  3. 13 May, 2015 1 commit
  4. 20 Oct, 2014 1 commit
    • Chad Little's avatar
      Normalize AuditStatusConstant Colors · eaf6ca3b
      Chad Little authored
      Summary: Ref T6345, This adds more consistent color choices to match how Phabricator generally works across Differential/Diffusion per user statuses.
      
      Test Plan: Review a few Audits in my sandbox.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: btrahan
      
      Subscribers: Korvin, epriestley
      
      Maniphest Tasks: T6345
      
      Differential Revision: https://secure.phabricator.com/D10726
      eaf6ca3b
  5. 07 Jan, 2014 1 commit
    • Bob Trahan's avatar
      Audit - tweak colors · db778cb3
      Bob Trahan authored
      Summary: See github issue 413. This diff adds color to the commit view as the user expects *AND* adds green to both audit and commit views. I looked in the history (D6184) and I can't tell how expected green was, but it feels nice to me given differential color coding.
      
      Test Plan: looked at lists of audits and commits with pretty colors.
      
      Reviewers: epriestley, chad
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7900
      db778cb3
  6. 12 Jun, 2013 1 commit
    • Chad Little's avatar
      Tweak audit status colors. · 4672705c
      Chad Little authored
      Summary: Fixes T3242. Changes the red and orange objects to match the transactions. Also adds a highlight color to 'cards'.
      
      Test Plan: Review my audits in my sandbox
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T3242
      
      Differential Revision: https://secure.phabricator.com/D6184
      4672705c
  7. 18 May, 2013 1 commit
    • Chad Little's avatar
      Modernize Audit · 84f21c8a
      Chad Little authored
      Summary: Adds mobile support to Audit, converts tables to object item views. I also colored 'concerns' and 'audit required' in the list, but nothing else. We can add more if needed but I'm assuming these are the two most important cases.
      
      Test Plan: Tested as much as I could, a little unsure of a few things since my local repo isn't super filled. Will let epriestley run through.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D5962
      84f21c8a
  8. 05 Nov, 2012 1 commit
    • vrana's avatar
      Delete license headers from files · ef85f49a
      vrana authored
      Summary:
      This commit doesn't change license of any file. It just makes the license implicit (inherited from LICENSE file in the root directory).
      
      We are removing the headers for these reasons:
      
      - It wastes space in editors, less code is visible in editor upon opening a file.
      - It brings noise to diff of the first change of any file every year.
      - It confuses Git file copy detection when creating small files.
      - We don't have an explicit license header in other files (JS, CSS, images, documentation).
      - Using license header in every file is not obligatory: http://www.apache.org/dev/apply-license.html#new.
      
      This change is approved by Alma Chao (Lead Open Source and IP Counsel at Facebook).
      
      Test Plan: Verified that the license survived only in LICENSE file and that it didn't modify externals.
      
      Reviewers: epriestley, davidrecordon
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T2035
      
      Differential Revision: https://secure.phabricator.com/D3886
      ef85f49a
  9. 01 Jun, 2012 1 commit
    • vrana's avatar
      Move files in Phabricator one level up · 6cc196a2
      vrana authored
      Summary:
      - `kill_init.php` said "Moving 1000 files" - I hope that this is not some limit in `FileFinder`.
      - [src/infrastructure/celerity] `git mv utils.php map.php; git mv api/utils.php api.php`
      - Comment `phutil_libraries` in `.arcconfig` and run `arc liberate`.
      
      NOTE: `arc diff` timed out so I'm pushing it without review.
      
      Test Plan:
      /D1234
      Browsed around, especially in `applications/repository/worker/commitchangeparser` and `applications/` in general.
      
      Auditors: epriestley
      
      Maniphest Tasks: T1103
      6cc196a2
  10. 23 Apr, 2012 1 commit
  11. 26 Mar, 2012 1 commit
    • epriestley's avatar
      Add "Resign from Audit" and "Close Audit" actions to Diffusion · 2044e512
      epriestley authored
      Summary:
      See some discussion in D2002. Add two new actions:
      
        - Resign: (auditor only) closes your open request (user request ONLY) by putting it in a "resigned" state.
        - Close: (author only) closes all open requests by putting them in a "closed" state.
      
      @davidreuss, this is probably conflict-city with D2002 -- I'll wait for you to land first and then handle the merge on my end.
      
      Test Plan: Resigned from and closed audits.
      
      Reviewers: 20after4, davidreuss, btrahan
      
      Reviewed By: btrahan
      
      CC: aran, epriestley
      
      Maniphest Tasks: T904
      
      Differential Revision: https://secure.phabricator.com/D2013
      2044e512
  12. 06 Mar, 2012 1 commit
    • epriestley's avatar
      Add an "Auditors" field to commit messages which pushes audit requests when present · a95c9873
      epriestley authored
      Summary:
      Adds an optional "Auditors" field (like "Reviewers") to commit messages which gives installs a zero-config method for making audit requests.
      
      This field does not appear on templates unless set, and is mostly ignored (but validated and preserved) by Differential.
      
      It is then parsed by the daemons if present, and audit requests are pushed to valid users.
      
      Test Plan: Made an "Auditors" commit and verified it was retained with "arc amend --show". Pushed it and verified the audit was triggered.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran, epriestley
      
      Maniphest Tasks: T904, T880
      
      Differential Revision: https://secure.phabricator.com/D1793
      a95c9873
  13. 24 Feb, 2012 1 commit
    • epriestley's avatar
      Add a basic first-class audit UI · 97ea6ea6
      epriestley authored
      Summary:
      Currently, audits are only accessible through the Owners tool. Start moving them
      to their own first-class tool in preparation for broader audit integration.
      
        - Lay some infrastructure groundwork (e.g. AuditQuery).
        - Build a basic /audit/ view.
        - Show audits on the commit page in Diffusion.
      
      This has some code duplication with stuff we've already got, but I'll merge
      everything together as we move forward on this.
      
      Test Plan: Looked at /audit/ and a commit.
      
      Reviewers: btrahan, jungejason
      
      Reviewed By: btrahan
      
      CC: aran, epriestley
      
      Maniphest Tasks: T904
      
      Differential Revision: https://secure.phabricator.com/D1685
      97ea6ea6
  14. 20 Dec, 2011 1 commit
    • jungejason's avatar
      Add Basic Auditing Functionalities · c80d1480
      jungejason authored
      Summary:
      add basic auditing functionalities. For the related commits for a
      package, we detect the following conditions which might be suspicious to the
      owners of the package:
      
      * no revision specified
      * revision not found
      * author not match
      * reviewedby not match
      * owners not involved
      * commit author not recognized
      
      The owners of the package can change the status of the audit entries by
      accepting it or specify concern.
      
      The owner can turn on/off the auditing for a package.
      
      Test Plan:
      *  verified that non-owner cannot see the details of the audit and cannot modify
      it
      *  verified that all the audit reasons can be detected
      *  tested dropdown filtering and package search
      *  verified really normal change not detected
      *  verified accept/concern a commit
      *  tested enable/disable a package for auditing
      *  verified one audit applies to all <commit, packages> to the packages the
      auditor owns
      *  verified that re-parsing a commit won't have effect if there exists a
       relationship for <commit, package> already
      
      Reviewers: epriestley, nh
      
      Reviewed By: epriestley
      
      CC: aran, benmathews, btrahan, mpodobnik, prithvi, TomL, epriestley
      
      Differential Revision: 1242
      c80d1480
  15. 17 Dec, 2011 1 commit
    • epriestley's avatar
      Allow Phriction documents to be deleted · afc2f852
      epriestley authored
      Summary:
        - Add a "delete" operation. Delete is just a special edit which removes the
      page from indexes and shows a notice that the document has been deleted.
        - When a user deletes all the content on a page, treat it as a delete.
        - When a conduit call deletes all the content on a page, treat it as a delete.
        - Add page status to Conduit.
        - Add change type field to history.
        - Added a couple of constants to support a future 'move' change, which would
      move content from one document to another.
      
      Test Plan:
        - Verified deleted pages vanish from the document index (and restoring them
      puts them back).
        - Verified deleted pages show "This page has been deleted...".
        - Created, edited and deleted a document via Conduit.
        - Deleted pages via "delete" button.
        - Deleted pages via editing content to nothing.
      
      Reviewers: btrahan, jungejason
      
      Reviewed By: btrahan
      
      CC: skrul, aran, btrahan, epriestley
      
      Maniphest Tasks: T680
      
      Differential Revision: 1230
      afc2f852
  16. 14 Sep, 2011 1 commit
  17. 12 Jul, 2011 1 commit
    • epriestley's avatar
      Publish Phriction edits to feed · f761ee91
      epriestley authored
      Summary: Basic integration between Phriction and feed.
      Test Plan: Created and edited some documents, they published to feed.
      Reviewed By: hsb
      Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran
      CC: aran, hsb
      Differential Revision: 653
      f761ee91
  18. 15 Mar, 2011 1 commit
  19. 07 Mar, 2011 1 commit
    • epriestley's avatar
      Rough cut of repository tracking · 57495c42
      epriestley authored
      Summary: Basic scaffolding for repository tracking, plus daemon infrastructure
      (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk).
      
      Test Plan: parsed Javelin git commit history via daemon
      
      Reviewers:
      
      CC:
      57495c42
  20. 23 Jan, 2011 1 commit
  21. 18 Jan, 2011 1 commit