1. 05 Aug, 2013 7 commits
    • epriestley's avatar
      Add a "document" style to PHUIRemarkupPreviewPanel and use it in Legalpad and Phriction · b712905d
      epriestley authored
      Summary: Ref T3671. Depends on D6674. Continues work in D6673, D6674 and extends it into Legalpad and Phriction. Then deletes a bunch of dead code.
      
      Test Plan: Edited documents in Legalpad and Phriction, verified I got reasonable looking previews.
      
      Reviewers: btrahan, Firehed
      
      Reviewed By: btrahan
      
      CC: aran, chad
      
      Maniphest Tasks: T3671
      
      Differential Revision: https://secure.phabricator.com/D6675
      b712905d
    • epriestley's avatar
      Use PHUIRemarkupPreviewPanel in Ponder · b2fa1293
      epriestley authored
      Summary:
      Ref T3578. Ref T3671. Depends on D6673. Use `PHUIRemarkupPreviewPanel` (introduced in D6673) to provide question create/edit and answer edit previews in Ponder.
      
      Then delete a million lines of duplicate code.
      
      Test Plan: Edited a question; edited an answer. Saw live previews.
      
      Reviewers: btrahan, Firehed
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T3578, T3671
      
      Differential Revision: https://secure.phabricator.com/D6674
      b2fa1293
    • epriestley's avatar
      Partially generalize Remarkup previews and add support to Differential · 193a9611
      epriestley authored
      Summary:
      Ref T3671. A lot of applications have pretty ad-hoc preview code. Clean it up a bit and add Summary preview to Differential.
      
      After ApplicationTransactions we might want to try to serialize the whole form and show a preview of all the transactions, but this seems not very useful in most cases (I'd guess that Remarkup previews are 99% of the value) and tricky to get right (e.g., adding images which don't exist yet to Pholio mocks).
      
      I think I can add this in a few other places, too.
      
      Test Plan:
      Edited Maniphest Tasks and Differential Revisions, mashed some buttons. Verified previews rendered correctly. Grepped for removed CSS classes (no hits).
      
      {F52907}
      
      Reviewers: btrahan, Firehed
      
      Reviewed By: btrahan
      
      CC: aran, chad
      
      Maniphest Tasks: T3671
      
      Differential Revision: https://secure.phabricator.com/D6673
      193a9611
    • epriestley's avatar
      Provide a more flexible script for administrative management of audits · 86989c9f
      epriestley authored
      Summary: Fixes T3679. This comes up every so often and the old script is extremely broad (nuke everything in a repository). Provide a more surgical tool.
      
      Test Plan: Ran a bunch of variations of the script and they all seemed to work OK.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran, staticshock
      
      Maniphest Tasks: T3679
      
      Differential Revision: https://secure.phabricator.com/D6678
      86989c9f
    • epriestley's avatar
      Fix Maniphest fatal if attached tasks are not an array · 02ccca4b
      epriestley authored
      Summary: Fixes T3678. I think some very old rows may have a junk value here. This will be obsoleted by ApplicationTransactions and other modernization, most likely, so just fix it locally.
      
      Test Plan: looked at a task
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T3678
      
      Differential Revision: https://secure.phabricator.com/D6677
      02ccca4b
    • Chad Little's avatar
      Re-implement one line stories. · 3fd2c0ff
      Chad Little authored
      Summary: This puts back the 'one line' story we previously had with the updated design.
      
      Test Plan: Review my feed.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D6666
      3fd2c0ff
    • Eric Stern's avatar
      Pass raw QUERY_STRING to parser · 44a883f9
      Eric Stern authored
      Summary:
      Fixes issue where double-encoding of $_SERVER occurs when php.ini forces all input to be sanitized
      
      Ex:
      filter.default = full_special_chars
      filter.default_flags = 36
      
      Fix line length
      
      Test Plan: Encountered issue on clean install when registring new user (phusr not defined for email verification). php.ini on that server contains above filter settings. nginx/php-fpm with recommended settings for that server block from setup guide.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, epriestley
      
      Differential Revision: https://secure.phabricator.com/D6672
      44a883f9
  2. 04 Aug, 2013 5 commits
  3. 02 Aug, 2013 4 commits
    • Bob Trahan's avatar
      Paste - add transactions · 37a5c4b1
      Bob Trahan authored
      Summary: Ref T3650. This adds a create transaction, transactions for metadata (title, langauge, view policy), and comments. Editor is used on all create /edit paths.
      
      Test Plan: made some pastes via web and email - yay. edited pastes - yay. verified txns showed up on pastes and in feed correctly.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T3516, T3650
      
      Differential Revision: https://secure.phabricator.com/D6645
      37a5c4b1
    • Chad Little's avatar
      Emoticons, Pack 1 · 4a4181ae
      Chad Little authored
      Summary: n/a
      
      Test Plan: photoshop, imageoptim
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D6661
      4a4181ae
    • Bob Trahan's avatar
      Fix a small bug - %d => %s · ee9830a9
      Bob Trahan authored
      Summary: easy peasy. noticed it trying to fix an image.
      
      Test Plan: can fix image by phid once more!
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D6659
      ee9830a9
    • epriestley's avatar
      Improve error message for bad timestamps · f0857e4f
      epriestley authored
      Summary: Ref T3031. While we should probably do more than this, provide a more useful error message so I don't have to make users run `date` and such.
      
      Test Plan:
      Added `|| true` and ran `arc list`:
      
        $ arc list --conduit-uri=http://local.aphront.com:8080/
        Exception
        ERR-INVALID-TOKEN: The request you submitted is signed with a timestamp, but that timestamp is not within 15 m of the current time. The signed timestamp is 1375454102 (Fri, 02 Aug 2013 07:35:02 -0700), and the current server time is 1375454102 (Fri, 02 Aug 2013 07:35:02 -0700). This is a differnce of 0 seconds, but the timestamps must differ from the server time by no more than 900 seconds. Your client or server clock may not be set correctly.
        (Run with --trace for a full exception trace.)
      
      Reviewers: btrahan, chad
      
      Reviewed By: chad
      
      CC: aran
      
      Maniphest Tasks: T3031
      
      Differential Revision: https://secure.phabricator.com/D6653
      f0857e4f
  4. 01 Aug, 2013 5 commits
    • Jakub Vrana's avatar
      Use filtered query instead of filter in Elasticsearch · 6c7f36f6
      Jakub Vrana authored
      Summary:
      The 'filter' works like this: Get all results matching query (all if there's no query), compute facets (if there are any) and then filter out the uninteresting results.
      The 'filtered' query applies the filters when searching, not when processing results.
      This is obviously not documented anywhere in the great Elasticsearch documentation.
      http://stackoverflow.com/questions/14007078/performance-of-elastic-queries
      
      We don't hit this problem very often as we usually use some query.
      
      Test Plan: Searched for open documents using Elasticsearch, verified the sent JSON, verified results.
      
      Reviewers: epriestley, wez
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D6643
      6c7f36f6
    • Chad Little's avatar
      Add one-line feed story. · 78f73e7d
      Chad Little authored
      Summary: It turns out not everything is interesting. This adds a oneline story with less vertical space.
      
      Test Plan: UIExamples
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D6640
      78f73e7d
    • epriestley's avatar
      Restore setting "disabled" on user handles of disabled users · fd2593e8
      epriestley authored
      Summary:
      Fixes T3666. D6585 updated the User handles, but accidentally dropped this unusual property.
      
      We should get rid of this -- it doesn't really make any sense on Handles -- but restore the previous beahvior to fix T3666 until we can nuke it.
      
      Test Plan: Clicked some pages? (Actually testing this properly is a bit of a pain and I am super lazy.)
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T3666
      
      Differential Revision: https://secure.phabricator.com/D6644
      fd2593e8
    • Bob Trahan's avatar
      Pholio - finish off history view · 1663dc32
      Bob Trahan authored
      Summary:
      ...bsasically add a "view mode" and play with that throughout the stack. Differences are...
      
       - normal mode has comments; history mode does not
       - normal mode has inline comments; history mode does not
       - page uris are correct with respect to either mode
      
       ...and that's about it. I played around (wasted too much time) trying to make this cuter. I think just jamming this mode in here is the easiest / cleanest thing at the end. Feel free to tell me otherwise!
      
      This largely gets even better via T3612. However, this fixes T3572.
      
      Test Plan: played around with a mock with some history. noted correct uris on images. noted no errors in js console.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T3572
      
      Differential Revision: https://secure.phabricator.com/D6638
      1663dc32
    • epriestley's avatar
      Publish create object stories into Asana sort of, but not really · 75e56cb2
      epriestley authored
      Summary: Ref T2852. Current code works fine, but although we want to drop creation stories, we really only want to drop the story text, not the other effects of the creation story. Also generalize this mechanism so we don't have Asana-specific code in the publishers.
      
      Test Plan: Used `bin/feed republish` to publish creation and non-creation stories. Verified creation story published no text.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T2852
      
      Differential Revision: https://secure.phabricator.com/D6639
      75e56cb2
  5. 30 Jul, 2013 7 commits
  6. 29 Jul, 2013 12 commits