1. 14 Jan, 2014 7 commits
    • epriestley's avatar
      Separate session management from PhabricatorUser · eef314b7
      epriestley authored
      Summary: Ref T4310. Ref T3720. Session operations are currently part of PhabricatorUser. This is more tightly coupled than needbe, and makes it difficult to establish login sessions for non-users. Move all the session management code to a `SessionEngine`.
      
      Test Plan:
        - Viewed sessions.
        - Regenerated Conduit certificate.
        - Verified Conduit sessions were destroyed.
        - Logged out.
        - Logged in.
        - Ran conduit commands.
        - Viewed sessions again.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T4310, T3720
      
      Differential Revision: https://secure.phabricator.com/D7962
      eef314b7
    • Chad Little's avatar
      Icons for TagView · c8d1d063
      Chad Little authored
      Summary: Adds the ability to set icons into Tags.
      
      Test Plan: tested on UIExamples page.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7961
      c8d1d063
    • epriestley's avatar
      Add an "active login sessions" table to Settings · 3d9e328f
      epriestley authored
      Summary: Ref T4310. Ref T3720. Partly, this makes it easier for users to understand login sessions. Partly, it makes it easier for me to make changes to login sessions for T4310 / T3720 without messing anything up.
      
      Test Plan: {F101512}
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T3720, T4310
      
      Differential Revision: https://secure.phabricator.com/D7954
      3d9e328f
    • epriestley's avatar
      Allow PhabricatorUserLog to store non-user PHIDs · 220d680f
      epriestley authored
      Summary:
      Ref T4310. This is a small step toward separating out the session code so we can establish sessions for `ExternalAccount` and not just `User`.
      
      Also fix an issue with strict MySQL and un-admin / un-disable from web UI.
      
      Test Plan: Logged in, logged out, admined/de-admin'd user, added email address, checked user log for all those events.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T4310
      
      Differential Revision: https://secure.phabricator.com/D7953
      220d680f
    • Chad Little's avatar
      Shorten Jump Nav box to more standard size · 49963d8e
      Chad Little authored
      Summary: just a little nip/tuck, facebook will surely rejoice.
      
      Test Plan: reload html, see new css
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7956
      49963d8e
    • Peng Li's avatar
      Add dependencies to releeph · 60a6ba2b
      Peng Li authored
      Summary: Add the 'Depends On' field to releeph requests. This will help the release engineers to be aware of the dependencies and make sure pick them altogether.
      
      Test Plan: Check sandbox. This field shows up when a revision has some dependencies.
      
      Reviewers: JoelB, lifeihuang, epriestley, #blessed_reviewers
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7946
      60a6ba2b
    • epriestley's avatar
      Fix Herald field type error · 6cc5f952
      epriestley authored
      Summary: See IRC. This is a likely fix for @DctrWatson's error: we're returning `null` but should return `array()` to indicate no values.
      
      Test Plan: Will make @DctrWatson do it.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: dctrwatson, aran
      
      Differential Revision: https://secure.phabricator.com/D7950
      6cc5f952
  2. 13 Jan, 2014 15 commits
    • epriestley's avatar
      Fix exception for new error stuff in Conduit · 3fc807be
      epriestley authored
      Summary: This might be `null`.
      
      Test Plan: Loaded, got exception, applied patch, no exception. Viewed a method with an actual message too, that also worked.
      
      Reviewers: chad, btrahan
      
      Reviewed By: chad
      
      CC: aran
      
      Differential Revision: https://secure.phabricator.com/D7955
      3fc807be
    • epriestley's avatar
      Fix fatal on project boards with no tasks · 8a7429b8
      epriestley authored
      Summary: Ref T1344. We try to do a bad edge query with no sources right now if there are no tasks in a project.
      
      Test Plan:
        - Hit exception, applied patch, no exception.
        - Other boards still have tasks.
      
      Reviewers: btrahan, chad
      
      Reviewed By: chad
      
      CC: aran
      
      Maniphest Tasks: T1344
      
      Differential Revision: https://secure.phabricator.com/D7951
      8a7429b8
    • epriestley's avatar
      Show current board for tasks in Maniphest · f5741003
      epriestley authored
      Summary:
      Ref T1344. When rendering a task's projects, add "(Board)" afterward if the task is on a non-default board.
      
      This is mostly a "get the data there" change, we can probably make the design nicer.
      
      Test Plan: {F101232}
      
      Reviewers: chad, btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T1344
      
      Differential Revision: https://secure.phabricator.com/D7945
      f5741003
    • epriestley's avatar
      Persist column membership after tasks are dragged around · bc9326ad
      epriestley authored
      Summary: Ref T1344. Write edges and read them when reloading the board.
      
      Test Plan: After reload, stuff stays mostly where I put it. In-column order isn't always persisted correctly yet.
      
      Reviewers: chad, btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T1344
      
      Differential Revision: https://secure.phabricator.com/D7944
      bc9326ad
    • epriestley's avatar
      Send appropriate requests to the server when dragging cards on project boards · 35d37df4
      epriestley authored
      Summary: Ref T1344. Makes requests to the server, which are received and ignored. Performs appropriate locking/unlocking/enabling/disabling on the client.
      
      Test Plan: Dragged stuff around, saw it enable/disable/send correctly.
      
      Reviewers: chad, btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T1344
      
      Differential Revision: https://secure.phabricator.com/D7943
      35d37df4
    • epriestley's avatar
      Make the rest of the board drag-and-drop UI mostly work · a101b4ba
      epriestley authored
      Summary:
      Ref T1344. Makes the UI/UX a little nicer; still no actual backend stuff. This changes:
      
        - When you drop an item onto a different column, the item actually moves.
        - Empty columns render with a special CSS class now, but no nodes in the list. This cleans up some JS jankiness. I made the "empty" columns have a light blue background for now. We could put some sort of subtle background image in them instead, or some kind of call to action if it's not redundant with other UI.
      
      Test Plan: {F101208}
      
      Reviewers: chad, btrahan
      
      Reviewed By: chad
      
      CC: chad, aran
      
      Maniphest Tasks: T1344
      
      Differential Revision: https://secure.phabricator.com/D7942
      a101b4ba
    • epriestley's avatar
      Allow tasks to be dragged-and-dropped between workboard columns (UI only) · 826914e9
      epriestley authored
      Summary:
      Ref T1344. Allows you to drag tasks within a column and between columns, and handles all the multi-column state / targeting / ghosting stuff.
      
      This is a UI-only change; you can't actually do anything meaningful with these yet.
      
      Roughly, I added the idea of a DraggableList existing within a "group" of draggable lists. Normally, that group only has one item, but on boards it has all of the columns. Then I made all of the relevant operations just apply to the whole group of lists.
      
      Test Plan:
        - Verified existing funtionality in Maniphest and ApplicationSearch is unaffected, by dragging around tasks to reprioritize them and dragging around search items.
        - Dragged tasks between columns on a board view.
      
      {F101196}
      
      Reviewers: chad, btrahan
      
      Reviewed By: btrahan
      
      CC: chad, aran
      
      Maniphest Tasks: T1344
      
      Differential Revision: https://secure.phabricator.com/D7941
      826914e9
    • epriestley's avatar
      Make Workboard and Workpanel views extend AphrontTagView · 284465f6
      epriestley authored
      Summary: Ref T1344. I need to put sigils on these for drag-and-drop.
      
      Test Plan: Renders the same. Put sigils on 'em.
      
      Reviewers: chad, btrahan
      
      Reviewed By: chad
      
      CC: aran
      
      Maniphest Tasks: T1344
      
      Differential Revision: https://secure.phabricator.com/D7940
      284465f6
    • epriestley's avatar
      Fix two bugs with DraggableList · 7ffddcd1
      epriestley authored
      Summary:
      Ref T1344. This fixes two issues with DraggableList:
      
        - In lists which allowed it, you could drag the top item above itself and get a dashed-border ghost item. This didn't make sense and didn't behave well. Just don't treat this operation as valid.
        - In lists which allowed it, you could drag any non-top item to the topmost position, then drag it to an invalid position. The dashed-border ghost item would not be removed properly if this happend.
        - Also fix some minor leftovers with Celerity.
      
      Test Plan:
        - Dragged the first item above itself; now an invalid operation with no ghost.
        - Dragged another item to the first position then back to its original position; ghost vanishes.
        - Clean lint.
      
      Reviewers: chad, btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T1344
      
      Differential Revision: https://secure.phabricator.com/D7939
      7ffddcd1
    • epriestley's avatar
      Improve several exception behaviors for Harbormaster workers · 996930da
      epriestley authored
      Summary:
      Ref T2015. Several fixes:
      
        - `checkForCancellation()` no longer exists, and isn't relevant for resumable stops. Throw it away for now.
        - Fix an issue where a build could pass even if the final step failed.
        - `phlog()` exceptions so they show up in `bin/harbormaster` and the daemon logs.
        - Write an exception log if a step fails.
        - Add a "throw an exception" step to debug this stuff more easily.
      
      Test Plan:
        - Grepped for `checkForCancellation()`.
        - Ran a failing build where the final step caused the failure.
        - Observed `phlog()` in `bin/harbormaster` output.
        - Observed log in web UI:
      
      {F101168}
      
      Reviewers: btrahan, hach-que
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T2015
      
      Differential Revision: https://secure.phabricator.com/D7935
      996930da
    • Chad Little's avatar
      Clean up diff view page · 51d8570b
      Chad Little authored
      Summary: Cleans up some older layouts to new stuffs.
      
      Test Plan: Test with and without a diff ID.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7949
      51d8570b
    • Chad Little's avatar
      Tighten CSS spacing in PHUIObjectListViewy · 5f08216a
      Chad Little authored
      Summary: Who doesn't like tighter CSS! Evens up the spacing top and bottom when in a phui-object-box
      
      Test Plan: External Accounts.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7948
      5f08216a
    • epriestley's avatar
      Generate a default "Backlog" column for boards and put all tasks into it · a751073d
      epriestley authored
      Summary:
      Ref T1344. Autogenerates a "Backlog" column if one does not exist. Assigns all tasks to the backlog column.
      
      For now, this column is always called "Backlog", but we could let it be called other things later.
      
      Test Plan: Loaded a project, got a backlog column, created some columns.
      
      Reviewers: btrahan, chad
      
      Reviewed By: chad
      
      CC: aran
      
      Maniphest Tasks: T1344
      
      Differential Revision: https://secure.phabricator.com/D7938
      a751073d
    • epriestley's avatar
      Straighten out some crumbs and links for workboards · 3f180496
      epriestley authored
      Summary: Ref T1344. Minor tweaks for crumb/link stuff -- @mikn has been doing some work here recently and I want to unblock him.
      
      Test Plan: Viewed board; viewed column edit screen.
      
      Reviewers: chad, btrahan
      
      Reviewed By: chad
      
      CC: mikn, aran
      
      Maniphest Tasks: T1344
      
      Differential Revision: https://secure.phabricator.com/D7937
      3f180496
    • Chad Little's avatar
      Fix colors, spacing on list filters · 06d12bf5
      Chad Little authored
      Summary: so pixels, much color
      
      Test Plan: reload audit/home, things are more aligneded
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7947
      06d12bf5
  3. 12 Jan, 2014 2 commits
  4. 10 Jan, 2014 5 commits
    • Chad Little's avatar
      Update Conpherence Panel saved · 240ec9a8
      Chad Little authored
      Summary: Use the new helper methods.
      
      Test Plan: Loaded up Conpherence Prefs, clicked save.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: btrahan
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7929
      240ec9a8
    • epriestley's avatar
      Mark answers as page objects in Ponder · 306ef5ea
      epriestley authored
      Summary:
      Fixes T4306. We should clear notifications about a question and its answers when viewing a question page.
      
      (Eventually we might have an answer detail page and send the notification there, and then only clear there, but this cleans things up for now.)
      
      Test Plan: Loaded question page, verified answers appeared as page objects.
      
      Reviewers: chad, btrahan
      
      Reviewed By: chad
      
      CC: aran
      
      Maniphest Tasks: T4306
      
      Differential Revision: https://secure.phabricator.com/D7928
      306ef5ea
    • Chad Little's avatar
      Simplify PHUIObjectBoxViews handling of Save and Error states · b74c7a3d
      Chad Little authored
      Summary: This removes the bulk of the "Form Errors" text, some variations likely exists. These are a bit redundant and space consuming. I'd also like to back ErrorView more into PHUIObjectBox.
      
      Test Plan: Test out the forms, see errors without the text.
      
      Reviewers: epriestley, btrahan
      
      CC: Korvin, epriestley, aran, hach-que
      
      Differential Revision: https://secure.phabricator.com/D7924
      b74c7a3d
    • John Watson's avatar
      Add Hosted/Remote filtering to Diffusion · 2ee45074
      John Watson authored
      Test Plan: Did searches in Diffusion using all 3 Hosted values
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7927
      2ee45074
    • Mikael Knutsson's avatar
      Adding the create flow for Project Board (Workphlow) columns. · 5417f91b
      Mikael Knutsson authored
      Summary: This adds in the create flow for the Project board columns on the super secret board page which totally doesn't do anything right now.
      
      Test Plan:
      1. Apply diff.
      2. Go to super secret page.
      3. Click link close to top with a way too long name.
      4. Enter a name for the column.
      5. Enjoy a new column briefly before realising you cannot remove it.
      6. Stay happy!
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley
      
      CC: tmaroschik, Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7925
      5417f91b
  5. 09 Jan, 2014 10 commits
    • epriestley's avatar
      Support "Repository's projects" field in Commit and Differential Revision rules · efe187d5
      epriestley authored
      Summary: This also cleans up some code a little bit. Most of the gymnastics are to make sure we call `needProjectPHIDs()` appropriately.
      
      Test Plan: Created new commit and revision rules with this field. Ran commits and revisions through the test console. Field behavior seemed correct.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran, dctrwatson
      
      Differential Revision: https://secure.phabricator.com/D7923
      efe187d5
    • epriestley's avatar
      Add transactions to Drydock blueprint editing · c0208373
      epriestley authored
      Summary: Ref T2015. Fixes TODO.
      
      Test Plan: {F100338}
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T2015
      
      Differential Revision: https://secure.phabricator.com/D7922
      c0208373
    • epriestley's avatar
      Add Drydock default edit/view policies and a "Create Blueprint" policy · 44892043
      epriestley authored
      Summary: Ref T2015. Allow configuration of default edit/view policies for blueprints. Add create policy. Remove administrative exception in policies.
      
      Test Plan: Configured these settings and created (or, with a restrictive create setting, tried to create) blueprints.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T2015
      
      Differential Revision: https://secure.phabricator.com/D7921
      44892043
    • epriestley's avatar
      Add names to Drydock blueprints · 962aca66
      epriestley authored
      Summary:
      Ref T2015. Adds human-readable names to Drydock blueprints.
      
      Also the new patches stuff is so much nicer.
      
      Test Plan: Edited, created, and reviewed migrated blueprints.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T2015
      
      Differential Revision: https://secure.phabricator.com/D7918
      962aca66
    • epriestley's avatar
      Fix two edge case issues with Differential mail tags · 68de6394
      epriestley authored
      Summary:
      Via Asana. The tags on Differential mail are wrong in two cases:
      
        - Transactions which submit inline comments but no comment text are not labeled as "comments", but should be.
        - Non-close, non-comment transactions are not labeled at all, but should be labeled "other".
      
      Test Plan: Submitted a no-comments, inlines-only transaction and got a message with proper `X-Phabricator-Mail-Tags` header.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Differential Revision: https://secure.phabricator.com/D7912
      68de6394
    • John Mullanaphy's avatar
      Changed \$callsign to \$argv[1] on commit_hook.php since is undefined causing... · b960c811
      John Mullanaphy authored
      Changed \$callsign to \$argv[1] on commit_hook.php since  is undefined causing an error when trying to report an error.
      
      Summary:
      Phabricator was going to give me an error message via commit_hook.php, unfortunately said error wasn't being set since
      \$callsign was undefined. So, just changed \$callsign to \$argv[1] and now I get the appropriate commit.
      
      Test Plan:
      1. Add commit_hook.php to an SVN pre-commit.
      2. Set the SVN to be hosted off of Phabricator.
      3. Attempt to commit to commit to SVN repository.
      Expected: Error message saying that the repository isn't hosted on Phabricator
      Results: Error message saying undefined function.
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7920
      b960c811
    • Chad Little's avatar
      Clean up AphrontError boxes, Diffusion Headers · 3c5756ad
      Chad Little authored
      Summary: Two basic changes here, first we fixed up the Diffusion headers to roll out more PHUIObjectBoxes. Second we added some specific styles for when Errors are inside an ObjectBox at the first position.
      
      Test Plan: Tested a number of different layouts for browsing respositories as well as wherever I could find cases with PHUIObjectBox Form Errors (see images attached). Still some minor tightening due after this diff, but didnt want to overload it.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7914
      3c5756ad
    • John Watson's avatar
      Add a 'silent' option to diffusion.createcomment · 6639f931
      John Watson authored
      Test Plan: Created comments with 'silent' both true and empty, received notifcation for only the latter.
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7916
      6639f931
    • Chad Little's avatar
      Fix Cards list in External Accounts · 982e0d78
      Chad Little authored
      Summary: Minor, sets the list to flush to invoke the correct CSS for the ObjectBox.
      
      Test Plan: Reload Page
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: btrahan
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7909
      982e0d78
    • Mikael Knutsson's avatar
      Adding in an edit icon on the action header · a5db959f
      Mikael Knutsson authored
      Summary: Test flight on Phabricator editing! I mostly looked at other code, thought it was well written and wrote my own code in the other code's image.
      
      Test Plan: Look at icons appearing!
      
      Reviewers: epriestley, #blessed_reviewers
      
      Reviewed By: epriestley
      
      CC: Korvin, epriestley, aran
      
      Differential Revision: https://secure.phabricator.com/D7911
      a5db959f
  6. 08 Jan, 2014 1 commit