1. 26 Aug, 2013 1 commit
    • Chad Little's avatar
      Update Form Layouts · fe2a96e3
      Chad Little authored
      Summary:
      This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere.
      
      TODO: will take another pass as consolidating these colors and new gradients in another diff.
      
      Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: Korvin, aran
      
      Differential Revision: https://secure.phabricator.com/D6806
      fe2a96e3
  2. 20 Aug, 2013 1 commit
  3. 05 Aug, 2013 1 commit
  4. 28 Jul, 2013 1 commit
  5. 02 Jun, 2013 1 commit
  6. 07 May, 2013 1 commit
    • Chad Little's avatar
      Update form styles, implement in many places · 43ff24b0
      Chad Little authored
      Summary:
      This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things:
      
      - Font Styles are correctly applied for form elements now.
      - Everything lines up!
      - Selects are larger, easier to read, interact.
      - Inputs have been squared.
      - Consistant CSS applied glow (try it!)
      - Improved Mobile Responsiveness
      - CSS applied to all form elements, not just Aphront
      - Many other minor tweaks.
      
      I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try.
      
      Test Plan: Tested many applications, forms, mobile and tablet.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D5860
      43ff24b0
  7. 11 Apr, 2013 1 commit
    • Chad Little's avatar
      Phriction Redesign · 7b9b872b
      Chad Little authored
      Summary: This is mostly minor, but visually it makes the wiki feel more 'page like' and better separates the actual content from other data displayed.
      
      Test Plan: Tested Chrome, iPhone, and iPad.
      
      Reviewers: epriestley, btrahan
      
      Reviewed By: epriestley
      
      CC: aran, Korvin, AnhNhan
      
      Maniphest Tasks: T2686
      
      Differential Revision: https://secure.phabricator.com/D5366
      7b9b872b
  8. 13 Feb, 2013 2 commits
  9. 12 Feb, 2013 1 commit
    • vrana's avatar
      Fix some HTML problems · 868ca714
      vrana authored
      Summary: I'm too lazy to attaching them for diffs where they were introduced.
      
      Test Plan:
      /
      /D1, wrote comment with code snippet
      DarkConsole
      commit detail, wrote comment
      task detail, wrote comment
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T2432
      
      Differential Revision: https://secure.phabricator.com/D4911
      868ca714
  10. 09 Feb, 2013 2 commits
  11. 08 Feb, 2013 3 commits
  12. 25 Jan, 2013 2 commits
    • Vedha Sayyaparaju's avatar
      T2385: Add "Delete Document" action to Phriction pages · cf346d3c
      Vedha Sayyaparaju authored
      Summary: If a page has not been deleted, this adds an action button to delete the document in the menu on the Phriction Page.
      
      Test Plan:
      1. Created a document, checked whether "Delete Document" button was visible.
      2. Clicked on "Delete Document" button, checked that the document had been deleted.
      3. Went back to document page, checked that the "Delete Document" button no longer existed.
      
      Reviewers: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T2385
      
      Differential Revision: https://secure.phabricator.com/D4636
      cf346d3c
    • vrana's avatar
      Convert phutil_render_tag(X, Y, '...') to phutil_tag · 20768d65
      vrana authored
      Summary:
      Created with spatch:
      
        lang=diff
        - phutil_render_tag
        + phutil_tag
          (X, Y, '...')
      
      Then searched for `&` and `<` in the output and replaced them.
      
      Test Plan: Loaded homepage.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D4503
      20768d65
  13. 27 Nov, 2012 1 commit
  14. 15 Nov, 2012 1 commit
    • Ricky Elrod's avatar
      Don't show the delete button on a deleted document · 7fac80cb
      Ricky Elrod authored
      Summary:
      This doesn't actually contain any logic to prevent a user from deleting a
      document twice, but it makes it significantly harder to do so.
      
      Test Plan:
      Went to edit a document, saw the delete button. Clicked it, then went back to
      the edit view, and no longer saw the delete button.
      
      Reviewers: epriestley
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Differential Revision: https://secure.phabricator.com/D3952
      7fac80cb
  15. 05 Nov, 2012 1 commit
    • vrana's avatar
      Delete license headers from files · ef85f49a
      vrana authored
      Summary:
      This commit doesn't change license of any file. It just makes the license implicit (inherited from LICENSE file in the root directory).
      
      We are removing the headers for these reasons:
      
      - It wastes space in editors, less code is visible in editor upon opening a file.
      - It brings noise to diff of the first change of any file every year.
      - It confuses Git file copy detection when creating small files.
      - We don't have an explicit license header in other files (JS, CSS, images, documentation).
      - Using license header in every file is not obligatory: http://www.apache.org/dev/apply-license.html#new.
      
      This change is approved by Alma Chao (Lead Open Source and IP Counsel at Facebook).
      
      Test Plan: Verified that the license survived only in LICENSE file and that it didn't modify externals.
      
      Reviewers: epriestley, davidrecordon
      
      Reviewed By: epriestley
      
      CC: aran, Korvin
      
      Maniphest Tasks: T2035
      
      Differential Revision: https://secure.phabricator.com/D3886
      ef85f49a
  16. 17 Oct, 2012 1 commit
    • epriestley's avatar
      Raise a better error for trying to create an empty document in Phriction · 09151b50
      epriestley authored
      Summary:
      When you delete the content of a document in Phriction, we treat it as an attempt to delete the document.
      
      In the case you're creating the document, we hit an exception trying to delete a document which doesn't exist yet.
      
      Detect this case and raise a better error.
      
      Test Plan: Tried to create an empty document, got a good error. Created a nonempty document. Edited a document to empty to delete it.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran
      
      Maniphest Tasks: T1920
      
      Differential Revision: https://secure.phabricator.com/D3728
      09151b50
  17. 10 Oct, 2012 1 commit
  18. 08 Oct, 2012 1 commit
  19. 19 Sep, 2012 1 commit
  20. 16 Jul, 2012 1 commit
    • epriestley's avatar
      When users submit a no-op edit in Phriction, don't update the document · 8fd97f43
      epriestley authored
      Summary:
      See T1501. When users mash "save", stop them if they didn't change anything.
      
      Also, don't default-fill the "edit notes" field with the previous notes. This is meant to be more like a commit message for your changes.
      
      Test Plan: Edited a document with no changes, got a dialog. Edited a document with a title change only and a description change only, things worked. Edited a document with a previous "Edit notes", got a blank default fill.
      
      Reviewers: alanh, btrahan, vrana
      
      Reviewed By: vrana
      
      CC: aran
      
      Maniphest Tasks: T1501
      
      Differential Revision: https://secure.phabricator.com/D2978
      8fd97f43
  21. 01 Jun, 2012 1 commit
    • vrana's avatar
      Move files in Phabricator one level up · 6cc196a2
      vrana authored
      Summary:
      - `kill_init.php` said "Moving 1000 files" - I hope that this is not some limit in `FileFinder`.
      - [src/infrastructure/celerity] `git mv utils.php map.php; git mv api/utils.php api.php`
      - Comment `phutil_libraries` in `.arcconfig` and run `arc liberate`.
      
      NOTE: `arc diff` timed out so I'm pushing it without review.
      
      Test Plan:
      /D1234
      Browsed around, especially in `applications/repository/worker/commitchangeparser` and `applications/` in general.
      
      Auditors: epriestley
      
      Maniphest Tasks: T1103
      6cc196a2
  22. 20 May, 2012 1 commit
    • Bob Trahan's avatar
      Phriction - lock down /project/ wiki docs · a9000ea2
      Bob Trahan authored
      Summary:
      only show the blank, "create new" wiki page for the project if the project actually exists; only allow edit if the project actually exists.
      Small wrinkle here is not checking if the project actually exists if the page already exists.
      
      Test Plan:
      - viewed a project wiki page
      - viewed a prokect wiki page for a fake project and got a 404
      - edited a project wiki page
      - edited a project wiki page for a fake project and got a 404
      
      Reviewers: epriestley, jacktrades
      
      Reviewed By: epriestley
      
      CC: aran, Koolvin
      
      Maniphest Tasks: T1248
      
      Differential Revision: https://secure.phabricator.com/D2506
      a9000ea2
  23. 10 Apr, 2012 1 commit
  24. 09 Mar, 2012 1 commit
    • epriestley's avatar
      Add "final" to all Phabricator "Controller" classes · b2890eeb
      epriestley authored
      Summary:
      These are all unambiguously unextensible. Issues I hit:
      
        - Maniphest Change/Diff controllers, just consolidated them.
        - Some search controllers incorrectly extend from "Search" but should extend from "SearchBase". This has no runtime effects.
        - D1836 introduced a closure, which we don't handle correctly (somewhat on purpose; we target PHP 5.2). See T962.
      
      Test Plan: Ran "testEverythingImplemented" unit test to identify classes extending from `final` classes. Resolved issues.
      
      Reviewers: btrahan
      
      Reviewed By: btrahan
      
      CC: aran, epriestley
      
      Maniphest Tasks: T795
      
      Differential Revision: https://secure.phabricator.com/D1843
      b2890eeb
  25. 13 Jan, 2012 1 commit
    • epriestley's avatar
      Add basic draft support to Phriction · f5e1e337
      epriestley authored
      Summary:
        - When a user is creating a Phriction document, save a draft as
      "phriction:<slug>".
        - When a user is editing a Phriction document, save a draft as "<document
      phid>:<document version>".
        - If a user has an available draft, use that instead of the native content.
        - If using a draft, tell the user and give them an option to discard it.
        - If a page is updated, your draft is lost (we show new page content
      unconditionally) but this should be rare and is the simplest way to resolve this
      issue in a realtively consistent way.
      
      Test Plan:
        - Recovered drafts for new and edited pages.
        - Used "nodraft" to discard drafts.
      
      Reviewers: davidreuss, btrahan, jungejason
      
      Reviewed By: davidreuss
      
      CC: aran, davidreuss
      
      Maniphest Tasks: T769
      
      Differential Revision: https://secure.phabricator.com/D1378
      f5e1e337
  26. 17 Dec, 2011 1 commit
    • epriestley's avatar
      Allow Phriction documents to be deleted · afc2f852
      epriestley authored
      Summary:
        - Add a "delete" operation. Delete is just a special edit which removes the
      page from indexes and shows a notice that the document has been deleted.
        - When a user deletes all the content on a page, treat it as a delete.
        - When a conduit call deletes all the content on a page, treat it as a delete.
        - Add page status to Conduit.
        - Add change type field to history.
        - Added a couple of constants to support a future 'move' change, which would
      move content from one document to another.
      
      Test Plan:
        - Verified deleted pages vanish from the document index (and restoring them
      puts them back).
        - Verified deleted pages show "This page has been deleted...".
        - Created, edited and deleted a document via Conduit.
        - Deleted pages via "delete" button.
        - Deleted pages via editing content to nothing.
      
      Reviewers: btrahan, jungejason
      
      Reviewed By: btrahan
      
      CC: skrul, aran, btrahan, epriestley
      
      Maniphest Tasks: T680
      
      Differential Revision: 1230
      afc2f852
  27. 07 Dec, 2011 1 commit
    • epriestley's avatar
      Add "tabindex" to Remarkup reference lists · d13906ff
      epriestley authored
      Summary:
      Prevent keyboard focus of these links so we don't disrupt tab order from
      comments to "Submit".
      
      Arguably I should make a "function" for this or something but there's nowhere to
      really put it that makes any sense right now.
      
      Test Plan: Verified Firefox skips these links in tab order.
      
      Reviewers: fratrik, btrahan, jungejason
      
      Reviewed By: fratrik
      
      CC: aran, fratrik
      
      Maniphest Tasks: T661
      
      Differential Revision: 1180
      d13906ff
  28. 14 Sep, 2011 1 commit
  29. 31 Aug, 2011 1 commit
  30. 30 Aug, 2011 1 commit
    • epriestley's avatar
      Provide access to Phriction via Conduit · 701bf831
      epriestley authored
      Summary:
      Provide three Phriction methods for programmatic access to Phriction:
      
        - phriction.info: get information about a document
        - phriction.history: get change history for a document
        - phriction.edit: create or update a document
      
      I moved all the editing/creation logic into a new PhrictionDocumentEditor to
      share code between the Conduit and Web edit pathways.
      
      Test Plan: Got info and history via conduit. Edited and created new pages via
      conduit and web.
      
      Reviewers: hsb, jungejason, tuomaspelkonen, aran, hunterbridges
      
      Reviewed By: hunterbridges
      
      CC: skrul, aran, hunterbridges
      
      Differential Revision: 866
      701bf831
  31. 01 Aug, 2011 1 commit
    • epriestley's avatar
      Rough implementation of drag-and-drop file uploads · 9d3f33a7
      epriestley authored
      Summary:
      This gets all the major pieces working. Allows you to drag-and-drop files in
      Differential and Phriction, and embed files in remarkup with {Fxxx} references.
      See also task.
      
      I'm explicitly not documenting this yet since it's still pretty rough.
      
      Test Plan: Dragged and dropped stuff into Differential and Phriction.
      Reviewed By: jungejason
      Reviewers: jungejason, tuomaspelkonen, aran, tomo
      Commenters: tomo
      CC: aran, tomo, jungejason
      Differential Revision: 674
      9d3f33a7
  32. 24 Jul, 2011 1 commit
    • Hua Wang's avatar
      Add a 'description' field to Phriction · 2a894438
      Hua Wang authored
      Summary:
      Add a new column to PhrictionContent called 'comment' or 'description' or
      something
              Add an optional field to the Phriction document editing interface that
      allows you to add a comment
      
      Test Plan:
      Run the sql patch to modify phriction_content table
                 Create a new wiki page in Phriction
                 Type in words in description field and save the page
                 Visit this page and click "Edit Page" button
                 The content in the desciption field is saved
      
      Reviewed By: epriestley
      Reviewers: epriestley, hsb, codeblock
      Commenters: codeblock
      CC: aran, codeblock, hwang, epriestley
      Differential Revision: 709
      2a894438
  33. 18 Jul, 2011 1 commit
    • epriestley's avatar
      Show change diffs in Phriction · c0ae2f62
      epriestley authored
      Summary:
      This is really rough and needs work (particularly, there's some diff code I
      really need to refactor since I sort-of-copy-pasted it) but basically
      functional.
      
      Show text changes between diffs and allow users to revert to earlier versions.
      
      Differential's line-oriented diff style isn't ideal for large blocks of text but
      I'm betting this is probably good enough in most cases. We can see how bad it is
      in practice and then fix it if needbe.
      
      I added a bunch of support for "description" but didn't add the feature in this
      diff, I'll either follow up or task it out since it should be a pretty
      straightforward change.
      
      Test Plan: Looked at history for several Phriction documents, clicked "previous
      change" / "next change", clicked revert buttons.
      Reviewed By: hsb
      Reviewers: hsb, codeblock, jungejason, tuomaspelkonen
      CC: aran, hsb, epriestley
      Differential Revision: 687
      c0ae2f62
  34. 17 Jul, 2011 1 commit
    • epriestley's avatar
      Add a document preview to Phriction · 4a3ebd9a
      epriestley authored
      Summary: Preview Phriction documents as they are edited, similar to how
      Differential/Maniphest work.
      Test Plan: Mashed my keyboard while editing a Phriction document.
      Reviewed By: hsb
      Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran
      CC: aran, hsb
      Differential Revision: 684
      4a3ebd9a
  35. 15 Jul, 2011 1 commit
    • epriestley's avatar
      Add a cancel button to Phriction's edit interface · ffb69c3c
      epriestley authored
      Summary: So you don't have to edit if you don't want to.
      Test Plan: Hit "cancel" on an edit of an existing page and an edit of a new
      page.
      Reviewed By: codeblock
      Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran
      CC: aran, codeblock
      Differential Revision: 675
      ffb69c3c