Commit 152ac5fa authored by Marek Vasut's avatar Marek Vasut Committed by Andreas Bießmann
Browse files

gpio: at91: Fix pullup/pulldown configuration on PIO3

On systems with PIO3 (SAMA5D3/D4/..), the pullup and pulldown configuration
is mutualy exclusive. This patch assures that the opposite pull resistor gets
disabled before the requested pull resistor is enabled. This changes behavior
of at91_set_pio_pulldown() such that the pullup is only disabled if pulldown
is to be enabled. This changes behavior of at91_set_pio_pullup() such that
the pulldown is only disabled if pullup is to be enabled.

Signed-off-by: default avatarMarek Vasut <>
Cc: Andreas Bießmann <>
Cc: Josh Wu <>
Cc: Simon Glass <>
Reviewed-by: default avatarAndreas Bießmann <>
parent 6b3943f1
......@@ -59,6 +59,11 @@ int at91_set_pio_pullup(unsigned port, unsigned pin, int use_pullup)
struct at91_port *at91_port = at91_pio_get_port(port);
#if defined(CPU_HAS_PIO3)
if (use_pullup)
at91_set_pio_pulldown(port, pin, 0);
if (at91_port && (pin < GPIO_PER_BANK))
at91_set_port_pullup(at91_port, pin, use_pullup);
......@@ -305,10 +310,10 @@ int at91_set_pio_pulldown(unsigned port, unsigned pin, int is_on)
if (at91_port && (pin < GPIO_PER_BANK)) {
mask = 1 << pin;
writel(mask, &at91_port->pudr);
if (is_on)
if (is_on) {
at91_set_pio_pullup(port, pin, 0);
writel(mask, &at91_port->ppder);
} else
writel(mask, &at91_port->ppddr);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment