Commit 9e0bf839 authored by Jacopo Mondi's avatar Jacopo Mondi Committed by Mauro Carvalho Chehab
Browse files

media: i2c: max9271: Introduce wake_up() function



The MAX9271 chip manual prescribes a delay of 5 milliseconds
after the chip exits from low power state.

Add a new function to the max9271 library driver that wakes up the chip
with a dummy i2c transaction and implements the correct delay of 5
milliseconds after the chip exits from low power state.

Use the newly introduced function in the rdacm20 and rdacm21 camera
drivers. The former was not respecting the required delay while the
latter was waiting for a too-short timeout.
Signed-off-by: default avatarJacopo Mondi <jacopo+renesas@jmondi.org>
Reviewed-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent ad01032a
......@@ -80,6 +80,18 @@ static int max9271_pclk_detect(struct max9271_device *dev)
return -EIO;
}
void max9271_wake_up(struct max9271_device *dev)
{
/*
* Use the chip default address as this function has to be called
* before any other one.
*/
dev->client->addr = MAX9271_DEFAULT_ADDR;
i2c_smbus_read_byte(dev->client);
usleep_range(5000, 8000);
}
EXPORT_SYMBOL_GPL(max9271_wake_up);
int max9271_set_serial_link(struct max9271_device *dev, bool enable)
{
int ret;
......
......@@ -85,6 +85,15 @@ struct max9271_device {
struct i2c_client *client;
};
/**
* max9271_wake_up() - Wake up the serializer by issuing an i2c transaction
* @dev: The max9271 device
*
* This function shall be called before any other interaction with the
* serializer.
*/
void max9271_wake_up(struct max9271_device *dev);
/**
* max9271_set_serial_link() - Enable/disable serial link
* @dev: The max9271 device
......
......@@ -455,9 +455,7 @@ static int rdacm20_initialize(struct rdacm20_device *dev)
unsigned int retry = 3;
int ret;
/* Verify communication with the MAX9271: ping to wakeup. */
dev->serializer->client->addr = MAX9271_DEFAULT_ADDR;
i2c_smbus_read_byte(dev->serializer->client);
max9271_wake_up(dev->serializer);
/* Serial link disabled during config as it needs a valid pixel clock. */
ret = max9271_set_serial_link(dev->serializer, false);
......
......@@ -450,10 +450,7 @@ static int rdacm21_initialize(struct rdacm21_device *dev)
{
int ret;
/* Verify communication with the MAX9271: ping to wakeup. */
dev->serializer.client->addr = MAX9271_DEFAULT_ADDR;
i2c_smbus_read_byte(dev->serializer.client);
usleep_range(3000, 5000);
max9271_wake_up(&dev->serializer);
/* Enable reverse channel and disable the serial link. */
ret = max9271_set_serial_link(&dev->serializer, false);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment