Skip to content
  • Manfred Spraul's avatar
    ipc/util.c: use binary search for max_idx · b869d5be
    Manfred Spraul authored
    If semctl(), msgctl() and shmctl() are called with IPC_INFO, SEM_INFO,
    MSG_INFO or SHM_INFO, then the return value is the index of the highest
    used index in the kernel's internal array recording information about all
    SysV objects of the requested type for the current namespace.  (This
    information can be used with repeated ..._STAT or ..._STAT_ANY operations
    to obtain information about all SysV objects on the system.)
    
    There is a cache for this value.  But when the cache needs up be updated,
    then the highest used index is determined by looping over all possible
    values.  With the introduction of IPCMNI_EXTEND_SHIFT, this could be a
    loop over 16 million entries.  And due to /proc/sys/kernel/*next_id, the
    index values do not need to be consecutive.
    
    With <write 16000000 to msg_next_id>, msgget(), msgctl(,IPC_RMID) in a
    loop, I have observed a performance increase of around factor 13000.
    
    As there is no get_last() function for idr structures: Implement a
    "get_last()" using a binary search.
    
    As far as I see, ipc is the only user that needs get_last(), thus
    implement it in ipc/util.c and not in a central location.
    
    [akpm@linux-foundation.org: tweak comment, fix typo]
    
    Link: https://lkml.kernel.org/r/20210425075208.11777-2-manfred@colorfullife.com
    
    
    Signed-off-by: default avatarManfred Spraul <manfred@colorfullife.com>
    Acked-by: default avatarDavidlohr Bueso <dbueso@suse.de>
    Cc: <1vier1@web.de>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    b869d5be