ChangeLog 1.09 MB
Newer Older
1
2
3
4
5
2007-02-07  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/audioconvert/gstaudioconvert.c:
	  Fix up docs chunk so that gtk-doc doesn't complain, and fix typo.

6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
2007-02-06  Julien MOUTTE  <julien@moutte.net>

	* sys/xvimage/xvimagesink.c: (gst_xvimagesink_handle_xevents),
	(gst_xvimagesink_get_xv_support), (gst_xvimagesink_xcontext_clear),
	(gst_xvimagesink_interface_supported),
	(gst_xvimagesink_probe_get_properties),
	(gst_xvimagesink_probe_probe_property),
	(gst_xvimagesink_probe_needs_probe),
	(gst_xvimagesink_probe_get_values),
	(gst_xvimagesink_property_probe_interface_init),
	(gst_xvimagesink_set_property), (gst_xvimagesink_get_property),
	(gst_xvimagesink_init), (gst_xvimagesink_class_init),
	(gst_xvimagesink_get_type):
	* sys/xvimage/xvimagesink.h: Implement PropertyProbe Interface
	for XVAdaptors so that one can choose the adaptor to use with 
	gstreamer-properties.

23
24
25
26
27
2007-02-06  Stefan Kost  <ensonic@users.sf.net>

	* gst/audioconvert/gstaudioconvert.c:
	  Also mention that a conversion from double to float is suboptimal still.

28
29
30
31
32
33
34
2007-02-06  Tim-Philipp Müller  <tim at centricular dot net>

	* gst-libs/gst/audio/gstaudiofilter.c:
	(gst_audio_filter_class_init), (gst_audio_filter_change_state):
	  Clear our formats structure and free the caps contained in it when
	  shutting down.

35
36
37
38
39
40
41
2007-02-05  Andy Wingo  <wingo@pobox.com>

	* gst-libs/gst/audio/gstbaseaudiosink.c
	(gst_base_audio_sink_callback): Update basesink->offset so that we
	pull monotonically increasing offsets instead of, um, seeking back
	to 0 each time. Fixes alsasrc ! alsasink!

42
43
44
45
46
47
2007-02-05  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/videoscale/gstvideoscale.c:
	  A width and height of 1 makes us crash, so increase minimum size to
	  2x2 pixels until someone feels like fixing this (#404512).

48
49
50
51
52
53
2007-02-04  Tim-Philipp Müller  <tim at centricular dot net>

	* tests/check/pipelines/oggmux.c: (GST_START_TEST), (oggmux_suite):
	  Add small test to make sure request pads are cleaned up properly
	  even if oggmux never changes state out of NULL.

54
55
56
57
58
59
2007-02-04  Tim-Philipp Müller  <tim at centricular dot net>

	* tests/check/libs/utils.c: (GST_START_TEST):
	  Fix unit test. Turns out things work much better when you
	  NULL-terminate string arrays. Should make p5 build bot happy again.

60
61
62
63
64
65
66
67
68
69
70
71
72
73
2007-02-03  Tim-Philipp Müller  <tim at centricular dot net>

	* gst-libs/gst/audio/Makefile.am:
	* gst-libs/gst/audio/gstaudiofiltertemplate.c:
	(gst_audio_filter_template_base_init),
	(gst_audio_filter_template_class_init),
	(gst_audio_filter_template_init),
	(gst_audio_filter_template_set_property),
	(gst_audio_filter_template_get_property),
	(gst_audio_filter_template_setup),
	(gst_audio_filter_template_filter),
	(gst_audio_filter_template_filter_inplace), (plugin_init):
	  Oops, forgot to commit fixed-up example.

74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
2007-02-03  Tim-Philipp Müller  <tim at centricular dot net>

	* docs/libs/gst-plugins-base-libs-sections.txt:
	* gst-libs/gst/audio/gstaudiofilter.c: (gst_audio_filter_get_type),
	(gst_audio_filter_class_init), (gst_audio_filter_init),
	(gst_audio_filter_set_caps),
	(gst_audio_filter_class_add_pad_templates):
	* gst-libs/gst/audio/gstaudiofilter.h:
	  Port GstAudioFilter to 0.10. This change technically breaks
	  API and ABI (and thus also every library developer's heart),
	  but seems justifiable on the grounds that the base class was
	  completely unusable before (ie. would crash immediately when
	  actually used). Fixes #403963 (and eventually also #403572).
	  Also document all of this a bit.

89
90
91
92
93
94
95
96
97
2007-02-03  Tim-Philipp Müller  <tim at centricular dot net>

	* gst-libs/gst/utils/install-plugins.c:
	(gst_install_plugins_spawn_child):
	* tests/check/libs/utils.c:
	(test_base_utils_install_plugins_do_callout):
	  Lowering log level to see why things fail on the p5 build bot;
	  fix some typos in unit test messages.

98
99
100
101
102
103
104
2007-02-03  Tim-Philipp Müller  <tim at centricular dot net>

	* tests/check/libs/utils.c:
	(test_base_utils_install_plugins_do_callout):
	  Don't hard-code temp directory for test helper; use GLib functions
	  to write out file and do error checking etc.

105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
2007-02-02  Tim-Philipp Müller  <tim at centricular dot net>

	* gst-libs/gst/utils/Makefile.am:
	* gst-libs/gst/utils/base-utils.h:
	* gst-libs/gst/utils/install-plugins.c:
	(gst_install_plugins_context_set_xid),
	(gst_install_plugins_context_new),
	(gst_install_plugins_context_free),
	(gst_install_plugins_get_helper),
	(gst_install_plugins_spawn_child),
	(gst_install_plugins_return_from_status),
	(gst_install_plugins_installer_exited),
	(gst_install_plugins_async), (gst_install_plugins_sync),
	(gst_install_plugins_return_get_name),
	(gst_install_plugins_installation_in_progress):
	* gst-libs/gst/utils/install-plugins.h:
	  API: add API for applications to initiate installation of missing
	  plugins, ie. gst_install_plugins_async() primarily.
	  Based on libgimme-codec by Ryan Lortie.

	* configure.ac:
	  Add --with-install-plugins-helper configure option so distros can specify
	  the path of the helper script or program to call when plugin installation
	  is requested (distros: please do any argument munging in this helper
	  script instead of patching GStreamer to pass arguments differently
	  to another program directly).

	* docs/libs/gst-plugins-base-libs-docs.sgml:
	* docs/libs/gst-plugins-base-libs-sections.txt:
	  Build and document new API.

	* tests/check/libs/utils.c: (result_cb),
	(test_base_utils_install_plugins_do_callout), (GST_START_TEST),
	(libgstbaseutils_suite):
	  Some simple checks for the new API.

141
142
143
144
145
146
2007-02-02  Tim-Philipp Müller  <tim at centricular dot net>

	* tests/check/elements/audioconvert.c: (test_float_conversion):
	  Add small test for 32bit float <=> 64bit float conversion (works
	  only one way so far, 32=>64 produces structured noise).

147
>>>>>>> 1.3137
148
149
150
151
152
153
2007-02-02  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/audioconvert/gstaudioconvert.c:
	(set_structure_widths_32_and_64), (make_lossless_changes):
	  We don't support floats with a width of 40, 48 or 56 bits.

154
155
156
157
158
159
160
161
2007-02-02  Stefan Kost  <ensonic@users.sf.net>

	* gst/audioconvert/audioconvert.c: (float), (double),
	(audio_convert_get_func_index):
	* gst/audioconvert/gstaudioconvert.c: (set_structure_widths),
	(make_lossless_changes):
	  Support for 64-bit float audio in audioconvert (#339837)

162
163
164
165
166
167
168
169
2007-02-01  Tim-Philipp Müller  <tim at centricular dot net>

	Patch by: Holger Wansing  <linux wansing-online de>

	* po/LINGUAS:
	* po/de.po:
	  Add German translation (#352069).

170
171
172
173
174
175
176
177
178
2007-02-01  Sebastian Dröge  <slomo@circular-chaos.org>

	reviewed by: Wim Taymans <wim@fluendo.com>

	* ext/ogg/gstoggmux.c: (gst_ogg_mux_ogg_pad_destroy_notify),
	(gst_ogg_mux_request_new_pad), (gst_ogg_mux_release_pad):
	Use newly added GstCollectPads API to free the allocated resources in
	the GstOggPad structures (#402393).

179
180
181
182
183
184
185
186
187
2007-01-31  Jan Schmidt  <thaytan@mad.scientist.com>

	* gst/playback/gstplaybin.c: (gen_vis_element):
	  Add audioresample+audioconvert in front of the visualisation
	  element, so that elements like libvisual 0.4 that don't support all
	  samplerates can work.

	  Fixes: #402505

188
189
190
191
192
193
194
195
2007-01-30  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/gstplaybasebin.c: (gst_play_base_bin_get_property),
	(gst_play_base_bin_get_streaminfo_value_array):
	  Take some locks and make a copy of the streaminfo value array we
	  maintain while holding the lock, so that the application can
	  retrieve the stream-info as a value array in a thread-safe way.

196
197
198
199
200
2007-01-30  Wim Taymans  <wim@fluendo.com>

	* gst/audioconvert/gstaudioconvert.c:
	Don't fail on 0 sized buffers. Fixes #396835.

201
202
203
204
205
206
2007-01-29  David Schleef  <ds@schleef.org>

	* gst/typefind/gsttypefindfunctions.c:
	  Detect BBCD as video/x-dirac, so we can play raw dirac
	  streams.

207
208
209
210
211
212
213
214
2007-01-29  Tim-Philipp Müller  <tim at centricular dot net>

	* ext/theora/theoraenc.c: (theora_enc_chain):
	  Check return value of theora_encode_header(), or we might try to
	  allocate a random number of bytes. theora_encode_header() can fail
	  if libtheora has been compiled with encoding support disabled.
	  Fixes #398110.

215
216
217
218
219
2007-01-29  Wim Taymans  <wim@fluendo.com>

	* tests/check/gst/.cvsignore:
	Do as buildbot says.

220
221
222
223
224
225
226
227
2007-01-29  Wim Taymans  <wim@fluendo.com>

	* ext/libvisual/visual.c: (gst_visual_src_setcaps):
	Fix strides in libvisual. Gst uses X strides.
	Inspired by: <ed at catmur dot co dot uk> and 
	<tim at centricular dot net>
	Fixes #401118.

228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
2007-01-27  Wim Taymans  <wim@fluendo.com>

	* ext/ogg/gstoggdemux.c: (gst_ogg_demux_submit_buffer),
	(gst_ogg_demux_get_data), (gst_ogg_demux_get_next_page),
	(gst_ogg_demux_get_prev_page), (gst_ogg_demux_do_seek),
	(gst_ogg_demux_perform_seek),
	(gst_ogg_demux_bisect_forward_serialno),
	(gst_ogg_demux_read_chain), (gst_ogg_demux_read_end_chain),
	(gst_ogg_demux_find_chains), (gst_ogg_demux_handle_page),
	(gst_ogg_demux_chain), (gst_ogg_demux_combine_flows),
	(gst_ogg_demux_loop_reverse), (gst_ogg_demux_loop):
	* ext/ogg/gstoggdemux.h:
	Properly propagate streaming errors when we are scanning the file for
	chains so that we don't crash when shut down. Might fix some crashers
	when quickly switching oggs in RB such as #332503 and #378436.

244
245
246
247
248
249
2007-01-26  Tim-Philipp Müller  <tim at centricular dot net>

	* ext/gnomevfs/gstgnomevfssrc.c: (gst_gnome_vfs_src_start):
	  Map a gnome-vfs HOST_NOT_FOUND error into a GStreamer NOT_FOUND
	  error code as well.

250
251
252
253
254
2007-01-25  Wim Taymans  <wim@fluendo.com>

	* gst/playback/gstplaybasebin.c: (remove_source):
	Don't try to disconnect a signal from a finalized object.

255
256
257
258
259
260
261
2007-01-25  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/gstdecodebin2.c: (gst_decode_bin_dispose):
	  Cast lock macro parameters to make sure we're actually accessing the
	  lock member at the right class level. Free list itself in _dispose()
	  as well and NULL it in case dispose gets called multiple times.

262
263
264
265
266
267
268
269
270
271
272
2007-01-25  Edward Hervey  <edward@fluendo.com>

	* gst/playback/gstdecodebin2.c:
	(gst_decode_bin_dispose),(gst_decode_bin_finalize):
	Free GstDecodeGroups no longer used.
	(gst_decode_group_expose):
	Don't unlock too many times !
	(deactivate_free_recursive):
	Free iterator once we're done with it.
	Fix for recursively deactivating elements (stop at ghostpads).

273
274
275
276
277
278
279
2007-01-25  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/gstplaybin.c: (handoff):
	  Fix up caps on the frame buffer before we save it and potentially
	  make it accessible to other threads via g_object_get; also use
	  gst_buffer_replace() instead of gst_mini_object_replace().

280
281
282
283
284
2007-01-25  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/gstplaybin.c: (gst_play_bin_get_property):
	  Make getting the current frame thread-safe.

285
286
287
288
289
290
291
2007-01-25  Edward Hervey  <edward@fluendo.com>

	* gst/playback/gstdecodebin2.c: (gst_decode_bin_finalize),
	(gst_decode_group_new), (gst_decode_group_free):
	Set queues to bigger sizes to cope with HD contents.
	Fix some mutex freeing and add comment about MT safe methods.

292
293
294
295
296
297
298
299
300
301
2007-01-24  Tim-Philipp Müller  <tim at centricular dot net>

	* ext/pango/gsttextoverlay.c: (gst_text_overlay_src_event),
	(gst_text_overlay_text_event):
	  Don't unnecessarily ref (and then leak) upstream events if the text
	  pad is not linked. Fixes #399948.

	* tests/check/gst-plugins-base.supp:
	  Add suppression for pango on edgy/x86 for textoverlay test.

302
303
304
305
306
2007-01-24  Wim Taymans  <wim@fluendo.com>

	* gst-libs/gst/rtp/gstrtpbuffer.h:
	Add some more fixed payloads.

307
308
309
310
311
312
2007-01-23  Tim-Philipp Müller  <tim at centricular dot net>

	* ext/ogg/gstoggdemux.c: (gst_ogg_demux_read_chain):
	  Error out properly if we get an error from libogg while reading the
	  BOS page(s). Fixes crash parsing 'fuzzed' ogg file (#399340).

313
314
315
316
317
318
319
320
321
322
323
324
325
326
2007-01-23  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/gstdecodebin2.c: (gst_decode_bin_finalize):
	  Don't leak mutex.

	* tests/check/elements/playbin.c:
	(test_sink_usage_video_only_stream),
	(test_suburi_error_unknowntype), (test_suburi_error_invalidfile),
	(test_suburi_error_wrongproto), (test_missing_urisource_handler),
	(test_missing_suburisource_handler),
	(test_missing_primary_decoder), (playbin_suite):
	  Run all tests once with decodebin and once with decodebin2.
	  One test does not pass yet with decodebin2.

327
328
329
330
331
332
333
334
2007-01-23  Edward Hervey  <edward@fluendo.com>

	* ext/ogg/gstoggmux.c: (all_pads_eos), (gst_ogg_mux_collected):
	Fix the cases where oggmux doesn't properly figure out that all
	sinkpads have gone EOS, and therefore doesn't push out the remaining
	buffers and the final EOS event.
	Fixes #363379

335
336
337
338
339
340
341
2007-01-23  Julien MOUTTE  <julien@moutte.net>

	* sys/ximage/ximagesink.c: (gst_ximagesink_handle_xevents):
	* sys/xvimage/xvimagesink.c: (gst_xvimagesink_handle_xevents):
	Don't lock on navigation event push, just on keysym to string.
	Fixes #397673 again.

342
343
344
345
346
347
348
349
350
351
352
2007-01-22  Edward Hervey  <edward@fluendo.com>

	* gst/playback/gstdecodebin2.c: (gst_decode_group_new),
	(get_current_group), (group_demuxer_event_probe),
	(gst_decode_group_expose), (deactivate_free_recursive),
	(gst_decode_group_free):
	Cleanups.
	Don't forget to emit 'no-more-pads' once a group is exposed.
	Cleanup elements from a DecodeGroup once we remove it.
	Protect call to gst_decode_group_expose() with the decodebin lock.

353
354
355
356
357
358
359
360
2007-01-22  Julien MOUTTE  <julien@moutte.net>

	* sys/ximage/ximagesink.c: (gst_ximagesink_handle_xevents):
	* sys/xvimage/xvimagesink.c: (gst_xvimagesink_handle_xevents):
	Looking at Xorg code i can't figure out if that XKeysymToString
	function is thread sensible or not. Lock it just in case as
	recommended by Radek Doulik <rodo at ximian dot com>.

361
362
363
364
365
366
2007-01-22  Julien MOUTTE  <julien@moutte.net>

	* sys/ximage/ximagesink.c: (gst_ximagesink_handle_xevents):
	* sys/xvimage/xvimagesink.c: (gst_xvimagesink_handle_xevents):
	Lock that X Call as well. Fixes #397673.

367
368
369
370
371
372
373
374
375
376
377
378
2007-01-22  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/typefind/gsttypefindfunctions.c: (mpeg4_video_type_find):
	  Don't go into an endless loop if the file starts with 00 00 01 2X,
	  like quicktime redirect files might. Fixes #396042.

	* tests/check/Makefile.am:
	* tests/check/gst/.cvsignore:
	* tests/check/gst/typefindfunctions.c: (GST_START_TEST),
	(typefindfunctions_suite):
	  Add unit test for the above.

379
380
381
382
383
2007-01-22  Tim-Philipp Müller  <tim at centricular dot net>

	* gst-libs/gst/riff/riff-media.c: (gst_riff_create_video_caps):
	  On second thought, use "depth" field rather than "bpp" field.

384
385
386
387
388
2007-01-22  Tim-Philipp Müller  <tim at centricular dot net>

	* gst-libs/gst/riff/riff-media.c: (gst_riff_create_video_caps):
	  Camtasia caps apparently need a bpp field (#398875).

389
390
391
392
393
394
395
396
397
398
399
400
401
402
2007-01-19  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/gstplaybasebin.c: (setup_subtitle),
	(gen_source_element), (gst_play_base_bin_change_state):
	  Attempt at a better error message in case we don't have the required
	  URI handler installed; post missing-plugin message also when we're
	  missing an URI handler for the subtitle URI; clean up properly also
	  when an error occurs and we never made it to PAUSED state.

	* tests/check/elements/playbin.c: (GST_START_TEST),
	(playbin_suite):
	  Check that we're also getting a missing-plugin messsage for a
	  missing subtitle URI handler (and clean up properly).

403
404
405
406
407
2007-01-19  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/gstplaybasebin.c: (analyse_source), (setup_source):
	  Plug a few reference leaks.

408
409
410
411
412
413
2007-01-19  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/typefind/gsttypefindfunctions.c: (mpeg2_sys_type_find):
	  Lower probability a bit if the marker isn't right at the start,
	  to decrease the chance of false positives.

414
415
416
417
418
419
420
2007-01-19  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/typefind/gsttypefindfunctions.c: (mpeg2_sys_type_find):
	  Small mpeg2 system stream typefinding improvement: make typefinder
	  probe a bit into the stream instead of just looking for a marker
	  at the beginning. Fixes #397810.

421
422
423
424
425
2007-01-18  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/audioconvert/gstchannelmix.c:
	  Remove compatibility cruft for prehistoric GLib versions.

426
427
428
429
430
431
432
433
434
435
436
437
438
2007-01-17  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/Makefile.am:
	* gst/playback/gstdecodebin.c: (close_pad_link):
	* gst/playback/gstdecodebin2.c: (analyze_new_pad):
	* gst/playback/gstplaybasebin.c: (gst_play_base_bin_class_init),
	(gst_play_base_bin_handle_message_func), (unknown_type):
	  Let decodebin be the element to post missing-plugin messages for
	  missing decoders (rather than playbin); make playbin implement
	  GstBin::handle_message so we can suppress missing-plugin messages
	  for types we're not handling on purpose (don't want to bring up an
	  installer in those cases).

439
440
441
442
443
444
445
446
2007-01-16  Tim-Philipp Müller  <tim at centricular dot net>

	* gst-libs/gst/riff/riff-media.c: (gst_riff_create_video_caps):
	* gst-libs/gst/tag/gstvorbistag.c:
	(gst_tag_list_to_vorbiscomment_buffer):
	* gst/typefind/gsttypefindfunctions.c: (vorbis_type_find):
	  Fix potentially unaligned access (#397207).

447
448
449
450
451
452
453
454
455
2007-01-16  Stefan Kost  <ensonic@users.sf.net>

	* tests/examples/seek/seek.c: (set_scale), (update_scale),
	(do_seek), (stop_seek), (pause_cb), (stop_cb), (loop_toggle_cb),
	(rate_spinbutton_changed_cb), (msg_eos), (msg_segment_done),
	(main):
	  Allow to toggle looping while it plays. Fix callback prototype. Clean
	  up code a bit more. Add copyright header.

456
457
458
459
460
2007-01-16  Stefan Kost  <ensonic@users.sf.net>

	* sys/xvimage/xvimagesink.c: (gst_xvimagesink_get_xv_support):
	  Red and blue mask was swapped (spotted by Dan Williams).

461
462
463
464
465
466
2007-01-15  Stefan Kost  <ensonic@users.sf.net>

	* gst-libs/gst/tag/gstid3tag.c:
	* gst-libs/gst/tag/gstvorbistag.c:
	  Use new beats-per-minute tag from core.

467
468
469
470
471
472
2007-01-15  Tim-Philipp Müller  <tim at centricular dot net>

	* po/POTFILES.in:
	  Add new files with translatable strings, so they actually make it
	  into the template file one day.

473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
2007-01-12  Andy Wingo  <wingo@pobox.com>

	* gst-libs/gst/audio/gstbaseaudiosink.c
	(gst_base_audio_sink_fixate): Implement, stolen from baseaudiosrc.
	(gst_base_audio_sink_activate_pull): Remove the handwavey nego
	stuff, as the base class handles this now. Actually tell the ring
	buffer to start.
	(gst_base_audio_sink_callback): Cast the ring buffer correctly.
	How did this work before? Maybe I'm not as awesome a programmer as
	I think.

	* gst-libs/gst/audio/gstbaseaudiosrc.c
	(gst_base_audio_src_fixate): Rework as a basesrc vmethod instead
	of a pad function.

488
489
490
491
492
493
2007-01-12  Tim-Philipp Müller  <tim at centricular dot net>

	* gst-libs/gst/utils/missing-plugins.c: (copy_and_clean_caps):
	  Remove more fields so that the application can better blacklist
	  formats that have been tried before.

494
495
496
497
498
499
2007-01-12  Tim-Philipp Müller  <tim at centricular dot net>

	* gst-libs/gst/audio/mixerutils.h:
	  Add G_BEGIN_DECLS and G_END_DECLS guards so these helpers can be
	  used when compiling with c++ compilers as well.

500
501
502
503
504
2007-01-12  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/typefind/gsttypefindfunctions.c:
	  Fix comment.

505
506
507
508
509
510
511
512
2007-01-11  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/gstplaybin.c: (post_missing_element_message),
	(gen_video_element), (gen_text_element), (gen_audio_element),
	(gen_vis_element):
	  Post missing-plugin messages also when we error out because
	  converters, textoverlay or auto*sinks are missing (#161922).

513
514
515
516
517
518
519
520
521
522
2007-01-10  Wim Taymans  <wim@fluendo.com>

	* gst/playback/gstdecodebin.c: (dynamic_add), (close_pad_link),
	(is_demuxer_element), (new_caps):
	* gst/playback/gstplaybasebin.c: (source_new_pad):
	Fix the case where we try to ref a NULL element when we delay a link
	because of unfixed caps.
	Set the state of autoplugged decodebins to PAUSED.
	RTSP now works in playbin, we can remove it from the blacklist.

523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
2007-01-09  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/Makefile.am:
	* gst/playback/gstplaybasebin.c: (string_arr_has_str),
	(unknown_type), (setup_subtitle), (gen_source_element):
	* gst/playback/gstplaybin.c: (plugin_init):
	  Post missing-plugin messages on the bus for missing sources and
	  missing decoders/demuxers/depayloaders; fix error code used when
	  we're missing an URI handler source; for media types that we are not
	  handling on purpose at the moment, don't print "don't know how to
	  handle xyz" messages to the terminal or post missing-plugin
	  messages on the bus.

	* tests/check/elements/playbin.c: (create_playbin),
	(GST_START_TEST), (gst_codec_src_uri_get_type),
	(gst_codec_src_uri_get_protocols), (gst_codec_src_uri_get_uri),
	(gst_codec_src_uri_set_uri), (gst_codec_src_uri_handler_init),
	(gst_codec_src_init_type), (gst_codec_src_base_init),
	(gst_codec_src_create), (gst_codec_src_class_init),
	(gst_codec_src_init), (plugin_init), (playbin_suite):
	  Add some tests for the missing-plugin stuff.

545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
2007-01-09  Tim-Philipp Müller  <tim at centricular dot net>

	* configure.ac:
	* gst-libs/gst/Makefile.am:
	* gst-libs/gst/utils/Makefile.am:
	* gst-libs/gst/utils/base-utils.c: (gst_base_utils_init):
	* gst-libs/gst/utils/base-utils.h:
	* gst-libs/gst/utils/descriptions.c: (format_info_get_desc),
	(find_format_info), (caps_are_rtp_caps),
	(gst_base_utils_get_source_description),
	(gst_base_utils_get_sink_description),
	(gst_base_utils_get_decoder_description),
	(gst_base_utils_get_encoder_description),
	(gst_base_utils_get_element_description),
	(gst_base_utils_add_codec_description_to_tag_list),
	(gst_base_utils_get_codec_description), (gst_base_utils_list_all):
	* gst-libs/gst/utils/descriptions.h:
	* gst-libs/gst/utils/missing-plugins.c:
	(missing_structure_get_type), (copy_and_clean_caps),
	(gst_missing_uri_source_message_new),
	(gst_missing_uri_sink_message_new),
	(gst_missing_element_message_new),
	(gst_missing_decoder_message_new),
	(gst_missing_encoder_message_new),
	(missing_structure_get_string_detail),
	(missing_structure_get_caps_detail),
	(gst_missing_plugin_message_get_installer_detail),
	(gst_missing_plugin_message_get_description),
	(gst_is_missing_plugin_message):
	* gst-libs/gst/utils/missing-plugins.h:
	  API: add new libgstbaseutils library with functions
	  - to create and parse missing-plugins messages
	  - that provide (translated) descriptions for caps/decoders/sources/etc.
	  Closes #392393.

	* pkgconfig/gstreamer-plugins-base-uninstalled.pc.in:
	* pkgconfig/gstreamer-plugins-base.pc.in:
	  Add new lib.

	* docs/libs/gst-plugins-base-libs-docs.sgml:
	* docs/libs/gst-plugins-base-libs-sections.txt:
	  Generate docs for new lib and API.

	* tests/check/Makefile.am:
	* tests/check/libs/.cvsignore:
	* tests/check/libs/utils.c: (missing_msg_check_getters),
	(GST_START_TEST), (libgstbaseutils_suite):
	  Add some basic unit tests.

594
595
596
597
598
599
600
601
2007-01-09  Tim-Philipp Müller  <tim at centricular dot net>

	* ext/ogg/Makefile.am:
	  Dist gstoggdemux.h to fix 'make distcheck'.

	* sys/v4l/Makefile.am:
	  Fix 'make distcheck' even more.

Wim Taymans's avatar
Wim Taymans committed
602
603
604
605
606
607
608
609
610
611
612
613
614
615
2007-01-09  Wim Taymans  <wim@fluendo.com>

	* docs/plugins/Makefile.am:
	* docs/plugins/gst-plugins-base-plugins-docs.sgml:
	* docs/plugins/gst-plugins-base-plugins-sections.txt:
	* ext/ogg/gstoggdemux.c: (gst_ogg_page_copy), (gst_ogg_page_free),
	(gst_ogg_pad_query_types), (gst_ogg_pad_submit_page),
	(gst_ogg_chain_reset), (gst_ogg_chain_new_stream),
	(gst_ogg_demux_perform_seek):
	* ext/ogg/gstoggdemux.h:
	Added docs.
	Add some more comments.
	Small cleanups.

616
617
618
619
620
621
622
623
624
625
626
2007-01-09  Wim Taymans  <wim@fluendo.com>

	* ext/theora/theoradec.c:
	* ext/vorbis/vorbisdec.c:
	* gst-libs/gst/audio/gstringbuffer.c:
	(gst_ring_buffer_commit_full):
	* gst-libs/gst/audio/gstringbuffer.h:
	* gst-libs/gst/rtp/gstrtpbuffer.c:
	* gst-libs/gst/tag/gstvorbistag.c:
	Small documentation updates/fixes

627
628
629
630
631
2007-01-09  Tim-Philipp Müller  <tim at centricular dot net>

	* configure.ac:
	  Require core CVS HEAD for Andy's basesrc/sink API additions.

632
633
634
635
636
637
638
639
640
641
2007-01-08  Tim-Philipp Müller  <tim at centricular dot net>

	Patch by: Günter Thelen  <daedalus dot inc at gmx net>

	* gst/typefind/gsttypefindfunctions.c: (flac_type_find),
	(plugin_init):
	  Add typefinder for flac-in-ogg in conformance with the ogg-mapping
	  on flac.sf.net (there appear to be other versions of the first
	  ogg page in the wild) (#391365).

642
643
644
645
646
647
648
649
650
2007-01-08  Tim-Philipp Müller  <tim at centricular dot net>

	* configure.ac:
	  Check if localtime_r() is available.

	* ext/pango/gstclockoverlay.c: (gst_clock_overlay_render_time):
	  If localtime_r() is not available, fall back to localtime(). Should
	  fix build on MingW (#393310).

651
652
653
654
655
656
657
658
659
660
661
662
663
664
2007-01-08  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/subparse/gstsubparse.c: (parse_mdvdsub):
	* gst/subparse/gstsubparse.h:
	  Remove spurious 1000 subtrahend when calculating the timestamp from
	  the frame number and the frame rate . Also, use the frames/second
	  value specified in the first line of the file, if one is specified
	  there. Should fix #357503.

	* tests/check/elements/subparse.c: (do_test),
	(test_tmplayer_do_test), (test_microdvd_do_test), (GST_START_TEST),
	(subparse_suite):
	  Add some basic unit tests for the microdvd subtitle format.

665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
2007-01-07  Julien MOUTTE  <julien@moutte.net>

	* sys/xvimage/xvimagesink.c: (gst_xvimage_buffer_destroy),
	(gst_xvimage_buffer_finalize), (gst_xvimagesink_xvimage_new),
	(gst_xvimagesink_xvimage_put), (gst_lookup_xv_port_from_adaptor),
	(gst_xvimagesink_get_xv_support), (gst_xvimagesink_setcaps),
	(gst_xvimagesink_set_xwindow_id),
	(gst_xvimagesink_set_event_handling),
	(gst_xvimagesink_set_property), (gst_xvimagesink_get_property),
	(gst_xvimagesink_init), (gst_xvimagesink_class_init):
	Patch by : Young-Ho Cha <ganadist at chollian dot net>
	Fixes : #390076.
	Add an adaptor property to select a specific XV adaptor.
	* sys/xvimage/xvimagesink.h:

680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
2007-01-07  Julien MOUTTE  <julien@moutte.net>

	* sys/ximage/ximagesink.c: (gst_ximage_buffer_finalize),
	(gst_ximagesink_handle_xerror), (gst_ximagesink_ximage_new),
	(gst_ximagesink_ximage_destroy), (gst_ximagesink_ximage_put),
	(gst_ximagesink_handle_xevents), (gst_ximagesink_setcaps),
	(gst_ximagesink_change_state), (gst_ximagesink_set_xwindow_id),
	(gst_ximagesink_expose), (gst_ximagesink_set_event_handling):
	* sys/xvimage/xvimagesink.c: (gst_xvimage_buffer_destroy),
	(gst_xvimage_buffer_finalize), (gst_xvimagesink_handle_xerror),
	(gst_xvimagesink_xvimage_new), (gst_xvimagesink_xvimage_put),
	(gst_xvimagesink_handle_xevents), (gst_xvimagesink_setcaps),
	(gst_xvimagesink_change_state), (gst_xvimagesink_set_xwindow_id),
	(gst_xvimagesink_expose), (gst_xvimagesink_set_event_handling):
	Use flow_lock much more to protect every access to xwindow.
	Try to catch erros while creating images in case some drivers are
	just generating an XError when the requested image is too big.
	Should fix : #354698, #384008, #384060.
	* tests/icles/stress-xoverlay.c: (cycle_window), (create_window):
	Implement some stress testing of setting window xid.

701
702
703
704
705
706
707
708
709
710
711
2007-01-07  Sébastien Moutte  <sebastien@moutte.net>

	* win32/common/libgsaudio.def:
	  Add new exported function.
	* win32/common/libgstogg.dsp:
	  Add gstoggaviparse.c to the build.
	* win32/common/libgstvideoscale.dsp:
	  Add vs_4tap.c to the build.
	* win32/common/libgstvorbis.dsp:
	  Add vorbistag.c to the build.
	
712
713
714
715
716
717
718
719
720
721
722
723
724
725
2007-01-06  Andy Wingo  <wingo@pobox.com>

	* gst-libs/gst/audio/gstbaseaudiosink.c
	(gst_base_audio_sink_class_init)
	(gst_base_audio_sink_init): 
	(gst_base_audio_sink_activate_pull): Add an activate_pull function
	to baseaudiosink, and tell basesink that we can work in pull mode.
	This way the ring buffer thread drives the pipeline directly, if
	pull mode is possible. There is some lingering nastiness regarding
	capsnego, however.
	(gst_base_audio_sink_callback): Implement the callback to pull
	data. This interface is a bit light, though -- it should get a
	GstFlowReturn return value at least.

726
727
728
729
730
731
732
733
2007-01-05  Tim-Philipp Müller  <tim at centricular dot net>

	* ext/ogg/gstoggdemux.c: (gst_ogg_pad_stream_out):
	* ext/vorbis/vorbisdec.c: (vorbis_handle_data_packet):
	* gst/playback/gstdecodebin2.c:
	(gst_decode_group_check_if_blocked):
	  Printf format and missing argument fixes.

734
735
736
737
738
739
2007-01-05  Jan Schmidt  <thaytan@mad.scientist.com>

	* ext/ogg/gstogmparse.c: (gst_ogm_parse_stream_header),
	(gst_ogm_parse_change_state):
	Activate pads before adding them to the element.

740
741
742
743
744
745
2007-01-05  Tim-Philipp Müller  <tim at centricular dot net>

	* tests/examples/seek/scrubby.c: (main):
	* tests/examples/seek/seek.c: (main):
	  Call g_thread_init() first thing in main() (see #391278).

746
747
748
749
750
751
752
753
754
2007-01-05  Tim-Philipp Müller  <tim at centricular dot net>

	* tests/check/Makefile.am:
	* tests/check/libs/.cvsignore:
	* tests/check/libs/netbuffer.c: (GST_START_TEST),
	(netbuffer_suite):
	  Add test for GstNetBuffer + gst_buffer_copy(). Disabled
	  for the time being, since it's broken, see #393099.

755
756
757
758
759
2007-01-05  Tim-Philipp Müller  <tim at centricular dot net>

	* tests/check/Makefile.am:
	  Update to use GST_PLUGINS_BASE_CFLAGS as well.

760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
2007-01-04  Thomas Vander Stichele  <thomas at apestaart dot org>

	* configure.ac:
	  split out GST_CFLAGS into GST_PLUGINS_BASE_CFLAGS and GST_CFLAGS
	  so that GST_BASE_CFLAGS can go inbetween them, making sure
	  we use uninstalled gst-libs headers
	* docs/libs/Makefile.am:
	* ext/alsa/Makefile.am:
	* ext/cdparanoia/Makefile.am:
	* ext/gnomevfs/Makefile.am:
	* ext/libvisual/Makefile.am:
	* ext/ogg/Makefile.am:
	* ext/theora/Makefile.am:
	* ext/vorbis/Makefile.am:
	* gst-libs/gst/audio/Makefile.am:
	* gst-libs/gst/cdda/Makefile.am:
	* gst-libs/gst/interfaces/Makefile.am:
	* gst-libs/gst/riff/Makefile.am:
	* gst-libs/gst/rtp/Makefile.am:
	* gst-libs/gst/tag/Makefile.am:
	* gst/adder/Makefile.am:
	* gst/audioconvert/Makefile.am:
	* gst/audiorate/Makefile.am:
	* gst/audioresample/Makefile.am:
	* gst/playback/Makefile.am:
	* gst/tcp/Makefile.am:
	* gst/videoscale/Makefile.am:
	* gst/volume/Makefile.am:
	* sys/ximage/Makefile.am:
	* sys/xvimage/Makefile.am:
	* tests/icles/Makefile.am:
	  adapt

793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
2007-01-04  Julien MOUTTE  <julien@moutte.net>

	* gst-libs/gst/interfaces/xoverlay.c:
	(gst_x_overlay_handle_events):
	* gst-libs/gst/interfaces/xoverlay.h:
	* sys/ximage/ximagesink.c: (gst_ximagesink_xwindow_new),
	(gst_ximagesink_set_xwindow_id),
	(gst_ximagesink_set_event_handling),
	(gst_ximagesink_xoverlay_init), (gst_ximagesink_set_property),
	(gst_ximagesink_get_property), (gst_ximagesink_init),
	(gst_ximagesink_class_init):
	* sys/ximage/ximagesink.h:
	* sys/xvimage/xvimagesink.c: (gst_xvimagesink_xwindow_new),
	(gst_xvimagesink_set_xwindow_id),
	(gst_xvimagesink_set_event_handling),
	(gst_xvimagesink_xoverlay_init), (gst_xvimagesink_set_property),
	(gst_xvimagesink_get_property), (gst_xvimagesink_init),
	(gst_xvimagesink_class_init):
	* sys/xvimage/xvimagesink.h:
	* tests/icles/stress-xoverlay.c: (toggle_events), (create_window):
	Add a method to the XOverlay interface to allow disabling of 
	event handling in x[v]imagesink elements. This will let X events
	propagate to parent windows which can be usefull in some cases.
	Be carefull that the application is then responsible of pushing
	navigation events and expose events to the video sink.
	Fixes: #387138.

820
821
822
823
824
825
826
2007-01-03  Tim-Philipp Müller  <tim at centricular dot net>

	* gst-libs/gst/tag/gstvorbistag.c:
	* tests/check/libs/tag.c: (GST_START_TEST):
	  Add vorbistag <=> GStreamer tag mapping for GST_TAG_LOCATION
	  (fixes #392070).

Tim-Philipp Müller's avatar
Tim-Philipp Müller committed
827
828
829
830
831
832
833
2007-01-01  Tim-Philipp Müller  <tim at centricular dot net>

	* configure.ac:
	* docs/Makefile.am:
	* docs/design/Makefile.am:
	  Dist design docs.

834
835
836
837
838
2006-12-27  Julien MOUTTE  <julien@moutte.net>

	* docs/libs/gst-plugins-base-libs-sections.txt: Fix a documentation
	typo. Fixes: #390063.

Julien Moutte's avatar
Julien Moutte committed
839
840
841
842
843
844
845
2006-12-27  Julien MOUTTE  <julien@moutte.net>

	* sys/ximage/ximagesink.c: (gst_ximagesink_setcaps):
	* sys/xvimage/xvimagesink.c: (gst_xvimagesink_setcaps): Plug a
	caps leak.
	* win32/common/config.h: Updated.

846
847
848
849
850
851
852
853
854
2006-12-22  Stefan Kost  <ensonic@users.sf.net>

	* tests/check/elements/gdpdepay.c: (cleanup_gdpdepay),
	(setup_gdpdepay_streamheader):
	* tests/check/elements/gdppay.c: (cleanup_gdppay),
	(setup_gdppay_streamheader):
	  Fix the dp tests, but activating the pads for the streamheader tests
	  too and cleaning up conditionaly

855
856
857
858
859
860
861
862
863
864
865
866
867
2006-12-22  Jan Schmidt  <thaytan@mad.scientist.com>

	* gst/ffmpegcolorspace/avcodec.h:
	* gst/ffmpegcolorspace/gstffmpegcodecmap.c:
	(gst_ffmpeg_pixfmt_to_caps), (gst_ffmpeg_caps_to_pixfmt),
	(gst_ffmpegcsp_avpicture_fill):
	* gst/ffmpegcolorspace/imgconvert.c: (img_convert),
	(img_get_alpha_info):
	Add 2 new caps arrangements, for 24-bit RGB and BGR in 32-bits, but at the
	other end of the word. Fixes: #387073.

	Add some inconsequential branch hints in a couple of places.

868
869
870
871
872
873
874
875
2006-12-21  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/ffmpegcolorspace/gstffmpegcodecmap.c:
	(gst_ffmpeg_caps_to_smpfmt):
	  The "signed" field in raw audio caps is of boolean type, trying to
	  extract the value with _get_int() will fail (fix to keep in sync with
	  the copy in gst-ffmpeg)

876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
2006-12-21  Stefan Kost  <ensonic@users.sf.net>

	* tests/check/elements/audioresample.c: (cleanup_audioresample):
	* tests/check/elements/audiotestsrc.c: (cleanup_audiotestsrc):
	* tests/check/elements/gdpdepay.c: (setup_gdpdepay),
	(cleanup_gdpdepay):
	* tests/check/elements/gdppay.c: (setup_gdppay), (cleanup_gdppay):
	* tests/check/elements/subparse.c: (teardown_subparse):
	* tests/check/elements/textoverlay.c: (cleanup_textoverlay):
	* tests/check/elements/videorate.c: (cleanup_videorate):
	* tests/check/elements/videotestsrc.c: (cleanup_videotestsrc):
	* tests/check/elements/volume.c: (cleanup_volume):
	* tests/check/elements/vorbisdec.c: (setup_vorbisdec),
	(cleanup_vorbisdec):
	* tests/check/elements/vorbistag.c: (setup_vorbistag),
	(cleanup_vorbistag):
	  consistent pad (de)activation

894
895
896
897
898
2006-12-20  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/typefind/gsttypefindfunctions.c: (plugin_init):
	  Forgot to register the extensions.

899
900
901
902
903
904
2006-12-20  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/typefind/gsttypefindfunctions.c: (vivo_type_find),
	(plugin_init):
	  Add typefinder for VIVO files (my christmas present to the 90s).

905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
2006-12-16  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/gstdecodebin.c: (type_found):
	  Special-case the text/plain media type: we only want to recognise it
	  as a 'raw' decoded media type if it comes from a demuxer or subtitle
	  parser, but not if the entire stream is of text/plain type. If the
	  entire stream is text/plain, we should just error out.

	  This fixes playback of audio files with lyrics in totem. Totem can't
	  distinguish between text files and subtitle files and passes any
	  .txt file with the same basename as the main file to playbin as
	  suburi, and playbin will then throw a 'subtitle found, but no video
	  stream' error, which isn't entirely helpful. See #380342.

	  Also, with this change we'll show a slightly more correct error
	  message in case totem passes a playlist file to us (although a
	  custom error message wording instead of the default text would
	  probably not be a bad idea either).

	  Same problem also needs to be fixed for playbin+decodebin2.

	* tests/check/Makefile.am:
	* tests/check/elements/decodebin.c: (src_handoff_cb),
	(decodebin_new_decoded_pad_cb), (GST_START_TEST),
	(decodebin_suite):
	  Add simple unit test for decodebin for the above.

932
933
934
935
936
937
938
2006-12-16  Tim-Philipp Müller  <tim at centricular dot net>

	* gst/playback/gstdecodebin.c: (gst_decode_bin_change_state):
	* gst/playback/gstdecodebin2.c: (gst_decode_bin_change_state):
	  Refuse to change state to READY when we failed to create any of the
	  required elements in our instance init function.

939
940
941
942
943
944
945
946
947
948
949
950
951
2006-12-15  Tim-Philipp Müller  <tim at centricular dot net>

	* docs/libs/gst-plugins-base-libs-sections.txt:
	  Small docs fixes/updates.

	* gst-libs/gst/video/gstvideosink.h:
	  Remove nonfunctional GST_VIDEO_SINK_CLOCK macro which is a leftover
	  from the 0.9 days (GST_BASE_SINK_CLOCK, which it points to, was
	  removed from the base sink API between 0.9.6 and 0.9.7).
	  API: add GST_VIDEO_SINK_CAST and use it for the height/width
	  accessor macros, so we don't do a runtime GObject type check every
	  time we use them.

Thomas Vander Stichele's avatar
Thomas Vander Stichele committed
952
953
954
955
956
957
958
2006-12-15  Thomas Vander Stichele  <thomas at apestaart dot org>

	* Makefile.am:
	* gst-plugins-base.doap:
	* gst-plugins-base.spec.in:
	  add doap file

959
960
961
962
963
964
965
966
967
968
969
2006-12-09  Tim-Philipp Müller  <tim at centricular dot net>

	Patch by: Jens Granseuer <jensgr at gmx net>

	* gst-libs/gst/cdda/gstcddabasesrc.c: (gst_cdda_base_src_create):
	* gst-libs/gst/rtp/gstbasertpaudiopayload.c:
	(gst_base_rtp_audio_payload_handle_frame_based_buffer),
	(gst_base_rtp_audio_payload_handle_sample_based_buffer):
	* sys/v4l/gstv4lsrc.c: (gst_v4lsrc_fixate):
	  Declare variables at the beginning of a block. Fixes #383195.

970
971
972
973
974
975
2006-12-07  Jan Schmidt  <thaytan@mad.scientist.com>

	* configure.ac:
	Bump version nano - back to CVS.


976
977
978
979
980
981
982
=== release 0.10.11 ===

2006-12-06  Jan Schmidt <thaytan@mad.scientist.com>

	* configure.ac:
	  releasing 0.10.11, "Dumb things"

983
984
985
986
987
988
989
990
991
2006-12-05  Jan Schmidt  <thaytan@mad.scientist.com>

	* gst/playback/gstdecodebin.c: (find_dynamic), (dynamic_add),
	(close_pad_link), (elem_is_dynamic), (unlinked), (close_link):
	Handle the case where an element has multiple pads with 
	unfixed caps as well as still possibly producing more dynamic 
	pads by storing each case as a distinct entry in the dynamic list.
	Fixes #38223 again.

992
993
994
995
996
997
998
999
1000
2006-12-04  Wim Taymans  <wim@fluendo.com>

	* gst/playback/gstdecodebin.c: (close_pad_link):
	Fix #382223, add more dynamic caps handling.

2006-12-04  Wim Taymans  <wim@fluendo.com>

	reviewed by: <delete if not using a buddy>