• Tim-Philipp Müller's avatar
    gst/playback/gstdecodebin.c: Special-case the text/plain media type: we only... · a4c0d0b8
    Tim-Philipp Müller authored
    gst/playback/gstdecodebin.c: Special-case the text/plain media type: we only want to recognise it as a 'raw' decoded ...
    
    Original commit message from CVS:
    * gst/playback/gstdecodebin.c: (type_found):
    Special-case the text/plain media type: we only want to recognise it
    as a 'raw' decoded media type if it comes from a demuxer or subtitle
    parser, but not if the entire stream is of text/plain type. If the
    entire stream is text/plain, we should just error out.
    This fixes playback of audio files with lyrics in totem. Totem can't
    distinguish between text files and subtitle files and passes any
    .txt file with the same basename as the main file to playbin as
    suburi, and playbin will then throw a 'subtitle found, but no video
    stream' error, which isn't entirely helpful. See #380342.
    Also, with this change we'll show a slightly more correct error
    message in case totem passes a playlist file to us (although a
    custom error message wording instead of the default text would
    probably not be a bad idea either).
    Same problem also needs to be fixed for playbin+decodebin2.
    * tests/check/Makefile.am:
    * tests/check/elements/decodebin.c: (src_handoff_cb),
    (decodebin_new_decoded_pad_cb), (GST_START_TEST),
    (decodebin_suite):
    Add simple unit test for decodebin for the above.
    a4c0d0b8
To find the state of this project's repository at the time of any of these versions, check out the tags..
ChangeLog 1.06 MB