Commit 0bfed26f authored by Olivier Crête's avatar Olivier Crête
Browse files

opus: Post error message on GST_FLOW_ERROR

https://bugzilla.gnome.org/show_bug.cgi?id=766265
parent 1a700c3a
...@@ -316,7 +316,8 @@ gst_opus_dec_parse_header (GstOpusDec * dec, GstBuffer * buf) ...@@ -316,7 +316,8 @@ gst_opus_dec_parse_header (GstOpusDec * dec, GstBuffer * buf)
const GstAudioChannelPosition *posn = NULL; const GstAudioChannelPosition *posn = NULL;
if (!gst_opus_header_is_id_header (buf)) { if (!gst_opus_header_is_id_header (buf)) {
GST_ERROR_OBJECT (dec, "Header is not an Opus ID header"); GST_ELEMENT_ERROR (dec, STREAM, FORMAT, ("Header is not an Opus ID header"),
(NULL));
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
} }
...@@ -327,7 +328,8 @@ gst_opus_dec_parse_header (GstOpusDec * dec, GstBuffer * buf) ...@@ -327,7 +328,8 @@ gst_opus_dec_parse_header (GstOpusDec * dec, GstBuffer * buf)
&dec->n_streams, &dec->n_streams,
&dec->n_stereo_streams, &dec->n_stereo_streams,
dec->channel_mapping, &dec->pre_skip, &dec->r128_gain)) { dec->channel_mapping, &dec->pre_skip, &dec->r128_gain)) {
GST_ERROR_OBJECT (dec, "Failed to parse Opus ID header"); GST_ELEMENT_ERROR (dec, STREAM, DECODE, ("Failed to parse Opus ID header"),
(NULL));
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
} }
dec->r128_gain_volume = gst_opus_dec_get_r128_volume (dec->r128_gain); dec->r128_gain_volume = gst_opus_dec_get_r128_volume (dec->r128_gain);
...@@ -646,11 +648,13 @@ done: ...@@ -646,11 +648,13 @@ done:
return res; return res;
creation_failed: creation_failed:
GST_ERROR_OBJECT (dec, "Failed to create Opus decoder: %d", err); GST_ELEMENT_ERROR (dec, LIBRARY, INIT, ("Failed to create Opus decoder"),
("Failed to create Opus decoder (%d): %s", err, opus_strerror (err)));
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
buffer_failed: buffer_failed:
GST_ERROR_OBJECT (dec, "Failed to create %u byte buffer", packet_size); GST_ELEMENT_ERROR (dec, STREAM, DECODE,
("Failed to create %u byte buffer", packet_size), (NULL));
return GST_FLOW_ERROR; return GST_FLOW_ERROR;
} }
......
...@@ -1044,13 +1044,14 @@ gst_opus_enc_encode (GstOpusEnc * enc, GstBuffer * buf) ...@@ -1044,13 +1044,14 @@ gst_opus_enc_encode (GstOpusEnc * enc, GstBuffer * buf)
gst_buffer_unmap (outbuf, &omap); gst_buffer_unmap (outbuf, &omap);
if (outsize < 0) { if (outsize < 0) {
GST_ERROR_OBJECT (enc, "Encoding failed: %d", outsize); GST_ELEMENT_ERROR (enc, STREAM, ENCODE, ("Encoding failed"),
("Encoding ifailed (%d): %s", outsize, opus_strerror (outsize)));
ret = GST_FLOW_ERROR; ret = GST_FLOW_ERROR;
goto done; goto done;
} else if (outsize > max_payload_size) { } else if (outsize > max_payload_size) {
GST_WARNING_OBJECT (enc, GST_ELEMENT_ERROR (enc, STREAM, ENCODE, ("Encoder error"),
"Encoded size %d is higher than max payload size (%d bytes)", ("Encoded size %d is higher than max payload size (%d bytes)",
outsize, max_payload_size); outsize, max_payload_size));
ret = GST_FLOW_ERROR; ret = GST_FLOW_ERROR;
goto done; goto done;
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment