Commit 46e808a3 authored by Sebastian Dröge's avatar Sebastian Dröge
Browse files

multihandlesink: Warn if trying to change the state from the streaming thread

Instead of silently returning GST_STATE_CHANGE_FAILURE.
parent fe4e9bb0
......@@ -2221,9 +2221,16 @@ gst_multi_handle_sink_change_state (GstElement * element,
sink = GST_MULTI_HANDLE_SINK (element);
/* we disallow changing the state from the streaming thread */
if (g_thread_self () == sink->thread)
return GST_STATE_CHANGE_FAILURE;
if (g_thread_self () == sink->thread) {
g_warning
("\nTrying to change %s's state from its streaming thread would deadlock.\n"
"You cannot change the state of an element from its streaming\n"
"thread. Use g_idle_add() or post a GstMessage on the bus to\n"
"schedule the state change from the main thread.\n",
GST_ELEMENT_NAME (sink));
return GST_STATE_CHANGE_FAILURE;
}
switch (transition) {
case GST_STATE_CHANGE_NULL_TO_READY:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment