Commit 5ed71164 authored by Tim-Philipp Müller's avatar Tim-Philipp Müller
Browse files

ext/pango/gsttextoverlay.c: Don't unnecessarily ref (and then leak) upstream...

ext/pango/gsttextoverlay.c: Don't unnecessarily ref (and then leak) upstream events if the text pad is not linked. Fi...

Original commit message from CVS:
* ext/pango/gsttextoverlay.c: (gst_text_overlay_src_event),
(gst_text_overlay_text_event):
Don't unnecessarily ref (and then leak) upstream events if the text
pad is not linked. Fixes #399948.
* tests/check/gst-plugins-base.supp:
Add suppression for pango on edgy/x86 for textoverlay test.
parent 81e92118
2007-01-24 Tim-Philipp Müller <tim at centricular dot net>
* ext/pango/gsttextoverlay.c: (gst_text_overlay_src_event),
(gst_text_overlay_text_event):
Don't unnecessarily ref (and then leak) upstream events if the text
pad is not linked. Fixes #399948.
* tests/check/gst-plugins-base.supp:
Add suppression for pango on edgy/x86 for textoverlay test.
2007-01-24 Wim Taymans <wim@fluendo.com>
 
* gst-libs/gst/rtp/gstrtpbuffer.h:
......@@ -721,11 +721,14 @@ gst_text_overlay_src_event (GstPad * pad, GstEvent * event)
}
break;
default:
gst_event_ref (event);
ret = gst_pad_push_event (overlay->video_sinkpad, event);
if (overlay->text_linked) {
ret = gst_pad_push_event (overlay->text_sinkpad, event);
gst_event_ref (event);
ret = gst_pad_push_event (overlay->video_sinkpad, event);
gst_pad_push_event (overlay->text_sinkpad, event);
} else {
ret = gst_pad_push_event (overlay->video_sinkpad, event);
}
break;
}
beach:
......@@ -1120,6 +1123,7 @@ gst_text_overlay_text_event (GstPad * pad, GstEvent * event)
GST_OBJECT_LOCK (overlay);
overlay->text_flushing = TRUE;
overlay->text_eos = TRUE;
GST_INFO_OBJECT (overlay, "EOS");
/* wake up the video chain, it might be waiting for a text buffer or
* a text segment update */
GST_TEXT_OVERLAY_BROADCAST (overlay);
......
......@@ -10,3 +10,12 @@
fun:theora_encode_YUVin
}
# Suppression for pango on ubuntu edgy/x86 and textoverlay test
{
<pango>
Memcheck:Param
access(pathname)
fun:access
fun:pango_config_key_get
fun:pango_find_map
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment