Commit 6e469b2a authored by Andreas Frisch's avatar Andreas Frisch Committed by Tim-Philipp Müller
Browse files

playbin: subtitleoverlay: don't segfault in incorrectly init'ed plugins

https://bugzilla.gnome.org/show_bug.cgi?id=683865
parent 77c3a225
......@@ -191,11 +191,13 @@ _is_renderer (GstElementFactory * factory)
klass = gst_element_factory_get_klass (factory);
name = gst_plugin_feature_get_name (GST_PLUGIN_FEATURE_CAST (factory));
if (strstr (klass, "Overlay/Subtitle") != NULL ||
strstr (klass, "Overlay/SubPicture") != NULL)
return TRUE;
if (strcmp (name, "textoverlay") == 0)
return TRUE;
if (klass != NULL) {
if (strstr (klass, "Overlay/Subtitle") != NULL ||
strstr (klass, "Overlay/SubPicture") != NULL)
return TRUE;
if (strcmp (name, "textoverlay") == 0)
return TRUE;
}
return FALSE;
}
......@@ -206,7 +208,7 @@ _is_parser (GstElementFactory * factory)
klass = gst_element_factory_get_klass (factory);
if (strstr (klass, "Parser/Subtitle") != NULL)
if (klass != NULL && strstr (klass, "Parser/Subtitle") != NULL)
return TRUE;
return FALSE;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment