Commit b1751ae3 authored by Tim-Philipp Müller's avatar Tim-Philipp Müller
Browse files

tests/check/libs/utils.c: Fix unit test. Turns out things work much better when you

Original commit message from CVS:
* tests/check/libs/utils.c: (GST_START_TEST):
Fix unit test. Turns out things work much better when you
NULL-terminate string arrays. Should make p5 build bot happy again.
parent 2594880e
2007-02-04 Tim-Philipp Müller <tim at centricular dot net>
* tests/check/libs/utils.c: (GST_START_TEST):
Fix unit test. Turns out things work much better when you
NULL-terminate string arrays. Should make p5 build bot happy again.
2007-02-03 Tim-Philipp Müller <tim at centricular dot net> 2007-02-03 Tim-Philipp Müller <tim at centricular dot net>
   
* gst-libs/gst/audio/Makefile.am: * gst-libs/gst/audio/Makefile.am:
...@@ -72,7 +72,8 @@ GST_START_TEST (test_base_utils_post_missing_messages) ...@@ -72,7 +72,8 @@ GST_START_TEST (test_base_utils_post_missing_messages)
bus = gst_element_get_bus (pipeline); bus = gst_element_get_bus (pipeline);
/* first, test common assertion failure cases */ /* first, test common assertion failure cases */
ASSERT_CRITICAL (msg = gst_missing_uri_source_message_new (NULL, "http");); ASSERT_CRITICAL (msg = gst_missing_uri_source_message_new (NULL, "http");
);
ASSERT_CRITICAL (gst_missing_uri_source_message_new (pipeline, NULL)); ASSERT_CRITICAL (gst_missing_uri_source_message_new (pipeline, NULL));
ASSERT_CRITICAL (gst_missing_uri_sink_message_new (NULL, "http")); ASSERT_CRITICAL (gst_missing_uri_sink_message_new (NULL, "http"));
...@@ -536,18 +537,15 @@ GST_START_TEST (test_base_utils_install_plugins) ...@@ -536,18 +537,15 @@ GST_START_TEST (test_base_utils_install_plugins)
{ {
GstInstallPluginsContext *ctx; GstInstallPluginsContext *ctx;
GstInstallPluginsReturn ret; GstInstallPluginsReturn ret;
gchar *details[] = { "detail1", "detail2" }; gchar *details[] = { "detail1", "detail2", NULL };
ctx = gst_install_plugins_context_new (); ctx = gst_install_plugins_context_new ();
ASSERT_CRITICAL (ret = gst_install_plugins_sync (NULL, ctx); ASSERT_CRITICAL (ret = gst_install_plugins_sync (NULL, ctx););
);
ASSERT_CRITICAL (ret = ASSERT_CRITICAL (ret =
gst_install_plugins_async (NULL, ctx, result_cb, (gpointer) & marker); gst_install_plugins_async (NULL, ctx, result_cb, (gpointer) & marker););
);
ASSERT_CRITICAL (ret = ASSERT_CRITICAL (ret =
gst_install_plugins_async (details, ctx, NULL, (gpointer) & marker); gst_install_plugins_async (details, ctx, NULL, (gpointer) & marker););
);
/* make sure the functions return the right error code if the helper does /* make sure the functions return the right error code if the helper does
* not exist */ * not exist */
......
...@@ -72,7 +72,8 @@ GST_START_TEST (test_base_utils_post_missing_messages) ...@@ -72,7 +72,8 @@ GST_START_TEST (test_base_utils_post_missing_messages)
bus = gst_element_get_bus (pipeline); bus = gst_element_get_bus (pipeline);
/* first, test common assertion failure cases */ /* first, test common assertion failure cases */
ASSERT_CRITICAL (msg = gst_missing_uri_source_message_new (NULL, "http");); ASSERT_CRITICAL (msg = gst_missing_uri_source_message_new (NULL, "http");
);
ASSERT_CRITICAL (gst_missing_uri_source_message_new (pipeline, NULL)); ASSERT_CRITICAL (gst_missing_uri_source_message_new (pipeline, NULL));
ASSERT_CRITICAL (gst_missing_uri_sink_message_new (NULL, "http")); ASSERT_CRITICAL (gst_missing_uri_sink_message_new (NULL, "http"));
...@@ -536,18 +537,15 @@ GST_START_TEST (test_base_utils_install_plugins) ...@@ -536,18 +537,15 @@ GST_START_TEST (test_base_utils_install_plugins)
{ {
GstInstallPluginsContext *ctx; GstInstallPluginsContext *ctx;
GstInstallPluginsReturn ret; GstInstallPluginsReturn ret;
gchar *details[] = { "detail1", "detail2" }; gchar *details[] = { "detail1", "detail2", NULL };
ctx = gst_install_plugins_context_new (); ctx = gst_install_plugins_context_new ();
ASSERT_CRITICAL (ret = gst_install_plugins_sync (NULL, ctx); ASSERT_CRITICAL (ret = gst_install_plugins_sync (NULL, ctx););
);
ASSERT_CRITICAL (ret = ASSERT_CRITICAL (ret =
gst_install_plugins_async (NULL, ctx, result_cb, (gpointer) & marker); gst_install_plugins_async (NULL, ctx, result_cb, (gpointer) & marker););
);
ASSERT_CRITICAL (ret = ASSERT_CRITICAL (ret =
gst_install_plugins_async (details, ctx, NULL, (gpointer) & marker); gst_install_plugins_async (details, ctx, NULL, (gpointer) & marker););
);
/* make sure the functions return the right error code if the helper does /* make sure the functions return the right error code if the helper does
* not exist */ * not exist */
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment