From d10959fd3613b1f08d975a948fd9f9dfef5def66 Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Mon, 20 Jul 2015 16:20:24 -0400 Subject: [PATCH] basetextoverlay: Clear reconfigure flags before negotation This avoids negotiating twice. Current the _setcaps() patch does not clear the initial reconfigure flags, which lead to systematic double renegotiation. http://bugzilla.gnome.org/show_bug.cgi?id=751157 --- ext/pango/gstbasetextoverlay.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ext/pango/gstbasetextoverlay.c b/ext/pango/gstbasetextoverlay.c index fe15ed3f6..647668d27 100644 --- a/ext/pango/gstbasetextoverlay.c +++ b/ext/pango/gstbasetextoverlay.c @@ -729,6 +729,9 @@ gst_base_text_overlay_negotiate (GstBaseTextOverlay * overlay, GstCaps * caps) GST_DEBUG_OBJECT (overlay, "performing negotiation"); + /* Clear any pending reconfigure to avoid negotiating twice */ + gst_pad_check_reconfigure (overlay->srcpad); + if (!caps) caps = gst_pad_get_current_caps (overlay->video_sinkpad); else -- GitLab