Commit 60bad481 authored by Sebastian Dröge's avatar Sebastian Dröge

Revert "decodebin2: fix deadlock on chain shutdown"

This reverts commit 77dc09c3.

It can cause the FLUSH_START/STOP events to go to the sink elements, which
then causes state changes and various other problems. We shouldn't really
flush downstream here, the idea is to do *draining*.

Apart from that the testcase for the original bug here works without this
commit now.
parent 29cfb9a6
......@@ -3432,10 +3432,8 @@ gst_decode_chain_free_internal (GstDecodeChain * chain, gboolean hide)
if (chain->endpad) {
if (chain->endpad->exposed) {
GstPad *endpad = GST_PAD_CAST (chain->endpad);
gst_pad_push_event (endpad, gst_event_new_flush_start ());
gst_pad_push_event (endpad, gst_event_new_flush_stop (FALSE));
gst_element_remove_pad (GST_ELEMENT_CAST (chain->dbin), endpad);
gst_element_remove_pad (GST_ELEMENT_CAST (chain->dbin),
GST_PAD_CAST (chain->endpad));
decode_pad_set_target (chain->endpad, NULL);
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment