• Seungha Yang's avatar
    matroskademux: don't hold object lock whilst pushing out headers · eb09829a
    Seungha Yang authored
    matroskademux would take the GST_OBJECT_LOCK in
    - gst_matroska_demux_push_codec_data_all()
    - gst_matroska_demux_query()
    
    Some parse element such as FLAC checks upstream seekability, and
    there is some use cases that matroska-demux is linked to a parse element
    (e.g.,FLAC format) without intermediate elements (e.g., queue).
    In this case, matroska-demux never returns from _push_codec_data_all()
    because the parser can return only after it receives the response to
    the upstream query, but that's not going to happen because it's
    deadlocked.
    
    Elements must not hold the object lock whilst pushing out events
    or data.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=766645
    eb09829a
matroska-demux.c 197 KB