Commit 0b898ab9 authored by Douglas Bagnall's avatar Douglas Bagnall Committed by Sebastian Dröge

videoconvert: Compare y offset with height, not width, when testing for overlap

This could have prevented images showing that should have when the
source height is greater than its width.

When width exceeds height, as is common, it probably only caused a
miniscule amount of unnecessary work.  I haven't tested.
parent 5ac78940
......@@ -273,7 +273,7 @@ blend_##format_name (GstVideoFrame * srcframe, gint xpos, gint ypos, \
ypos = 0; \
} \
/* If x or y offset are larger then the source it's outside of the picture */ \
if (xoffset > src_width || yoffset > src_width) { \
if (xoffset > src_width || yoffset > src_height) { \
return; \
} \
\
......@@ -518,7 +518,7 @@ blend_##format_name (GstVideoFrame * srcframe, gint xpos, gint ypos, \
ypos = 0; \
} \
/* If x or y offset are larger then the source it's outside of the picture */ \
if (xoffset > src_width || yoffset > src_width) { \
if (xoffset > src_width || yoffset > src_height) { \
return; \
} \
\
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment