Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
G
gst-plugins-good
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
George Kiagiadakis
gst-plugins-good
Commits
32d9f3c1
Commit
32d9f3c1
authored
Jan 20, 2017
by
Sebastian Dröge
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
avidemux: Fix various out of bounds reads when parsing ncdt tags
https://bugzilla.gnome.org/show_bug.cgi?id=777500
parent
1ffef8bf
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
4 deletions
+8
-4
gst/avi/gstavidemux.c
gst/avi/gstavidemux.c
+8
-4
No files found.
gst/avi/gstavidemux.c
View file @
32d9f3c1
...
...
@@ -3912,6 +3912,7 @@ gst_avi_demux_parse_ncdt (GstAviDemux * avi, GstBuffer * buf,
tsize
-=
4
;
ptr
+=
4
;
left
-=
4
;
GST_DEBUG_OBJECT
(
avi
,
"sub-tag %u, size %u"
,
sub_tag
,
sub_size
);
/* http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/Nikon.html#NCTG
...
...
@@ -3930,10 +3931,12 @@ gst_avi_demux_parse_ncdt (GstAviDemux * avi, GstBuffer * buf,
break
;
case
0x13
:
/* CreationDate */
type
=
GST_TAG_DATE_TIME
;
if
(
ptr
[
4
]
==
':'
)
ptr
[
4
]
=
'-'
;
if
(
ptr
[
7
]
==
':'
)
ptr
[
7
]
=
'-'
;
if
(
left
>
7
)
{
if
(
ptr
[
4
]
==
':'
)
ptr
[
4
]
=
'-'
;
if
(
ptr
[
7
]
==
':'
)
ptr
[
7
]
=
'-'
;
}
break
;
default:
type
=
NULL
;
...
...
@@ -3947,6 +3950,7 @@ gst_avi_demux_parse_ncdt (GstAviDemux * avi, GstBuffer * buf,
ptr
+=
sub_size
;
tsize
-=
sub_size
;
left
-=
sub_size
;
}
break
;
default:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment