Commit 8098a2f0 authored by Tim-Philipp Müller's avatar Tim-Philipp Müller
Browse files

imagefreeze: clear 0 DTS on buffers output, as sinks will prefer DTS over PTS for syncing

Since the initial decoded still image buffer will have dts=pts=0, and
we only set PTS on buffers we push out, all buffers pushed out would
have a DTS of 0. Sinks, however, will prefer DTS over PTS if both are
set, and will therefore always see a timestamp of 0 no matter what
the PTS is set to.

Fixes unit test too.
parent b6484955
......@@ -714,7 +714,7 @@ gst_image_freeze_src_loop (GstPad * pad)
if (self->need_segment) {
GstEvent *e;
GST_DEBUG_OBJECT (pad, "Pushing NEWSEGMENT event: %" GST_SEGMENT_FORMAT,
GST_DEBUG_OBJECT (pad, "Pushing SEGMENT event: %" GST_SEGMENT_FORMAT,
&self->segment);
e = gst_event_new_segment (&self->segment);
......@@ -777,7 +777,8 @@ gst_image_freeze_src_loop (GstPad * pad)
if (in_seg) {
GstFlowReturn ret;
GST_BUFFER_TIMESTAMP (buffer) = cstart;
GST_BUFFER_DTS (buffer) = GST_CLOCK_TIME_NONE;
GST_BUFFER_PTS (buffer) = cstart;
GST_BUFFER_DURATION (buffer) = cstop - cstart;
GST_BUFFER_OFFSET (buffer) = offset;
GST_BUFFER_OFFSET_END (buffer) = offset + 1;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment