Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
G
gst-plugins-good
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
George Kiagiadakis
gst-plugins-good
Commits
8b2a6a8c
Commit
8b2a6a8c
authored
Jun 16, 2010
by
Sebastian Dröge
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
flactag: Fix possible NULL pointer dereference
parent
711e0cc9
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
0 deletions
+4
-0
ext/flac/gstflactag.c
ext/flac/gstflactag.c
+4
-0
No files found.
ext/flac/gstflactag.c
View file @
8b2a6a8c
...
...
@@ -364,6 +364,8 @@ gst_flac_tag_chain (GstPad * pad, GstBuffer * buffer)
if
(
buffer
==
NULL
)
{
GST_ELEMENT_ERROR
(
tag
,
CORE
,
TOO_LAZY
,
(
NULL
),
(
"Error creating 12-byte buffer for padding block"
));
ret
=
GST_FLOW_ERROR
;
goto
cleanup
;
}
memset
(
GST_BUFFER_DATA
(
buffer
),
0
,
GST_BUFFER_SIZE
(
buffer
));
GST_BUFFER_DATA
(
buffer
)[
0
]
=
0x81
;
/* 0x80 = Last metadata block,
...
...
@@ -383,6 +385,7 @@ gst_flac_tag_chain (GstPad * pad, GstBuffer * buffer)
if
(
buffer
==
NULL
)
{
GST_ELEMENT_ERROR
(
tag
,
CORE
,
TAG
,
(
NULL
),
(
"Error converting tag list to vorbiscomment buffer"
));
ret
=
GST_FLOW_ERROR
;
goto
cleanup
;
}
size
=
GST_BUFFER_SIZE
(
buffer
)
-
4
;
...
...
@@ -393,6 +396,7 @@ gst_flac_tag_chain (GstPad * pad, GstBuffer * buffer)
*/
GST_ELEMENT_ERROR
(
tag
,
CORE
,
TAG
,
(
NULL
),
(
"Vorbis comment of size %d too long"
,
size
));
ret
=
GST_FLOW_ERROR
;
goto
cleanup
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment