1. 16 Feb, 2016 7 commits
    • Luis de Bethencourt's avatar
      rtp: remove dead assignment · 7ae49b46
      Luis de Bethencourt authored
      Value set to ret will be overwritten at least once at the end of the while
      loop, removing assignment.
    • Luis de Bethencourt's avatar
      remove unused enum items PROP_LAST · 693a9244
      Luis de Bethencourt authored
      This were probably added to the enums due to cargo cult programming and are
    • Luis de Bethencourt's avatar
      rtp: donl_present variable unused · 51791d8f
      Luis de Bethencourt authored
      donl_present is not implemented, yet the value is set and checked a few times.
      Cleaning this.
      CID #1249687
    • Luis de Bethencourt's avatar
      rtp: value truncated too short creates dead code · e3d8d8ce
      Luis de Bethencourt authored
      type is truncated to 0-31 with "& 0x1f", but right after that it is checks if
      the value is equivalent to GST_H265_NAL_VPS, GST_H265_NAL_SPS, and
      GST_H265_NAL_PPS (which are 32, 33, and 34 respectively). Obviously, this will
      never be True if the value is maximum 31 after the truncation.
      The intention of the code was to truncate to 0-63.
    • Luis de Bethencourt's avatar
      rtp: fix nal unit type check · 59fea445
      Luis de Bethencourt authored
      After further investigation the previous commit is wrong. The code intended to
      check if the type is 39 or the ranges 41-44 and 48-55. Just like gsth265parse.c
      does. Type 40 would not be complete.
    • Luis de Bethencourt's avatar
      rtp: fix dead code and check for impossible values · d215b18a
      Luis de Bethencourt authored
      nal_type is the index for a GstH265NalUnitType enum. There are two types of dead
      code here:
      First, after checking if nal_type is >= 39 there are two OR conditionals that
      check if the value is in ranges higher than that number, so if nal_type >= 39
      falls in the True branch those other conditions aren't checked and if it falls
      in the False branch and they are checked, they will always also be False. They
      are redundant.
      Second, the enum has a range of 0 to 40. So the checks for ranges higher than 41
      should never be True.
      Removing this redundant checks.
      CID 1249684
    • Thijs Vermeir's avatar
      rtp: add h265 RTP payloader + depayloader · 544c0d75
      Thijs Vermeir authored
  2. 17 Dec, 2001 1 commit