GitLab

This is a regression from ASCII validation changes. Test case:
bug_s66876390_r0.001____malloc_printerr.webm

This was triggering an UTF-8 assertion in gst_caps_set_simple for
corrupt files with garbage as codec id. Test case:
gstreamer_error_trying_to_set_invalid_utf8_as_codec_id.webm

Old gst_ebml_read_ascii renamed to gst_ebml_read_string, also used by
gst_ebml_read_utf8. Unlike for UTF-8, failure to validate is an error,
as gst_ebml_read_ascii is used for reading doctype and codec id and we
might just as well give up early in those cases.

Because GstMatroskaTrackContext *stream is set up in the first
SimpleBlock or Block, a rogue CodecState otherwise causes a segfault on
derefencing the NULL pointer. Test case:
bug_s5506167_r0.001____gst_matroska_demux_parse_blockgroup_or_simpleblock.webm

...matroskademux automatically supports it through libgstriff.

...avidemux automatically supports it through libgstriff.

From 4d67bd6 to 357b0db

Unref server objects when done. Fixes check-valgrind.

Don't leak othercaps or jpegenc ref.

Documentation error spotted by tony <caicai0119 at gmail.com>

Fixes #618419

It probably will not be in the final RFC as it is not in RFC 5215 for Vorbis.
If there is a configuration specified, assume it is in-line and if nothing is
specified, assume it is in-band.

https://bugzilla.gnome.org/show_bug.cgi?id=618386

We can perfectly decode 1x1 images so lower the min width and height to 1.

Fixes #618392

Don't blindly add the durations of incomming buffers to the total queued
duration because it might be invalid. Mark the total queued duration invalid
when we receive an invalid incomming timestamp because that's when we lose track
of the total queued duration.

Fixes #618324

... so it can also be regularly inserted into the stream if so configured.

Fixes #617164.

Remove fixed FIXME, change finalise to finalize for consistency.

Hook up build infrastructure, docs and tests.

Fixes #614305.

OSS4 supports per-stream volume control, so expose this using the right
API, so that playbin2 and applications like totem can make use of it
(instead of using a volume element for volume control).

Fixes #614305.

When iterating the formats table, we can just pass the whole
entry to our helper function, which avoids iterating the table
again to find the entry structure from the passed format id.

Also accept formats that are not natively supported by the
hardware, OSS4 can convert them internally. List the native
formats first in the caps though, to express our preference
for the native formats. We need this in order to support the
case properly where the audio hardware supports only e.g.
little endian PCM, but the host is big endian, since many
audio elements only support native endianness and make the
reasonable assumption that any audiosink will be able to
handle audio in native endianness.

Based on patch by Jerry Tan <jerry.tan@sun.com>

Fixes #614317.

Not that that will make these strings much better. Also remove i18n
marker where it doesn't make sense.

A side effect is that it passes -Wformat-nonliteral and doesn't read
invalid memory in some cases, like when the mixer track contains
a % sign or there is a number but not a known mixer name.

We to the strdup inside gst_oss4_mixer_control_get_translated_name()
instead of in the only caller.

And fix all warnings

Don't store a const gchar * in a non-const gchar * local var.

Also, make the translation string function static since it's only
used in the one file.

Code cleanups, general improvements, support for the
new mixer flags in latest gst-plugins-base.

Fixes: #584252
Patch By: Brian Cameron <brian.cameron@sun.com>
Patch By: Garrett D'Amore <garrett.damore@sun.com>