1. 11 Jan, 2008 1 commit
    • Jan Schmidt's avatar
      Generate the image-type values correctly. Leave them out of the caps when... · c2dddd02
      Jan Schmidt authored
      Generate the image-type values correctly. Leave them out of the caps when outputting a "preview image" tag, since it ...
      
      Original commit message from CVS:
      * ext/flac/gstflacdec.c: (gst_flac_extract_picture_buffer):
      * gst/id3demux/id3v2frames.c: (parse_picture_frame):
      Generate the image-type values correctly. Leave them out of the caps
      when outputting a "preview image" tag, since it only makes sense
      to have one of those - the type is irrelevant.
      * sys/sunaudio/gstsunaudiomixerctrl.c:
      (gst_sunaudiomixer_ctrl_open):
      If we can, mark the mixer multiple open when we use it, in case
      (for some reason) the process wants to open it again elsewhere.
      c2dddd02
  2. 09 Jan, 2008 1 commit
    • Tommi Myöhänen's avatar
      gst/id3demux/id3v2frames.c: Make sure the ISO 639-X language code in ID3v2... · 23112710
      Tommi Myöhänen authored
      gst/id3demux/id3v2frames.c: Make sure the ISO 639-X language code in ID3v2 COMM frames so we don't end up with non-UT...
      
      Original commit message from CVS:
      Based on patch by: Tommi Myöhänen <ext-tommi.myohanen nokia com>
      * gst/id3demux/id3v2frames.c: (parse_comment_frame):
      Make sure the ISO 639-X language code in ID3v2 COMM frames
      is actually valid UTF-8 (or rather: ASCII), so we don't end
      up with non-UTF8 strings in tags if there's garbage in the
      language field. Also make sure the language code is always
      lower case. Fixes: #508291.
      23112710
  3. 14 Dec, 2007 1 commit
    • Tim-Philipp Müller's avatar
      gst/id3demux/id3v2frames.c: Parse WOAF frames and put the result into... · 7951e1cc
      Tim-Philipp Müller authored
      gst/id3demux/id3v2frames.c: Parse WOAF frames and put the result into GST_TAG_CONTACT, which is where it would end up...
      
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (parse_url_link_frame):
      Parse WOAF frames and put the result into GST_TAG_CONTACT,
      which is where it would end up if the same information was
      put in a vorbis comment (don't think it's worth adding a
      new URI tag for this). Fixes #488112.
      7951e1cc
  4. 14 Nov, 2007 1 commit
    • Tim-Philipp Müller's avatar
      gst/id3demux/: We don't want the same string multiple times in a tag list for... · 62d8456e
      Tim-Philipp Müller authored
      gst/id3demux/: We don't want the same string multiple times in a tag list for the same tag ever, for any tag, not jus...
      
      Original commit message from CVS:
      * gst/id3demux/id3tags.c:
      * gst/id3demux/id3tags.h:
      * gst/id3demux/id3v2frames.c: (id3v2_tag_to_taglist):
      We don't want the same string multiple times in a tag list for the
      same tag ever, for any tag, not just for GST_TAG_GENRE, so make sure
      this doesn't happen and remove special-case code for GST_TAG_GENRE.
      62d8456e
  5. 11 Oct, 2007 1 commit
  6. 06 Oct, 2007 1 commit
    • Tim-Philipp Müller's avatar
      gst/id3demux/: Port ID3 tag demuxer over to the new GstTagDemux in -base (now... · 3e413d6b
      Tim-Philipp Müller authored
      gst/id3demux/: Port ID3 tag demuxer over to the new GstTagDemux in -base (now would be a good time to test re-importi...
      
      Original commit message from CVS:
      * gst/id3demux/gstid3demux.c:
      * gst/id3demux/gstid3demux.h:
      * gst/id3demux/id3tags.c:
      * gst/id3demux/id3tags.h:
      * gst/id3demux/id3v2frames.c:
      Port ID3 tag demuxer over to the new GstTagDemux in -base
      (now would be a good time to test re-importing your music
      collection).
      3e413d6b
  7. 12 Mar, 2007 1 commit
    • Tim-Philipp Müller's avatar
      gst/id3demux/id3v2frames.c: Fix parsing of ID3 v2.2.0 PIC frames. Only in... · 2354b65a
      Tim-Philipp Müller authored
      gst/id3demux/id3v2frames.c: Fix parsing of ID3 v2.2.0 PIC frames. Only in version >= 2.3.0 is the image format a vari...
      
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (parse_picture_frame):
      Fix parsing of ID3 v2.2.0 PIC frames. Only in version >= 2.3.0 is
      the image format a variable-length NUL-terminated string; in
      versions before that the image format is a fixed-length string of
      3 characters (see #348644 for a sample tag).
      Also make supplied mime type lower-case and fix up 'jpg' to 'jpeg'.
      2354b65a
  8. 06 Mar, 2007 1 commit
    • Tim-Philipp Müller's avatar
      gst/id3demux/: Do not convert obsolete TDA/TDAT frames to TDRC frames,... · 8ffc1761
      Tim-Philipp Müller authored
      gst/id3demux/: Do not convert obsolete TDA/TDAT frames to TDRC frames, otherwise the four-digit number will be interp...
      
      Original commit message from CVS:
      * gst/id3demux/id3tags.c: (id3demux_id3v2_frames_to_tag_list):
      * gst/id3demux/id3tags.h:
      * gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame),
      (parse_obsolete_tdat_frame):
      Do not convert obsolete TDA/TDAT frames to TDRC frames, otherwise
      the four-digit number will be interpreted as a year, whereas it is
      month and day in DDMM format. Instead, parse TDAT frames and fix up
      the date in the GST_TAG_DATE tag later if we also extracted a year.
      Fixes #407349.
      8ffc1761
  9. 19 Nov, 2006 1 commit
    • René Stadler's avatar
      gst/id3demux/id3v2frames.c: Make sure that g_free always gets called on the... · 3b4c2b05
      René Stadler authored
      gst/id3demux/id3v2frames.c: Make sure that g_free always gets called on the same pointer that was returned by g_mallo...
      
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame):
      Make sure that g_free always gets called on the same pointer that was
      returned by g_malloc.  Fixes #376594.
      Do not leak memory if decompressed size is wrong.
      Remove unneeded check of return value of g_malloc.
      Patch by: René Stadler <mail@renestadler.de>
      3b4c2b05
  10. 01 Nov, 2006 1 commit
    • Tim-Philipp Müller's avatar
      gst/id3demux/id3v2frames.c: We require a -base more recent than 0.10.9, so it's safe to use · 93c5c6fc
      Tim-Philipp Müller authored
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (parse_picture_frame):
      We require a -base more recent than 0.10.9, so it's safe to use
      GST_TYPE_TAG_IMAGE_TYPE unconditionally now.
      * ext/dv/gstdvdec.c: (gst_dvdec_sink_event):
      * ext/jpeg/gstjpegdec.c: (gst_jpeg_dec_sink_event):
      Use _newsegment_full() now that we depend on a recent enough core.
      * gst/wavparse/gstwavparse.c:
      Remove cruft that we don't need any longer now that we depend on
      a recent enough -base.
      93c5c6fc
  11. 05 Oct, 2006 1 commit
    • Tim-Philipp Müller's avatar
      Printf format fixes. · 82f5a350
      Tim-Philipp Müller authored
      Original commit message from CVS:
      * ext/cairo/gsttimeoverlay.c:
      (gst_cairo_time_overlay_update_font_height):
      * ext/gdk_pixbuf/pixbufscale.c: (gst_pixbufscale_transform_caps):
      * ext/jpeg/gstjpegdec.c: (gst_jpeg_dec_parse_image_data):
      * ext/jpeg/gstjpegenc.c: (gst_jpegenc_chain):
      * ext/jpeg/gstsmokedec.c: (gst_smokedec_chain):
      * ext/jpeg/gstsmokeenc.c: (gst_smokeenc_chain):
      * ext/libpng/gstpngdec.c: (user_endrow_callback):
      * gst/auparse/gstauparse.c: (gst_au_parse_parse_header):
      * gst/avi/gstavidemux.c: (gst_avi_demux_parse_superindex),
      (gst_avi_demux_parse_subindex), (gst_avi_demux_parse_stream),
      (gst_avi_demux_stream_data):
      * gst/cutter/gstcutter.c: (gst_cutter_chain):
      * gst/debug/efence.c: (gst_efence_buffer_alloc),
      (gst_fenced_buffer_copy):
      * gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame):
      * gst/matroska/matroska-demux.c: (gst_matroska_demux_add_stream):
      * gst/matroska/matroska-mux.c: (gst_matroska_mux_start):
      * gst/rtsp/gstrtspsrc.c: (gst_rtspsrc_send),
      (gst_rtspsrc_handle_message):
      * gst/wavparse/gstwavparse.c: (gst_wavparse_stream_headers):
      * sys/ximage/ximageutil.c: (ximageutil_xcontext_get):
      Printf format fixes.
      82f5a350
  12. 22 Aug, 2006 1 commit
    • Jan Schmidt's avatar
      gst/id3demux/id3v2frames.c: If strings in text fields are marked ISO8859-1,... · 66bbbfb7
      Jan Schmidt authored
      gst/id3demux/id3v2frames.c: If strings in text fields are marked ISO8859-1, but contain valid UTF-8 already, then han...
      
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (parse_text_identification_frame),
      (parse_insert_string_field):
      If strings in text fields are marked ISO8859-1, but contain
      valid UTF-8 already, then handle them as UTF-8 and ignore
      the encoding. (#351794)
      66bbbfb7
  13. 16 Aug, 2006 1 commit
    • Tim-Philipp Müller's avatar
      configure.ac: Require CVS of GStreamer core and -base (for · 81d46b82
      Tim-Philipp Müller authored
      Original commit message from CVS:
      * configure.ac:
      Require CVS of GStreamer core and -base (for
      GST_TAG_EXTENDED_COMMENT and gst_tag_parse_extended_comment()).
      * ext/taglib/gstid3v2mux.cc:
      Write extended comment tags properly (#348762).
      * gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame),
      (parse_comment_frame):
      Extract COMM frames into extended comments, which makes it
      easier to properly retain the description bit of the tag
      and maintain this information when re-tagging (#348762).
      81d46b82
  14. 22 Jun, 2006 1 commit
  15. 11 Jun, 2006 1 commit
  16. 28 May, 2006 1 commit
    • Tim-Philipp Müller's avatar
      gst/id3demux/id3v2frames.c: A track/volume number or count of 0 does not make... · e4bb4b89
      Tim-Philipp Müller authored
      gst/id3demux/id3v2frames.c: A track/volume number or count of 0 does not make sense, just ignore it along with negati...
      
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (id3v2_tag_to_taglist):
      A track/volume number or count of 0 does not make sense,
      just ignore it along with negative numbers (a tag might
      only contain a track count without a track number).
      e4bb4b89
  17. 19 May, 2006 1 commit
    • Jan Schmidt's avatar
      gst/id3demux/id3v2frames.c: Don't output any tag when we encounter a negative... · a4dbbd5d
      Jan Schmidt authored
      gst/id3demux/id3v2frames.c: Don't output any tag when we encounter a negative track number - the tag type is uint, so...
      
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (id3v2_tag_to_taglist):
      Don't output any tag when we encounter a negative track number - the
      tag type is uint, so we end up outputting huge positive numbers
      instead. (Fixes: #342029)
      a4dbbd5d
  18. 16 May, 2006 1 commit
    • Jan Schmidt's avatar
      gst/autodetect/: Make the name of the child element be based on the name of... · 6ac3f840
      Jan Schmidt authored
      gst/autodetect/: Make the name of the child element be based on the name of the parent, so that debug output is more ...
      
      Original commit message from CVS:
      * gst/autodetect/gstautoaudiosink.c:
      (gst_auto_audio_sink_find_best):
      * gst/autodetect/gstautovideosink.c:
      (gst_auto_video_sink_find_best):
      Make the name of the child element be based on the name of the
      parent, so that debug output is more useful.
      * gst/id3demux/id3v2frames.c: (find_utf16_bom),
      (parse_insert_string_field), (parse_split_strings):
      Rework string parsing to always walk over BOM markers in UTF16
      strings, using the endianness indicated by the innermost one,
      then trying the opposite endianness if that fails to convert
      to valid UTF-8. Fixes #341774
      6ac3f840
  19. 12 May, 2006 1 commit
  20. 10 May, 2006 1 commit
    • Jan Schmidt's avatar
      gst/id3demux/id3v2frames.c: Fix parsing of numeric genre strings some more, by... · 85c6182e
      Jan Schmidt authored
      gst/id3demux/id3v2frames.c: Fix parsing of numeric genre strings some more, by ensuring that we only try and parse st...
      
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (id3v2_genre_fields_to_taglist):
      Fix parsing of numeric genre strings some more, by ensuring that
      we only try and parse strings that a) Start with '(' and b) Consist
      only of digits.
      Also, when finding an escaping '((' sequence, bust it back to '(' by
      swallowing the first parenthesis
      85c6182e
  21. 28 Apr, 2006 1 commit
  22. 30 Mar, 2006 1 commit
    • Sébastien Moutte's avatar
      ext\jpeg\smokecodec.c: use of GST_DEBUG instead of DEBUG(a...) for WIN32 · 0debb1e9
      Sébastien Moutte authored
      Original commit message from CVS:
      * ext\jpeg\smokecodec.c:
      use of GST_DEBUG instead of DEBUG(a...) for WIN32
      * ext\speex\gstspeexenc.c: (gst_speexenc_set_header_on_caps):
      move first instruction after all variables declarations
      * gst\alpha\gstalpha.c:
      * gst\effectv\gstshagadelic.c:
      * gst\smpte\paint.c:
      * gst\videofilter\gstvideobalance.c:
      define M_PI if it's not defined (it's not defined on WIN32)
      * gst\cutter\gstcutter.c: (gst_cutter_chain):
      * gst\id3demux\id3v2frames.c: (parse_relative_volume_adjustment_two):
      * gst\level\gstlevel.c: (gst_level_set_property), (gst_level_transform_ip):
      * gst\matroska\matroska-demux.c: (gst_matroska_demux_parse_info),
      (gst_matroska_demux_video_caps):
      * gst\matroska\matroska-mux.c: (gst_matroska_mux_start), (gst_matroska_mux_finish):
      * gst\wavparse\gstwavparse.c: (gst_wavparse_stream_data):
      use gst_guint64_to_gdouble for conversions
      * gst\goom\filters.c: (setPixelRGB_):
      fix a debug which was using undefined variable
      * gst\level\gstlevel.c: (gst_level_set_caps), (gst_level_transform_ip):
      * gst\matroska\ebml-read.c: (gst_ebml_read_sint):
      replace LL suffix with L suffix (LL isn't supported by MSVC6.0)
      * win32/vs6:
      add vs6 projects files for most of plugins-good
      0debb1e9
  23. 16 Mar, 2006 2 commits
  24. 14 Mar, 2006 1 commit
  25. 18 Feb, 2006 1 commit
    • Jan Schmidt's avatar
      gst/id3demux/: Handle 0 data size in otherwise valid frames. · c64021f8
      Jan Schmidt authored
      Original commit message from CVS:
      * gst/id3demux/id3tags.c: (id3demux_id3v2_frames_to_tag_list):
      * gst/id3demux/id3v2frames.c: (id3v2_genre_fields_to_taglist):
      Handle 0 data size in otherwise valid frames.
      Handle numeric strings in 2.4.0 even when not in parentheses
      c64021f8
  26. 13 Feb, 2006 1 commit
    • Jan Schmidt's avatar
      gst/id3demux/id3v2frames.c: Add more validation to ensure that a char encoding... · 8d38cd44
      Jan Schmidt authored
      gst/id3demux/id3v2frames.c: Add more validation to ensure that a char encoding conversion produced a valid UTF-8 string.
      
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (parse_insert_string_field),
      (parse_split_strings):
      Add more validation to ensure that a char encoding conversion
      produced a valid UTF-8 string.
      8d38cd44
  27. 04 Feb, 2006 1 commit
  28. 03 Feb, 2006 1 commit
  29. 25 Jan, 2006 1 commit
    • Jan Schmidt's avatar
      gst/id3demux/id3v2frames.c: Never trust ANY information encoded in a media... · 73c1153f
      Jan Schmidt authored
      gst/id3demux/id3v2frames.c: Never trust ANY information encoded in a media file, especially when it's giving you size...
      
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame):
      Never trust ANY information encoded in a media file, especially
      when it's giving you sizes. (Fixes #328452)
      73c1153f
  30. 23 Jan, 2006 2 commits
    • Jan Schmidt's avatar
      gst/id3demux/id3v2frames.c: Remove errant break statement, and fix compilation with older GCC. · 7ca387e5
      Jan Schmidt authored
      Original commit message from CVS:
      * gst/id3demux/id3v2frames.c: (id3v2_tag_to_taglist):
      Remove errant break statement, and fix compilation with
      older GCC.
      7ca387e5
    • Jan Schmidt's avatar
      gst/id3demux/: Rewrite parsing of text tags to handle multiple NULL terminated... · 2ecee9a4
      Jan Schmidt authored
      gst/id3demux/: Rewrite parsing of text tags to handle multiple NULL terminated strings. Parse numeric genre strings a...
      
      Original commit message from CVS:
      * gst/id3demux/id3tags.c: (id3demux_read_id3v2_tag):
      * gst/id3demux/id3tags.h:
      * gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame),
      (parse_comment_frame), (parse_text_identification_frame),
      (id3v2_tag_to_taglist), (id3v2_are_digits),
      (id3v2_genre_string_to_taglist), (id3v2_genre_fields_to_taglist),
      (parse_split_strings), (free_tag_strings):
      Rewrite parsing of text tags to handle multiple NULL terminated
      strings. Parse numeric genre strings and ID3v2 type
      "(3)(6)Alternative" style genre strings.
      Parse dates that are only YYYY or YYYY-mm format.
      2ecee9a4
  31. 15 Jan, 2006 1 commit
  32. 06 Jan, 2006 1 commit
    • Edward Hervey's avatar
      gst/id3demux/gstid3demux.c: Add gst_element_no_more_pads() for proper decodebin behaviour. · c6b9d19c
      Edward Hervey authored
      Original commit message from CVS:
      * gst/id3demux/gstid3demux.c: (gst_id3demux_add_srcpad):
      Add gst_element_no_more_pads() for proper decodebin behaviour.
      * gst/id3demux/id3v2frames.c: (parse_comment_frame),
      (parse_text_identification_frame), (parse_split_strings):
      Failure to decode some tags is not a GST_ERROR() but a
      GST_WARNING()
      When iterating over a chunk of text, check that we haven't gone too
      far.
      c6b9d19c
  33. 18 Dec, 2005 1 commit
    • Jan Schmidt's avatar
      configure.ac: Check for optional dependency on zlib for id3demux · a05fc627
      Jan Schmidt authored
      Original commit message from CVS:
      * configure.ac:
      Check for optional dependency on zlib for id3demux
      
      * gst/id3demux/Makefile.am:
      * gst/id3demux/gstid3demux.c: (gst_gst_id3demux_get_type),
      (gst_id3demux_base_init), (gst_id3demux_class_init),
      (gst_id3demux_reset), (gst_id3demux_init), (gst_id3demux_dispose),
      (gst_id3demux_add_srcpad), (gst_id3demux_remove_srcpad),
      (gst_id3demux_trim_buffer), (gst_id3demux_chain),
      (gst_id3demux_set_property), (gst_id3demux_get_property),
      (id3demux_get_upstream_size), (gst_id3demux_srcpad_event),
      (gst_id3demux_read_id3v1), (gst_id3demux_read_id3v2),
      (gst_id3demux_sink_activate), (gst_id3demux_src_activate_pull),
      (gst_id3demux_src_checkgetrange), (gst_id3demux_read_range),
      (gst_id3demux_src_getrange), (gst_id3demux_change_state),
      (gst_id3demux_pad_query), (gst_id3demux_get_query_types),
      (simple_find_peek), (simple_find_suggest),
      (gst_id3demux_do_typefind), (gst_id3demux_send_tag_event),
      (plugin_init):
      * gst/id3demux/gstid3demux.h:
      * gst/id3demux/id3tags.c: (read_synch_uint),
      (id3demux_read_id3v1_tag), (id3demux_read_id3v2_tag),
      (id3demux_id3v2_frame_hdr_size), (convert_fid_to_v240),
      (id3demux_id3v2_frames_to_tag_list):
      * gst/id3demux/id3tags.h:
      * gst/id3demux/id3v2.4.0-frames.txt:
      * gst/id3demux/id3v2.4.0-structure.txt:
      * gst/id3demux/id3v2frames.c: (id3demux_id3v2_parse_frame),
      (parse_comment_frame), (parse_text_identification_frame),
      (id3v2_tag_to_taglist), (parse_split_strings):
      All new LGPL id3 demuxer. Can use zlib for compressed frames,
      otherwise it discards them. Works on my test files.
      
      * gst/wavparse/gstwavparse.c: (gst_wavparse_loop):
      Don't send EOS to a non-existing srcpad
      The debug category can be static
      a05fc627