Commit 7d6cf174 authored by Sebastian Dröge's avatar Sebastian Dröge

matroskademux: Fix memory leak when parsing attachments

gst_tag_image_data_to_image_sample() does not take ownership of the
passed memory, so don't set it to NULL to allow us to free it later.

https://bugzilla.gnome.org/show_bug.cgi?id=775472
parent d3bc50bc
......@@ -625,10 +625,9 @@ gst_matroska_read_common_parse_attached_file (GstMatroskaReadCommon * common,
tagsample =
gst_tag_image_data_to_image_sample (data, datalen, image_type);
if (!tagsample)
if (!tagsample) {
image_type = GST_TAG_IMAGE_TYPE_NONE;
else {
data = NULL;
} else {
tagbuffer = gst_buffer_ref (gst_sample_get_buffer (tagsample));
caps = gst_caps_ref (gst_sample_get_caps (tagsample));
info = gst_structure_copy (gst_sample_get_info (tagsample));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment