• akpm@linux-foundation.org's avatar
    mm/gup: add make_dirty arg to put_user_pages_dirty_lock() · 2d15eb31
    akpm@linux-foundation.org authored
    [11~From: John Hubbard <jhubbard@nvidia.com>
    Subject: mm/gup: add make_dirty arg to put_user_pages_dirty_lock()
    Patch series "mm/gup: add make_dirty arg to put_user_pages_dirty_lock()",
    There are about 50+ patches in my tree [2], and I'll be sending out the
    remaining ones in a few more groups:
    * The block/bio related changes (Jerome mostly wrote those, but I've had
      to move stuff around extensively, and add a little code)
    * mm/ changes
    * other subsystem patches
    * an RFC that shows the current state of the tracking patch set.  That
      can only be applied after all call sites are converted, but it's good to
      get an early look at it.
    This is part a tree-wide conversion, as described in fc1d8e7c ("mm:
    introduce put_user_page*(), placeholder versions").
    This patch (of 3):
    Provide more capable variation of put_user_pages_dirty_lock(), and delete
    put_user_pages_dirty().  This is based on the following:
    1.  Lots of call sites become simpler if a bool is passed into
       put_user_page*(), instead of making the call site choose which
       put_user_page*() variant to call.
    2.  Christoph Hellwig's observation that set_page_dirty_lock() is
       usually correct, and set_page_dirty() is usually a bug, or at least
       questionable, within a put_user_page*() calling chain.
    This leads to the following API choices:
        * put_user_pages_dirty_lock(page, npages, make_dirty)
        * There is no put_user_pages_dirty(). You have to
          hand code that, in the rare case that it's
    [jhubbard@nvidia.com: remove unused variable in siw_free_plist()]
      Link: http://lkml.kernel.org/r/20190729074306.10368-1-jhubbard@nvidia.com
    Link: http://lkml.kernel.org/r/20190724044537.10458-2-jhubbard@nvidia.com
    Signed-off-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Jan Kara <jack@suse.cz>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Ira Weiny <ira.weiny@intel.com>
    Cc: Jason Gunthorpe <jgg@ziepe.ca>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
gup.c 65.5 KB