• Jessica Yu's avatar
    modpost: move the namespace field in Module.symvers last · 5190044c
    Jessica Yu authored
    In order to preserve backwards compatability with kmod tools, we have to
    move the namespace field in Module.symvers last, as the depmod -e -E
    option looks at the first three fields in Module.symvers to check symbol
    versions (and it's expected they stay in the original order of crc,
    symbol, module).
    In addition, update an ancient comment above read_dump() in modpost that
    suggested that the export type field in Module.symvers was optional. I
    suspect that there were historical reasons behind that comment that are
    no longer accurate. We have been unconditionally printing the export
    type since 2.6.18 (commit bd5cbced), which is over a decade ago now.
    Fix up read_dump() to treat each field as non-optional. I suspect the
    original read_dump() code treated the export field as optional in order
    to support pre <= 2.6.18 Module.symvers (which did not have the export
    type field). Note that although symbol namespaces are optional, the
    field will not be omitted from Module.symvers if a symbol does not have
    a namespace. In this case, the field will simply be empty and the next
    delimiter or end of line will follow.
    Cc: stable@vger.kernel.org
    Fixes: cb9b55d2 ("modpost: add support for symbol namespaces")
    Tested-by: default avatarMatthias Maennich <maennich@google.com>
    Reviewed-by: default avatarMatthias Maennich <maennich@google.com>
    Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
    Signed-off-by: default avatarJessica Yu <jeyu@kernel.org>
    Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
modules.rst 17.5 KB