• Mark Rutland's avatar
    arm64: simplify dump_mem · 7ceb3a10
    Mark Rutland authored
    Currently dump_mem attempts to dump memory in 64-bit chunks when
    reporting a failure in 64-bit code, or 32-bit chunks when reporting a
    failure in 32-bit code. We added code to handle these two cases
    separately in commit e147ae6d
    
     ("arm64: modify the dump mem for
    64 bit addresses").
    
    However, in all cases dump_mem is called, the failing context is a
    kernel rather than user context. Additionally dump_mem is assumed to
    only be used for kernel contexts, as internally it switches to
    KERNEL_DS, and its callers pass kernel stack bounds.
    
    This patch removes the redundant 32-bit chunk logic and associated
    compat parameter, largely reverting the aforementioned commit. For the
    call in __die(), the check of in_interrupt() is removed also, as __die()
    is only called in response to faults from the kernel's exception level,
    and thus the !user_mode(regs) check is sufficient. Were this not the
    case, the used of task_stack_page(tsk) to generate the stack bounds
    would be erroneous.
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Cc: Will Deacon <will.deacon@arm.com>
    Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    7ceb3a10
traps.c 13.8 KB