Skip to content
  • Peter Zijlstra's avatar
    sched/core: Add missing update_rq_clock() in detach_task_cfs_rq() · 80f5c1b8
    Peter Zijlstra authored
    
    
    Instead of adding the update_rq_clock() all the way at the bottom of
    the callstack, add one at the top, this to aid later effort to
    minimize update_rq_lock() calls.
    
      WARNING: CPU: 0 PID: 1 at ../kernel/sched/sched.h:797 detach_task_cfs_rq()
      rq->clock_update_flags < RQCF_ACT_SKIP
    
      Call Trace:
        dump_stack()
        __warn()
        warn_slowpath_fmt()
        detach_task_cfs_rq()
        switched_from_fair()
        __sched_setscheduler()
        _sched_setscheduler()
        sched_set_stop_task()
        cpu_stop_create()
        __smpboot_create_thread.part.2()
        smpboot_register_percpu_thread_cpumask()
        cpu_stop_init()
        do_one_initcall()
        ? print_cpu_info()
        kernel_init_freeable()
        ? rest_init()
        kernel_init()
        ret_from_fork()
    
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-kernel@vger.kernel.org
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    80f5c1b8