Skip to content
  • Eric Sandeen's avatar
    hfsplus: handle more on-disk corruptions without oopsing · 9250f925
    Eric Sandeen authored
    hfs seems prone to bad things when it encounters on disk corruption.  Many
    values are read from disk, and used as lengths to memcpy, as an example.
    This patch fixes up several of these problematic cases.
    
    o sanity check the on-disk maximum key lengths on mount
      (these are set to a defined value at mkfs time and shouldn't differ)
    o check on-disk node keylens against the maximum key length for each tree
    o fix hfs_btree_open so that going out via free_tree: doesn't wind
      up in hfs_releasepage, which wants to follow the very pointer
      we were trying to set up:
    	HFS_SB(sb)->cat_tree = hfs_btree_open()
        .
      failure gets to hfs_releasepage and tries to follow HFS_SB(sb)->cat_tree
    
    Tested with the fsfuzzer; it survives more than it used to.
    
    [hch: ported of commit cf059462
    
     from hfs]
    [hch: added the fixes from 5581d018ed3493d226e7a4d645d9c8a5af6c36b]
    
    Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
    Signed-off-by: default avatarChristoph Hellwig <hch@tuxera.com>
    9250f925