Skip to content
  • Oleg Nesterov's avatar
    ptrace: __ptrace_detach: do __wake_up_parent() if we reap the tracee · a7f0765e
    Oleg Nesterov authored
    
    
    The bug is old, it wasn't cause by recent changes.
    
    Test case:
    
    	static void *tfunc(void *arg)
    	{
    		int pid = (long)arg;
    
    		assert(ptrace(PTRACE_ATTACH, pid, NULL, NULL) == 0);
    		kill(pid, SIGKILL);
    
    		sleep(1);
    		return NULL;
    	}
    
    	int main(void)
    	{
    		pthread_t th;
    		long pid = fork();
    
    		if (!pid)
    			pause();
    
    		signal(SIGCHLD, SIG_IGN);
    		assert(pthread_create(&th, NULL, tfunc, (void*)pid) == 0);
    
    		int r = waitpid(-1, NULL, __WNOTHREAD);
    		printf("waitpid: %d %m\n", r);
    
    		return 0;
    	}
    
    Before the patch this program hangs, after this patch waitpid() correctly
    fails with errno == -ECHILD.
    
    The problem is, __ptrace_detach() reaps the EXIT_ZOMBIE tracee if its
    ->real_parent is our sub-thread and we ignore SIGCHLD.  But in this case
    we should wake up other threads which can sleep in do_wait().
    
    Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
    Cc: Roland McGrath <roland@redhat.com>
    Cc: Vitaly Mayatskikh <vmayatsk@redhat.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    a7f0765e