Skip to content
  • Clemens Ladisch's avatar
    firewire: cdev: check write quadlet request length to avoid buffer overflow · a8e93f3d
    Clemens Ladisch authored
    
    
    Check that the data length of a write quadlet request actually is large
    enough for a quadlet.  Otherwise, fw_fill_request could access the four
    bytes after the end of the outbound_transaction_event structure.
    
    Signed-off-by: default avatarClemens Ladisch <clemens@ladisch.de>
    
    Modification of Clemens' change:  Consolidate the check into
    init_request() which is used by the affected ioctl_send_request() and
    ioctl_send_broadcast_request() and the unaffected
    ioctl_send_stream_packet(), to save a few lines of code.
    
    Note, since struct outbound_transaction_event *e is slab-allocated, such
    an out-of-bounds access won't hit unallocated memory but may result in a
    (virtually impossible to exploit) information disclosure.
    
    Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
    a8e93f3d