Skip to content
  • Linus Torvalds's avatar
    Revert "[PATCH] x86: __pa and __pa_symbol address space separation" · e3ebadd9
    Linus Torvalds authored
    
    
    This was broken.  It adds complexity, for no good reason.  Rather than
    separate __pa() and __pa_symbol(), we should deprecate __pa_symbol(),
    and preferably __pa() too - and just use "virt_to_phys()" instead, which
    is more readable and has nicer semantics.
    
    However, right now, just undo the separation, and make __pa_symbol() be
    the exact same as __pa().  That fixes the bugs this patch introduced,
    and we can do the fairly obvious cleanups later.
    
    Do the new __phys_addr() function (which is now the actual workhorse for
    the unified __pa()/__pa_symbol()) as a real external function, that way
    all the potential issues with compile/link-time optimizations of
    constant symbol addresses go away, and we can also, if we choose to, add
    more sanity-checking of the argument.
    
    Cc: Eric W. Biederman <ebiederm@xmission.com>
    Cc: Vivek Goyal <vgoyal@in.ibm.com>
    Cc: Andi Kleen <ak@suse.de>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    e3ebadd9